Date:   Wed, 8 Feb 2023 04:57:42 +0000
From:   Gary Guo <gary@garyguo.net>
To:     Boqun Feng <boqun.feng@gmail.com>
Cc:     linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
        Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        Vincenzo Palazzo <vincenzopalazzodev@gmail.com>,
        Will Deacon <will@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sergio =?UTF-8?B?R29uesOhbGV6?= Collado 
        <sergio.collado@gmail.com>, Finn Behrens <fin@nyantec.com>
Subject: Re: [PATCH v2 1/2] rust: sync: impl {Debug,Display} for
 {Unique,}Arc
Message-ID: <20230208045742.6b07ea09.gary@garyguo.net>
In-Reply-To: <20230207185216.1314638-2-boqun.feng@gmail.com>
References: <20230207185216.1314638-1-boqun.feng@gmail.com>
        <20230207185216.1314638-2-boqun.feng@gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7oWXbnItb66jt5STqe7yprAcvj/tz2jfh8LMyVOuqTz2uh8TgnNLsqsrSw9F?=
 =?us-ascii?Q?nsDnj4SLVMWhw4U69B3b/HqOGVf7NIfghp3/WWxkmhvkq/8tOGGvF2eBTTVi?=
 =?us-ascii?Q?TnpAuG3CdhGAQ6DeNyfTqjjHeiWd6bMYqRP+d3lFgTrltFSpH5CDMdSjR9VF?=
 =?us-ascii?Q?RERj0Qfy41WQcF5EZM0hREdd9CzTSgF2BnZ+3fec8kH1QKsWAg8uj2uZgQGY?=
 =?us-ascii?Q?2Lt4zJq3gFkt/We+rZpbgpMNKX8o+X2SAFqUj67M7F0PuBF5OUJYsrNS3V/p?=
 =?us-ascii?Q?tlQmqRTAq8scgPLiUoN4HCkMo//NsNRwEFKVKdarWAX41vHDHr/y5dZMgDXQ?=
 =?us-ascii?Q?z/ZgiJ1fRrKGCkPDphDsN4nj/G6fFuKIBLWvXu4bK4MOE0a9yHpIRvG2X4sM?=
 =?us-ascii?Q?u3QgKscafu1cdrA9Oxh2ZfSpqm9uJ2TIbQ1shYDD0mfgOQFClBL63nq17s12?=
 =?us-ascii?Q?p20H8vcDiqty+HGZZuDy5LXJsamogMXHQC/KYKRpGS14ndeFa9YaIC7pBoje?=
 =?us-ascii?Q?2QhlRt6L7/1Am15Zi1wuULmTIUYjsgXy/VyfpiuBxGZESanG6rJSJ8RRrFYM?=
 =?us-ascii?Q?lyMeNwttj8DLIhc3Z5Hr0pu7B6rN3kZXmcAA0G03wpifdt8Sw3aSODAfPz8M?=
 =?us-ascii?Q?wiaKw77V4lKdNvP5JVBpFgK2//IvryPhiX1v7aQLW/Pj4FM4ooXv7ygA+3gC?=
 =?us-ascii?Q?TvIWheWs5lJ+itejK75aG2qjjF+hkqNhcX0d/EQMI7+ar0s8LMLfkPekZiLz?=
 =?us-ascii?Q?Qdu2Wh7lZpFxDeH0BiRYWUz7oyVtbmPlQ/EFGzhiPnptrDBpg8191eWJ/1vq?=
 =?us-ascii?Q?0fsjXha5VjWdMJ2nB9tJFBVIFSmxPhPirtzUadMniiBJSyGgHkr61rusR9k0?=
 =?us-ascii?Q?QT7nI9oJYybD5idrVuwZbrO3MBSrW5bWFxjZB20Cov7GYHlYtVnvXUHJYoy5?=
 =?us-ascii?Q?18DfOXxwP48qakL+pyJVDJ+zuFl7W2y6Nxdr8/cJnh8XZaFuRP2RDqWb+Ohh?=
 =?us-ascii?Q?nCzAKozw0XG9zyQnF1zSsysrlkrUe4oIWgz16t1AqQ2A5QTMX4p0qgA+MpXI?=
 =?us-ascii?Q?qjV0esvLHn6hnrE59MxjmS8E2z6SyrdKQB8QKt7pXm/N9hXv+6iF+uGvLZA+?=
 =?us-ascii?Q?220c+ItxDssceW9T6sqgS48My/cI2AnXQ2vd4OL5bUxziHGqvN7PvNUSlrcY?=
 =?us-ascii?Q?gayCPFaIgP6fryCYpOKQ3/F4QWXoLMCQEAD5cgy/XiKU4WHfQfA11yRz7TuZ?=
 =?us-ascii?Q?bwHj8Tx8PMv4/HvwK7Ow8ubuF7BbjEfLPJZasPnO+mAtNJHVkXzVu+Mt62t1?=
 =?us-ascii?Q?8MBpvxJ2OUUjiPeLvq0L0OoVNbFbulZVhOON8xWZt1YEKUa8TE0B+be+S/9j?=
 =?us-ascii?Q?QXhS8/U4h9jB3ccA1WuGhwp/CR25pzWB4w3AxInYfeShqXL9VAlOeTbvR9ld?=
 =?us-ascii?Q?GTajDZPuOyJ4k7Kc6JT2KZg2/OzZ3kxft/9iHg3eiCEvmdhqp1NCu5ZZIMYl?=
 =?us-ascii?Q?/EMCx3qjCjUpwcSuaM2yqkwX2cjbIHz5bP1c48GnX1lWvmI2xbTjHLVMJRpW?=
 =?us-ascii?Q?mrROdp8l7tYcg64QRfM1m+bcGV9TTzifqD/QLj67?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 80247381-e4a5-40d8-e2b0-08db09910477
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 04:57:45.4492
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: apE2vGPOg3eWjjD0T0QK3MIpApVKfhdjfroG44EbjuE1HyGTXpbij+OIJB0w+fvFccizU1LWzFIRU2Fq1OIQ4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P265MB7287
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue,  7 Feb 2023 10:52:15 -0800
Boqun Feng <boqun.feng@gmail.com> wrote:

> This allows printing the inner data of `Arc` and its friends if the
> inner data implements `Display` or `Debug`. It's useful for logging and
> debugging purpose.
> 
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> Reviwed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/kernel/sync/arc.rs | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
> index 519a6ec43644..e6176d9b5b29 100644
> --- a/rust/kernel/sync/arc.rs
> +++ b/rust/kernel/sync/arc.rs
> @@ -22,6 +22,7 @@ use crate::{
>  };
>  use alloc::boxed::Box;
>  use core::{
> +    fmt,
>      marker::{PhantomData, Unsize},
>      mem::{ManuallyDrop, MaybeUninit},
>      ops::{Deref, DerefMut},
> @@ -522,3 +523,27 @@ impl<T: ?Sized> DerefMut for UniqueArc<T> {
>          unsafe { &mut self.inner.ptr.as_mut().data }
>      }
>  }
> +
> +impl<T: fmt::Display + ?Sized> fmt::Display for UniqueArc<T> {
> +    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
> +        fmt::Display::fmt(self.deref(), f)
> +    }
> +}
> +
> +impl<T: fmt::Display + ?Sized> fmt::Display for Arc<T> {
> +    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
> +        fmt::Display::fmt(self.deref(), f)
> +    }
> +}
> +
> +impl<T: fmt::Debug + ?Sized> fmt::Debug for UniqueArc<T> {
> +    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
> +        fmt::Debug::fmt(self.deref(), f)
> +    }
> +}
> +
> +impl<T: fmt::Debug + ?Sized> fmt::Debug for Arc<T> {
> +    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
> +        fmt::Debug::fmt(self.deref(), f)
> +    }
> +}