MIME-Version: 1.0
References: <cover.1675734681.git.chenfeiyang@loongson.cn> <2d77fe4e895847ae1ea09088dcfa411ce2f57f5f.1675734681.git.chenfeiyang@loongson.cn>
 <Y+Mc37ACt0PUBRAQ@1wt.eu> <20230208043440.GA3164268@paulmck-ThinkPad-P17-Gen-1>
In-Reply-To: <20230208043440.GA3164268@paulmck-ThinkPad-P17-Gen-1>
From:   Feiyang Chen <chris.chenfeiyang@gmail.com>
Date:   Wed, 8 Feb 2023 14:39:57 +0800
Message-ID: <CACWXhK=Jk+FsJ50mc2KFkFYMb9P1BXGv1D4dR=_M1gymqREpiA@mail.gmail.com>
Subject: Re: [PATCH 3/3] selftests/nolibc: Add support for LoongArch
To:     paulmck@kernel.org
Cc:     Willy Tarreau <w@1wt.eu>, Feiyang Chen <chenfeiyang@loongson.cn>,
        chenhuacai@kernel.org, jiaxun.yang@flygoat.com, arnd@arndb.de,
        loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 8 Feb 2023 at 12:34, Paul E. McKenney <paulmck@kernel.org> wrote:
>
> On Wed, Feb 08, 2023 at 04:54:07AM +0100, Willy Tarreau wrote:
> > On Tue, Feb 07, 2023 at 10:09:42AM +0800, chris.chenfeiyang@gmail.com wrote:
> > > From: Feiyang Chen <chenfeiyang@loongson.cn>
> > >
> > > Add support for LoongArch (64 bit) to nolibc selftest.
> >
> > Please also mention in this one that the makefile was reindented with
> > no other change than adding entries for loongarch, this will save
> > those reading this patch later from checking that the rest was not
> > changed.
>
> I like Willy's suggestion, but even better would be to put the whitespace
> changes into one commit, and the code changes into another commit.
> This makes it a lot easier for reviewers and future nolibc developers
> to quickly and easily see exactly what changed.
>

Hi, Willy, Paul,

I get it now, thank you.

> And one of those future nolibc maintainers just might be you!  ;-)
>
>                                                         Thanx, Paul

Thanks,
Feiyang