Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4544FC636D3 for ; Wed, 8 Feb 2023 06:54:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230289AbjBHGyD (ORCPT ); Wed, 8 Feb 2023 01:54:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbjBHGyC (ORCPT ); Wed, 8 Feb 2023 01:54:02 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 894C2442E5; Tue, 7 Feb 2023 22:54:00 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3A823B81C3A; Wed, 8 Feb 2023 06:53:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51395C433EF; Wed, 8 Feb 2023 06:53:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675839237; bh=j2RvOdUWlkVdm5KzuZffm+jK0TPD5jlPTX53boVgvQ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G0QvCMxjOILwJAETzf/YHrrhsa0Cm5OrmEIcdozmfoQrXMbEFqBAb+RHNbvV0Ltix +82ghijaXVk2mrmJvx+eygrOEhK1OVRKUxyGCTRhYbP+wZG7RYD+DEK+R7KXBrCd/i H8Ooo300eTbNzYhCmuWkp4QntINfggfaEP2L3cXA4lR/K8/lTwG6TDNRCPTrp0e8O8 OtCuR9NCEqnAgYkXUntuOsEAo5PNExyH3p5e2gu0FOsRgeOjnV5TDkgW3NeqZqjZLa uon5m0wrhy9Id6zQlVBUe+S+XKSKnZ44N/fA8p/tM2LRzjYdg3uoUEuVxRepDlUzfH y+fhfnWBj+7bQ== Date: Tue, 7 Feb 2023 22:53:55 -0800 From: Eric Biggers To: Linus Torvalds Cc: Dan Carpenter , linux-block@vger.kernel.org, Julia Lawall , Luis Chamberlain , Hongchen Zhang , Alexander Viro , Andrew Morton , "Christian Brauner (Microsoft)" , David Howells , Mauro Carvalho Chehab , Eric Dumazet , "Fabio M. De Francesco" , Christophe JAILLET , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, maobibo , Matthew Wilcox , Sedat Dilek Subject: Re: block: sleeping in atomic warnings Message-ID: References: <4ffbb0c8-c5d0-73b3-7a4e-2da9a7b03669@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 07, 2023 at 07:35:54PM +0000, Eric Biggers wrote: > Now, it's possible that "the kernel automatically adds the key for > test_dummy_encryption" could be implemented a bit differently. It maybe could > be done at the last minute, when the key is being looked for due to a user > filesystem operation, instead of during the mount itself. That would eliminate > the need to call fscrypt_destroy_keyring() from __put_super(), which would avoid > the issue being discussed here. I'll see if there's a good way to do that. "[PATCH 0/5] Add the test_dummy_encryption key on-demand" (https://lore.kernel.org/linux-fscrypt/20230208062107.199831-1-ebiggers@kernel.org/T/#u) implements this. - Eric