Date:   Wed, 8 Feb 2023 08:25:29 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Ronak Doshi <doshir@vmware.com>, netdev@vger.kernel.org,
        stable@vger.kernel.org,
        VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net ] vmxnet3: move rss code block under eop descriptor
Message-ID: <Y+NOaUHBQGxrYuf2@kroah.com>
References: <20230207192849.2732-1-doshir@vmware.com>
 <20230207221221.52de5c9a@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230207221221.52de5c9a@kernel.org>
Precedence: bulk

On Tue, Feb 07, 2023 at 10:12:21PM -0800, Jakub Kicinski wrote:
> On Tue, 7 Feb 2023 11:28:49 -0800 Ronak Doshi wrote:
> > Commit b3973bb40041 ("vmxnet3: set correct hash type based on
> > rss information") added hashType information into skb. However,
> > rssType field is populated for eop descriptor.
> > 
> > This patch moves the RSS codeblock under eop descritor.
> 
> Does it mean it always fails, often fails or occasionally fails 
> to provide the right hash?
> 
> Please add a Fixes tag so that the patch is automatically pulled 
> into the stable releases.

Fixes: is not the way to do this, you need a cc: stable in the
signed-off-by area please as the documentation has stated for 16+ years :)

thanks,

greg k-h