Date:   Wed, 8 Feb 2023 09:58:53 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc:     x86@kernel.org, Borislav Petkov <bp@alien8.de>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Andrew Cooper <Andrew.Cooper3@citrix.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/alternative: Support relocations in alternatives
Message-ID: <Y+NkTXTqlqKvEIA2@hirez.programming.kicks-ass.net>
References: <Y+EXQlGSI9WUU8nn@hirez.programming.kicks-ass.net>
 <20230207113813.rqwpuaung2hr433q@box.shutemov.name>
 <Y+J2x5sPU0uL8bE0@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+J2x5sPU0uL8bE0@hirez.programming.kicks-ass.net>
Precedence: bulk

On Tue, Feb 07, 2023 at 05:05:27PM +0100, Peter Zijlstra wrote:

> Also, Masami, how difficuly would it be to do insn_is_nop() that matches
> most/all conventional NOP instructions?

Just looked at that, while NOP and NOPL are relatively easy to do, the
32bit NOPs are a pain to decode since they're actual instructions with
the side-effect of not actually doing anything, like 'mov %reg,%reg' and
'lea (%reg),%reg'. Esp. that latter is popular since it has all the
various displacement encodings to grow it into a very long instruction.

I'll put it on the todo list I suppose, not something for now.