Message-ID: <251560a0-489f-eb54-d039-5270436117b9@suse.com>
Date:   Wed, 8 Feb 2023 10:26:58 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
From:   Oliver Neukum <oneukum@suse.com>
Subject: Re: [PATCH] scsi: dc395x: Replace arithmetic addition by bitwise OR
To:     Deepak R Varma <drv@mailo.com>, Ali Akcaagac <aliakc@web.de>,
        Jamie Lenehan <lenehan@twibble.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        dc395x@twibble.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Saurabh Singh Sengar <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
References: <Y+IQoG3aYdTfMStu@ubun2204.myguest.virtualbox.org>
Content-Language: en-US
In-Reply-To: <Y+IQoG3aYdTfMStu@ubun2204.myguest.virtualbox.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUttSFQvMkExTHg5a1VYaHZjYklUaWluRkFzR0RwSEdLcUtYTTBOV3p2T0Y4?=
 =?utf-8?B?SnUxRHVVOWlVUlZDM2hhNDFtcHJ4TmxoeTRNYndFaFF2T1dxRHFBQVlMbVk5?=
 =?utf-8?B?cmJieWIzekkxaXpyNVJlL05RYVhXazNZbmJwNVZJSm1xb1F6Q1NXdGRBU3BU?=
 =?utf-8?B?eTFRdlJRSWpTeGlKL20xc2RsRUZwbDk4enIreU82WGlaa2JLZDVWVnJNL0l0?=
 =?utf-8?B?REdLS1B2cG1iYjhGaERjdDM2L2lXR09XS3VTNmg3WEo5VEQ0TWdCa2hoUjZn?=
 =?utf-8?B?N1BPQWJ1TUR6V3gvWWo5YVpWWTVVQjY5bTRKM2pETS8xWFE5dEgybVdIZ0Rv?=
 =?utf-8?B?S0V2SW1OdENnaE9xK3lROTFSRkxEeEJ1aWhNYTFOQ09PdVVIL0dNS2szb0tt?=
 =?utf-8?B?S21sUktuUGV3Q2FUVUVuT0djdnFKeHFrU0RLenU5Nlh1ZllmN2Q1VW9id1RD?=
 =?utf-8?B?NXlEN0RaTzhIZEV6dUFMV1hFYXVsQ21ZbVF4VHkwdG44dW84TEJuQ2ZQMnQz?=
 =?utf-8?B?WVdJTExYeFk3Z2JHaW1MNWNSbFNPN1dod3ZobkN3VzdyQmQ4cG1sVUk2UkdH?=
 =?utf-8?B?NHltZkVRZnhyZ0dRREdlSjl1WlJNWHBOakI2MW04d29mV0d5ZHdRditCaDdy?=
 =?utf-8?B?OEtsTFlvODRheVpRRVFyY3R4K1JpTjJEUm5ONVpVb2FRSm9wNjN5blg0SWtP?=
 =?utf-8?B?N3dRSXdWN0tUZnpJbjVHaHdpQkhwUXpneDNQTHhPU0lNYmFacEVyd2lQVlBE?=
 =?utf-8?B?OEc0Wi9EUVZ0aHdUNzVSMG0xQzhLeGE3ZmlQdDZFSC9TcFpiS3dSQXNCV0RV?=
 =?utf-8?B?M2ZvL3pPN2NMZU5lZHBaOEtybnhuR2NWekFHRUYzQVdVT1BjWk9TYzhGQkRq?=
 =?utf-8?B?cDk4OXJLSkJRM0NYSlpUcEhsbWRqTFdIUm5kTXdzZnpZMTZQN2ZxZHVJZXB2?=
 =?utf-8?B?OWtFRVcwcnJNZUprSWJaa3VnMm5NdlFVRlVSQmpYRzlKeWxSc2FrcGlXZUpr?=
 =?utf-8?B?UER5b2hHeTllbVl6SGR0RjhLd3doVm5OTG9UeEovSHcwOGwxaS9idTYzUktn?=
 =?utf-8?B?VWI3N3M2WE9yaktkWkdoQTNCaUNMaHVIWEI1b2VibTRHMFRpbjFzVk5VL0Fx?=
 =?utf-8?B?Z1ljZlpUMGMrYi9FZEIzL0NETHJVdHg1MjNLQXN2TFVIY1ZwcGVwNVB4TVpr?=
 =?utf-8?B?MkVnVVZVblhNT1NpemFaQmhvbmEydStraHpzZkViaGRUWHlObWtNN2YxbUp0?=
 =?utf-8?B?c3FqS0dwVmFwcmN0c1FUVjQ4VVB4THhBK2d2c3FlZU0zcmhpazhlSFVjRmJS?=
 =?utf-8?B?anB4RkMwY3N3bnQ5UDJSWkp2emtyOFgxeXY1MjAwOFNEalB1VjREMzVUbmhr?=
 =?utf-8?B?NkRmT0w1bU4zbElSQmFMM1dnSVA5RmxONzlRMUthWXJFVGdWRVZKcVhUeG91?=
 =?utf-8?B?U29tN05ZZjJ2WjdLL0NMV1RITWZLdHBjcmdLWUtPVWZRZ21wWm9lN0tVT0Vv?=
 =?utf-8?B?SnF2ZXBub2hiek03a1Bna2JzNmRWMzFtUlZZbStVUVk1eTVGUE1oWG1nTkJF?=
 =?utf-8?B?akR4V1lSSlMwNkpqVFUxTWxTL2lEM1Z3Vi8zRlJHdStxOU8zTEl2R3o0NE4w?=
 =?utf-8?B?NzZhNWk0bUovaDZyQmJTcS9LeGEyNzBvWDlDSFp2TThGd0thdGFvZ2VKNDVx?=
 =?utf-8?B?dU53RHhlT3RHMUhEdnd0U1lvOGpuRy9zVFJnanpZUGJMY3BYOHFYVVRrTHM2?=
 =?utf-8?B?aVF2eld3M3puVlhLRWtVSkdxMDlTVXNuTmYrZEY3Zkg0d3Y2VTBvR0duait4?=
 =?utf-8?B?cWYzS2JORGJ1Z0JUT0xKMmpjK1l3Y3k4eTFQTTlvc2xuODlTblltd0dHMEM1?=
 =?utf-8?B?T1RXUjFPQ3RUSGZ3M3ZoWDk2Vy83SkxaRnlId2FPQ2I2ZGlRWHFzc1RENjNp?=
 =?utf-8?B?aTdwaFBkZTE1NXR4bENpSmJPUnRaQVRtaFlvWTdiU2QvSTVPMXNNamtZNE5O?=
 =?utf-8?B?TXJ5bndrc0JaVHNjcVl0aWMyNkl3NVBkQlNqYkdhUTRvQ09KdkxydVNxWmd5?=
 =?utf-8?B?TWVQSU44a04xQXFCaTRpc3N0ZjU1ZEZQeTBGZlJjUElEVHMyendiSDBVTkVF?=
 =?utf-8?B?aEd0UmFGc3lscGtmZEJVY0Y1WVZDN1ArbEw5UTdUL1BxZEg5anY0L3hsRlds?=
 =?utf-8?Q?2Q9D/qYxVeiIWCcZx4izWtNhmeS7QxLFhdRzTnuS86Kg?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19876611-b6a6-4a19-5d01-08db09b6a263
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 09:27:01.8987
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c7lKsV4r6fWsmBE2M5ZruTZChKFgAZWPrtcI8T3HBqX3W3VOAx0fvyau4d5YzEqacVNG6wXff/wH3LLQi/Pd8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6825
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 07.02.23 09:49, Deepak R Varma wrote:
> When adding two bit-field mask values, an OR operation offers higher
> performance over an arithmetic operation.

Hi,

I am sorry, but this change log makes no sense. These are constants.
The compiler turns that into one value in any case.
If you do a clean up, say so.

	Regards
		Oliver