Message-ID: <5d6c0f50-da59-8f4f-a04f-d24e3c0c2992@linaro.org>
Date:   Wed, 8 Feb 2023 11:02:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] mfd: qcom_rpm: use
 devm_platform_get_and_ioremap_resource()
Content-Language: en-US
To:     ye.xingchen@zte.com.cn, lee@kernel.org
Cc:     agross@kernel.org, andersson@kernel.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <202302081734511884545@zte.com.cn>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <202302081734511884545@zte.com.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8.02.2023 10:34, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  drivers/mfd/qcom_rpm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 8fea0e511550..086611322874 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -530,7 +530,6 @@ static int qcom_rpm_probe(struct platform_device *pdev)
>  {
>  	const struct of_device_id *match;
>  	struct device_node *syscon_np;
> -	struct resource *res;
>  	struct qcom_rpm *rpm;
>  	u32 fw_version[3];
>  	int irq_wakeup;
> @@ -576,8 +575,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
>  		return -ENODEV;
>  	rpm->data = match->data;
> 
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	rpm->status_regs = devm_ioremap_resource(&pdev->dev, res);
> +	rpm->status_regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
>  	if (IS_ERR(rpm->status_regs))
>  		return PTR_ERR(rpm->status_regs);
>  	rpm->ctrl_regs = rpm->status_regs + 0x400;