Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAF23C636CC for ; Wed, 8 Feb 2023 10:04:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231133AbjBHKDy (ORCPT ); Wed, 8 Feb 2023 05:03:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229739AbjBHKDW (ORCPT ); Wed, 8 Feb 2023 05:03:22 -0500 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEC3335BB; Wed, 8 Feb 2023 02:03:18 -0800 (PST) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3183TBEN010218; Wed, 8 Feb 2023 04:02:45 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=ix0NSZcDZRRO7mkidkQUjWySPIOK6axDiNLFsl+FgGs=; b=JURhOFVfF6VjquYHFMkuDrYzaQyHZYb4riLwfVvejT0AyKtTijSSP9mountka1v+btpR vGoiMValeQ9BE8x0VeXlKPBK44F5ZI5QTGg1NhSk4y6zoYjhkjxCzw29MzNZgW39Mj2B OH+CMn9ImtQMbHTtHHB01tuwHNB82nCW3hgCw8QTBunSI9dzeElRrQPjLv2X+h7uBDqL GENgzQeoXmoU0mTTnWpULAj9dsxNbUNPySqJHg87MSML4FFFwd4KWEp1iFO8QkvvdUyI B/ynPFi3TGe9z+u331fn4tpqpHpCnzk+9TRI+Brl/ak9E9V8FNASC+4WWtV24igGN8kl fg== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3nhnn7wsn0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Feb 2023 04:02:45 -0600 Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.21; Wed, 8 Feb 2023 04:02:43 -0600 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.21 via Frontend Transport; Wed, 8 Feb 2023 04:02:43 -0600 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 13BBF11C7; Wed, 8 Feb 2023 10:02:43 +0000 (UTC) Date: Wed, 8 Feb 2023 10:02:43 +0000 From: Charles Keepax To: Lucas Tanure CC: David Rhodes , Liam Girdwood , Krzysztof Kozlowski , Mark Brown , "Rob Herring" , Jaroslav Kysela , Takashi Iwai , , , , , Subject: Re: [PATCH v2 1/5] ASoC: cs35l41: Only disable internal boost Message-ID: <20230208100243.GD36097@ediswmail.ad.cirrus.com> References: <20230207162526.1024286-1-lucas.tanure@collabora.com> <20230207162526.1024286-2-lucas.tanure@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230207162526.1024286-2-lucas.tanure@collabora.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: 3cmNYM5ZB62VFtii5Orae4dChnwZCC9S X-Proofpoint-ORIG-GUID: 3cmNYM5ZB62VFtii5Orae4dChnwZCC9S X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 07, 2023 at 04:25:22PM +0000, Lucas Tanure wrote: > In error situations, only the internal boost case > should be disabled and re-enabled. > Also, for other boost cases re-enabling the boost > to the default internal boost config is incorrect. > > Fixes: 6450ef559056 ("ASoC: cs35l41: CS35L41 Boosted Smart Amplifier") > Signed-off-by: Lucas Tanure > --- Would quite like David to review as well, but looks good to me. Acked-by: Charles Keepax Thanks, Charles