Message-ID: <2e2ff1ec-34a9-db77-64d2-c088e5f1a13d@arinc9.com>
Date:   Wed, 8 Feb 2023 13:29:10 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v3 2/2] nvmem: brcm_nvram: use bcm47xx buffered data
To:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
        Willem-Jan de Hoog <wdehoog@exalondelft.nl>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Florian Fainelli <f.fainelli@gmail.com>
Cc:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1675717472.git.wdehoog@exalondelft.nl>
 <e179c12f73a6035690e814b842f677bbb38f5c96.1675717472.git.wdehoog@exalondelft.nl>
 <0496ff17-0a02-1192-3c9a-412656a38b6a@gmail.com>
Content-Language: en-US
From:   =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
In-Reply-To: <0496ff17-0a02-1192-3c9a-412656a38b6a@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 8.02.2023 13:25, Rafał Miłecki wrote:
> On 7.02.2023 09:42, Willem-Jan de Hoog wrote:
>> From: Willem-Jan de Hoog <wdehoog@exalondelft.nl>
>>
>> The bcm47xx module has a copy of the NVRAM data in ram. When 
>> available, use
>> this one instead of reading from io memory since it causes mtd/ubi to 
>> fail.
> 
> This doesn't explain anything. Why do we need that? If anything we
> should rather get rid of that NVRAM firmware driver. It was needed
> before we had all NVMEM stuff in place. Finally how can reading
> iomem break mtd/ubi?!

Did you take a look at the bootlog on this post on the thread, I've 
mentioned your user handle a few times but received no response on the 
forum.

https://forum.openwrt.org/t/asus-rt-ac88u-hw-a6-broken-in-22-03-3/147882/6?u=arinc9

Arınç