Date:   Wed, 8 Feb 2023 11:31:23 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Mikko Perttunen <cyndis@kapsi.fi>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Srikar Srimath Tirumala <srikars@nvidia.com>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        Timo Alho <talho@nvidia.com>, linux-pm@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] thermal: tegra-bpmp: Handle offline zones
Message-ID: <Y+N5+w8ePTVaZiIB@orome>
References: <20230207135610.3100865-1-cyndis@kapsi.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="HjTx0z3dHhZfFGiY"
Content-Disposition: inline
In-Reply-To: <20230207135610.3100865-1-cyndis@kapsi.fi>
User-Agent: Mutt/2.2.9 (2022-11-12)
Precedence: bulk


--HjTx0z3dHhZfFGiY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 07, 2023 at 03:56:08PM +0200, Mikko Perttunen wrote:
> From: Mikko Perttunen <mperttunen@nvidia.com>
>=20
> Thermal zones located in power domains may not be accessible when
> the domain is powergated. In this situation, reading the temperature
> will return -BPMP_EFAULT and the temperature is considered to be
> -256C for calculating trips.

Where's that -256C being set? I only see THERMAL_TEMP_INVALID being set
as the default for a zone, but that's not -274C, not -256C. If that's
the temperature that you're referring to, it might be better to state
that we rely on the default temperature rather than any specific number.

Thierry

>=20
> For smooth operation, for offline zones, return -EAGAIN when reading
> the temperature and allow registration of zones even if they are
> offline during probe.
>=20
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
>  drivers/thermal/tegra/tegra-bpmp-thermal.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/thermal/tegra/tegra-bpmp-thermal.c b/drivers/thermal=
/tegra/tegra-bpmp-thermal.c
> index c76e1ea62c8a..628b18818ae9 100644
> --- a/drivers/thermal/tegra/tegra-bpmp-thermal.c
> +++ b/drivers/thermal/tegra/tegra-bpmp-thermal.c
> @@ -52,6 +52,8 @@ static int __tegra_bpmp_thermal_get_temp(struct tegra_b=
pmp_thermal_zone *zone,
>  	err =3D tegra_bpmp_transfer(zone->tegra->bpmp, &msg);
>  	if (err)
>  		return err;
> +	if (msg.rx.ret =3D=3D -BPMP_EFAULT)
> +		return -EAGAIN;
>  	if (msg.rx.ret)
>  		return -EINVAL;
> =20
> @@ -257,7 +259,12 @@ static int tegra_bpmp_thermal_probe(struct platform_=
device *pdev)
>  		zone->tegra =3D tegra;
> =20
>  		err =3D __tegra_bpmp_thermal_get_temp(zone, &temp);
> -		if (err < 0) {
> +
> +		/*
> +		 * Sensors in powergated domains may temporarily fail to be read
> +		 * (-EAGAIN), but will become accessible when the domain is powered on.
> +		 */
> +		if (err < 0 && err !=3D -EAGAIN) {
>  			devm_kfree(&pdev->dev, zone);
>  			continue;
>  		}
> --=20
> 2.39.0
>=20

--HjTx0z3dHhZfFGiY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmPjefoACgkQ3SOs138+
s6HNvQ/8CxmmhYs401NGlAnZEwhKPe+pbajzCVbMB4cJB6yXLKRFrH9awIiSuCDR
pyYB0Fjk3MEuFazoquATiCt+O2biYJBOqiscEo8DxhNVzY37i9WxvBky6uV1bU1o
s95qpwPQJJHDJMb76qThUUJkl/5KBnYW2rBaVjSONddLykNkIuQ9bGhVVNDQcIWl
BuCtJEbA8IbWIvhhmKP49pdrOPjP3DMH2DNTeH4sEqdk6EjCYjpbaKCqDiGqU4gC
25S52UW8R0JrSkCRHpWP/68MG8TLlwOn373ZWQyVFj+WRHbIb462NaCgv7zNkEGl
3HMJlAIvTx5sEV9vrjDd6GYqwkXkJtFYq60PzL6BIVS73q8OGWEm2t8sQuZIpL+Y
WOCIQ4gg3yoUyLmy26lSMakP3csNq8zF5wgOo0MPA48KtK8fkm1uLhHzPdIt7dpT
XKVD/v0tS6vIY+5xsAho62jTYNGUSue7Y9wlxIv+XxUwEjFcAZuQ8o1MkdqoBXS4
Wu7tH6Bc8BAf9J0o3eiJvyU+/LZMD92amTKJy6GiTFmMrREhhg54l6ZBDizS6yIv
35+9I7dvLaWx87bdZM3aboUBsD6FH2cqQCrFHXeoJBQUk0yUJJDIKwAm3bCH/hvE
7aNXXzMpCu30hR4UQg6URX0x4YxfboYti5+TIJB2n4o1Yx/Nh4g=
=/bmI
-----END PGP SIGNATURE-----

--HjTx0z3dHhZfFGiY--