Date:   Wed, 8 Feb 2023 11:43:04 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Mikko Perttunen <cyndis@kapsi.fi>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Srikar Srimath Tirumala <srikars@nvidia.com>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        Timo Alho <talho@nvidia.com>, linux-pm@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] thermal: tegra-bpmp: Always (re)program trip
 temperatures
Message-ID: <Y+N8uMO3V5+YNm2E@orome>
References: <20230207135610.3100865-1-cyndis@kapsi.fi>
 <20230207135610.3100865-2-cyndis@kapsi.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ew2LPdXyK3eQEa6z"
Content-Disposition: inline
In-Reply-To: <20230207135610.3100865-2-cyndis@kapsi.fi>
User-Agent: Mutt/2.2.9 (2022-11-12)
Precedence: bulk


--ew2LPdXyK3eQEa6z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 07, 2023 at 03:56:09PM +0200, Mikko Perttunen wrote:
> From: Mikko Perttunen <mperttunen@nvidia.com>
>=20
> In the rare case that calculation of trip temperatures would result
> in the same trip temperatures that were previously programmed, the
> thermal core skips calling .set_trips.

That seems like an appropriate optimization.

> However, presently, if it is not called, we may end up with no trip
> temperatures programmed at all.

I have a hard time understanding when this would happen. prev_low_trip
and prev_high_trip are -INT_MAX and INT_MAX, respectively, so these are
unlikely to be the result of anything we compute at runtime, based on
temperatures specified in DT, for example.

So I would expect ->set_trips() to get called at least once when the
thermal zones are first registered. Are you saying there are cases where
->set_trips() doesn't get called at all?

> To avoid this, make set_trips a no-op and in places where it would be
> called, instead unconditionally program trip temperatures to the last
> specified temperatures.

Again, this seems more like a workaround for an issue that exists
elsewhere. If ->set_trips() doesn't always get called when it should be,
then that's what we should fix.

> This also fixes the situation where a trip is triggered between
> registering a thermal zone and registering the trip MRQ handler, in
> which case we would also get stuck.

Could this be fixed by requesting the MRQ prior to registering the
zones? That seems like the more appropriate fix for this issue. It's
similar to how we typically register IRQ handlers before enabling a
device to make sure we don't miss any interrupts.

Thierry

--ew2LPdXyK3eQEa6z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmPjfLYACgkQ3SOs138+
s6GPWxAArhyt+iI02V2C3/Gs+VnqJZUWEYdc3hzIshv4suUyn7d8uPbwddC5nSys
543utlVocIJrGF3YbKVGANp7C01SP7+NXXR/zAMFt7vbNLj8yIg7JYS4AsTr6W/j
N59Bku7wPiPJuHhv30BFfCSjOFUfN+M9HSYAeIp/rLwgtmZCUb1M7JPXIw0rzhty
WLoISXdgdmBBJEsReLqPyBFRsPxpSFI4Yc6HURTYHmSTPmIl6/4cmIQlkKcl/EvA
Id0i+Kd7cx/DWdjIsKOzjRU3ReX1B4pOke2c1Qeq1ZkQ71wurH9m7Q5C4QIYtpG5
lMZ5m99EQBZmjUOMvkW6TZyk0LOGhi5Bd5SJgzw2w7L1i7YVwGaMq2exM5n/PwAp
aHO0ij7v/tNRKFNyI6eDgnd1AaZCwvTqQFahvUSj+TsA4mJDMCWMdeDoQmHFxJC7
WBKjDWD5vp4PSu/Q0leZp3DYcTSlnCm5OHqmQ5kDjdZd20SJU5tXhx44xEgsvSv9
nFTC78C0P1Gzx2dnj033OvKlsVUViX2o/Mx2mHYuJelUvCMS0xreVDBqKP9NTtG7
JFBIYgcDiMAV+k2TfK8FwAPcX826ncl/HdqRL1ODD/QXNSAkPhQ8Ed944TlNkj7X
r5ognsL7VbbzT6KD4ST3MITLj/XSGcdqPr2zXTu/ZPnGN/8xo1g=
=TdpC
-----END PGP SIGNATURE-----

--ew2LPdXyK3eQEa6z--