Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753512AbXICQFV (ORCPT ); Mon, 3 Sep 2007 12:05:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751617AbXICQFL (ORCPT ); Mon, 3 Sep 2007 12:05:11 -0400 Received: from smtp-101-monday.noc.nerim.net ([62.4.17.101]:3236 "EHLO mallaury.nerim.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751518AbXICQFK (ORCPT ); Mon, 3 Sep 2007 12:05:10 -0400 Date: Mon, 3 Sep 2007 18:06:36 +0200 From: Jean Delvare To: Henrique de Moraes Holschuh Cc: "Mark M. Hoffman" , "Darrick J. Wong" , linux-kernel@vger.kernel.org, Pavel Machek , lm-sensors@lm-sensors.org Subject: Re: [lm-sensors] [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Message-ID: <20070903180636.4096e7d5@hyperion.delvare> In-Reply-To: <20070903020200.GA8948@khazad-dum.debian.net> References: <20070827211446.GG32667@tree.beaverton.ibm.com> <20070828015029.GA10107@khazad-dum.debian.net> <20070828131942.18449886@hyperion.delvare> <20070828164440.GL32667@tree.beaverton.ibm.com> <20070901171048.GA3883@ucw.cz> <41840b750709011105s6c434217t50d965a0b17df643@mail.gmail.com> <20070901194417.GA24897@khazad-dum.debian.net> <20070902213837.7293d6fa@hyperion.delvare> <20070903020200.GA8948@khazad-dum.debian.net> X-Mailer: Sylpheed-Claws 2.5.5 (GTK+ 2.10.6; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1191 Lines: 28 On Sun, 2 Sep 2007 23:02:01 -0300, Henrique de Moraes Holschuh wrote: > On Sun, 02 Sep 2007, Jean Delvare wrote: > > I guess power[1-*]_average would be OK? > > AFAIK, yes. It is probably not 100% in sync with the power supply class, > though. Is the power supply class creating sysfs files? I see a number of attributes listed in Documentation/power_supply_class.txt, but they are all uppercase, which doesn't seem suitable for sysfs file names. That document also doesn't list the numbering convention when multiple channels are present. My main worry is that we will have to add support for power measurement in libsensors, and I would like it to be as easy as possible. Thus sticking to the same naming convention hwmon have been using for years appears to be the best solution. I see that the power supply class units are 10^-6 A and 10^-6 W, so if we are supposed to be compatible, I guess we'll have to use this too. -- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/