Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E63C636D6 for ; Wed, 8 Feb 2023 11:30:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231195AbjBHLaZ (ORCPT ); Wed, 8 Feb 2023 06:30:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229874AbjBHLaW (ORCPT ); Wed, 8 Feb 2023 06:30:22 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A601E3FF0D; Wed, 8 Feb 2023 03:30:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3E6F361620; Wed, 8 Feb 2023 11:30:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 987A5C433EF; Wed, 8 Feb 2023 11:30:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675855820; bh=8C+rOH893QqgddkvCQP1/h8j9ver38ybtqBPi6HyGaQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AaaQ9nUUksA3G1/c0S0Yj7ADWZ8sBnnheEa7hCAUj1WTZ2oQP66WyaLsIePLKGkoV 4wmEOUuZHur/jHc97RKr5LHAEU0rUp/iQvJns87Jnw3kiINeefMtIZ05EnjzuKnhHn ZqXgSBqaJ6/HZT9cUBsKoLAMnVpz/PNs7K3rwAy6RcFroXAnxhHtmuYZsK1/N2A2F2 uuJFi2bB4VGaeuhyLjW4x3N2fm4VFasYB9taLlpVhvXFIpatX/I8xnic9rBE52lZGR mQEwLRdYhI4hzLXguPzRxEIEBgCA67Ho0nrKXCQWLQ6m9Puc+Kb21Sd4GwCLrVg8VE p6eQvbbFtpyww== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pPieX-008dxM-6T; Wed, 08 Feb 2023 11:30:18 +0000 Date: Wed, 08 Feb 2023 11:30:16 +0000 Message-ID: <86k00sz96f.wl-maz@kernel.org> From: Marc Zyngier To: Zaid Al-Bassam Cc: Jesus Sanchez-Palencia , Russell King , Catalin Marinas , Will Deacon , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH 5/8] perf: pmuv3: Change GENMASK to GENMASK_ULL In-Reply-To: <20230126204444.2204061-6-zalbassam@google.com> References: <20230126204444.2204061-1-zalbassam@google.com> <20230126204444.2204061-6-zalbassam@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: zalbassam@google.com, jesussanp@google.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Jan 2023 20:44:41 +0000, Zaid Al-Bassam wrote: > > GENMASK macro uses "unsigned long" (32-bit wide on arm and 64-bit > on arm64), This causes build issues when enabling PMUv3 on arm as > it tries to access bits > 31. This patch switches the GENMASK to > GENMASK_ULL, which uses "unsigned long long" (64-bit on both arm > and arm64). > > Signed-off-by: Zaid Al-Bassam Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.