Date:   Wed, 8 Feb 2023 12:38:03 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Manikanta Maddireddy <mmaddireddy@nvidia.com>
Cc:     bhelgaas@google.com, petlozup@nvidia.com,
        rafael.j.wysocki@intel.com, lpieralisi@kernel.org, robh@kernel.org,
        jeffy.chen@rock-chips.com, krzysztof.kozlowski+dt@linaro.org,
        jonathanh@nvidia.com, dmitry.osipenko@collabora.com,
        viresh.kumar@linaro.org, gregkh@linuxfoundation.org,
        steven.price@arm.com, kw@linux.com, linux-pci@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
        vidyas@nvidia.com
Subject: Re: [RFC,v14 5/5] soc/tegra: pmc: Add Tegra234 PCIe wake event
Message-ID: <Y+OJmwo9rnM8Pf7C@orome>
References: <20230208111645.3863534-1-mmaddireddy@nvidia.com>
 <20230208111645.3863534-6-mmaddireddy@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="dnbnZrtOx6z+VY5P"
Content-Disposition: inline
In-Reply-To: <20230208111645.3863534-6-mmaddireddy@nvidia.com>
User-Agent: Mutt/2.2.9 (2022-11-12)
Precedence: bulk


--dnbnZrtOx6z+VY5P
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 08, 2023 at 04:46:45PM +0530, Manikanta Maddireddy wrote:
> Enable PCIe wake event for the Tegra234 SoC.
>=20
> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
> ---
>=20
> Changes in v14:
> New patch in the series to support PCIe WAKE# in NVIDIA Jetson AGX Orin.
>=20
>  drivers/soc/tegra/pmc.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index cf4cfbf9f7c5..139ee853c32b 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -4225,6 +4225,7 @@ static const char * const tegra234_reset_sources[] =
=3D {
>  };
> =20
>  static const struct tegra_wake_event tegra234_wake_events[] =3D {
> +	TEGRA_WAKE_GPIO("pcie", 1, 0, TEGRA234_MAIN_GPIO(L, 2)),

What about wake events for other PCIe controllers? Do we need/want to
distinguish by name for those?

Thierry

--dnbnZrtOx6z+VY5P
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmPjiZsACgkQ3SOs138+
s6FTQQ//bp+B9n3mYGVuvDzX9NWcWCHqc2XpUYQR18NCUHsooWsDWcMThpRyIuTE
WPb0w2m6Su1pSl00uBf/be6yRX5kf/VFpxwRvQNBEx7pYtKVKHfVBHobRFMrODd2
baY2qAKGEFKGM0bKjnYLP46NsNGCthYv8xE5iuMKORZt6Vl6oWJ4ijNF62xiPRya
VfCIBQ30rHdgYZv6Zewg7u1g8mSsDnGi7tXj4PmXoX9BBtLCuA0J5a4oFEMOSrNL
lfw+cyKNFj4jBLFvzA9rshYCNs1W52FTUPGB+Voz3OsKv9oaaQl0GVhSH6w/32gD
GoYIPYymI60cKh2Epy5fz6xtM4DOTZ7a6AEuy5DSilKv4Fgc19ZCJskAe/4LkZKG
BDpCEbCB2ZUkw7xVO+2l14KO2rGnbofvLnbozoGwQOO3LBKr2sQ9YDfc8VQP5nVq
fzKXMYGN+8i375PkifKpK3QjoKBfFVCAvlHQG/nT298i+IAWdo3MieLfqhWnmmYW
rmydUuIi0ZWsAJd6FF0G8s8biuo87NQQa4xOu78GBZCz2NQPYuE6YWupnyl07Hpv
AQj9EwsdKh9WXKyOQoL/zCWkHh3D74MUPyfZKcFV3aH6ij95bnsOysu5P5/u/6Cc
Xmu/QjgFo3oxMaPNzWdNMwR5iN0okECXxwzvRf7eTrK7KNOUEHU=
=LtGa
-----END PGP SIGNATURE-----

--dnbnZrtOx6z+VY5P--