Date:   Wed, 8 Feb 2023 12:44:44 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Manikanta Maddireddy <mmaddireddy@nvidia.com>
Cc:     bhelgaas@google.com, petlozup@nvidia.com,
        rafael.j.wysocki@intel.com, lpieralisi@kernel.org, robh@kernel.org,
        jeffy.chen@rock-chips.com, krzysztof.kozlowski+dt@linaro.org,
        jonathanh@nvidia.com, dmitry.osipenko@collabora.com,
        viresh.kumar@linaro.org, gregkh@linuxfoundation.org,
        steven.price@arm.com, kw@linux.com, linux-pci@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
        vidyas@nvidia.com
Subject: Re: [RFC,v14 2/5] of/irq: Adjust of_pci_irq parsing for multiple
 interrupts
Message-ID: <Y+OLLMrHqMCrHxLB@orome>
References: <20230208111645.3863534-1-mmaddireddy@nvidia.com>
 <20230208111645.3863534-3-mmaddireddy@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="v95VmpPpGmMBEVze"
Content-Disposition: inline
In-Reply-To: <20230208111645.3863534-3-mmaddireddy@nvidia.com>
User-Agent: Mutt/2.2.9 (2022-11-12)
Precedence: bulk


--v95VmpPpGmMBEVze
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 08, 2023 at 04:46:42PM +0530, Manikanta Maddireddy wrote:
> From: Jeffy Chen <jeffy.chen@rock-chips.com>
>=20
> Currently we are considering the first irq as the PCI interrupt pin,
> but a PCI device may have multiple interrupts(e.g. PCIe WAKE# pin).
>=20
> Only parse the PCI interrupt pin when the irq is unnamed or named as
> "pci".
>=20
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
> ---
>=20
> Changes in v14:
> Address Rob's comment on using of_property_match_string().
>=20
> Changes in v13: None
> Changes in v12: None
> Changes in v11:
> Address Brian's comments.
>=20
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6: None
> Changes in v5: None
> Changes in v3: None
> Changes in v2: None
>=20
>  drivers/pci/of.c | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/pci/of.c b/drivers/pci/of.c
> index 196834ed44fe..ff897c40ed71 100644
> --- a/drivers/pci/of.c
> +++ b/drivers/pci/of.c
> @@ -429,9 +429,17 @@ static int of_irq_parse_pci(const struct pci_dev *pd=
ev, struct of_phandle_args *
>  	 */
>  	dn =3D pci_device_to_OF_node(pdev);
>  	if (dn) {
> -		rc =3D of_irq_parse_one(dn, 0, out_irq);
> -		if (!rc)
> -			return rc;
> +		int index =3D 0;

No need to initialize to 0 here since you're assigning to it immediately
below.

Otherwise, looks good, so with that initialization dropped, this is:

Reviewed-by: Thierry Reding <treding@nvidia.com>

--v95VmpPpGmMBEVze
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmPjiywACgkQ3SOs138+
s6FFWBAAjd2UbNIacqzrXJOtdU+WBjvCkgGerX8q/xOzDljt+WqdwHORW+tt9gCq
vglBKd9huBKGPu+CiVuRmTxfczpIc1QFORetj7N8oJUlgi9upg6OwXCOBftU0ywa
cU96BM9XqENm+00xCO70qZu893pE1805QHLpeMb2ydYSFORoxKSZQb4TgQLe6Sbp
nmp4bndWeBjfeiWTn+3Ot04N3VBInz9+Lby+WrFs7s/Gr1wrrCAQTMbnIDB+O448
NDZBsSe6DJ2ONPTGiO65dJ1NAZJXcdlxPqSEwXKA3gp3BbUB4MJHvZ6AeED0EVVd
UUziz1tTCxoxsNmbN5Pw2AxX7gmt6hDRF4MlEL9nk9v3rY2sb7kOv3fFYp44b+F2
ebtxH9fZOsmm9VbPqGelqKx7sJy+7BBEZpKFldo59p3ENiSl5Tt3v6rM9hw51QuF
v/6/wzfkxarm2aXUoGjuXGPBNyIbkmGxrZPSEb1tMCx6JBKRVYxrOH+cA/T4FuLt
T6Gf67tjzYUyWZyRnUAnHq0awcOg2jIsYK5n0HhTJiB8iFHUXkuaMqCikxkAdL4p
QUbksIk5s0ai8T6G8yvXNdGMBjl7W8kv6y8Z/Dok8+wMRAMEIVfCt0CWEp1r9Ji0
Ly8iZHMYmoxHjAG1JtzBaI6NN/Y8RcSOaBosEmFv9euM/MmiYHY=
=7+YZ
-----END PGP SIGNATURE-----

--v95VmpPpGmMBEVze--