Message-ID: <2c65fdac-0ea9-fff5-7cc8-bb964cb8fb14@nvidia.com>
Date:   Wed, 8 Feb 2023 17:36:05 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [RFC,v14 5/5] soc/tegra: pmc: Add Tegra234 PCIe wake event
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     bhelgaas@google.com, petlozup@nvidia.com,
        rafael.j.wysocki@intel.com, lpieralisi@kernel.org, robh@kernel.org,
        jeffy.chen@rock-chips.com, krzysztof.kozlowski+dt@linaro.org,
        jonathanh@nvidia.com, dmitry.osipenko@collabora.com,
        viresh.kumar@linaro.org, gregkh@linuxfoundation.org,
        steven.price@arm.com, kw@linux.com, linux-pci@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
        vidyas@nvidia.com
References: <20230208111645.3863534-1-mmaddireddy@nvidia.com>
 <20230208111645.3863534-6-mmaddireddy@nvidia.com> <Y+OJmwo9rnM8Pf7C@orome>
Content-Language: en-US
From:   Manikanta Maddireddy <mmaddireddy@nvidia.com>
In-Reply-To: <Y+OJmwo9rnM8Pf7C@orome>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmhqbGw0WEhkaUlFUnBVTHl0c3dwaGxYOTdMT2UvTGlTZGZjazJYN1VtU0lZ?=
 =?utf-8?B?SStZOGFkZjRIdy91STRjM1FyYklXT1NRRFMrbU04eldZdjFkZ3hBc0ZVc0Za?=
 =?utf-8?B?TWRuL0RUclFWNkFuYWNQT0FHSUk4YUlqR3Y1SElKYzhPV1hnNlM4NFRsWS9Y?=
 =?utf-8?B?WVFpMkZBWWRWeXJXVHJBeWYzT3NJVzRlMzc1aUo3YktnZkRzaGo4K3hJUlht?=
 =?utf-8?B?QU1EWVN5ZTQwN09BdlQwNFJFREw5SmxIRDlmOTZzeExVSDluWHd4ajBqQTFX?=
 =?utf-8?B?Z09BR0cveDZlcWNjOWtGa0dwbVM5alRJcC81MHJBOEJ0azF1WTlmTEFIN2NX?=
 =?utf-8?B?MWRrVDliMUNaSlRvb3VGRHBBWFJUaDBQb3pSdDJldXZoSDQ1enI1K21IYlJ1?=
 =?utf-8?B?YmJEV2lWOCt4TkNOQ25yM1NES0NrTVZoL3BRdDd6WlRnaDI1WnN1THVlVFB4?=
 =?utf-8?B?ZUljclJoelArSzZhejFzbXBXN1h3L0haVHJhM3VZSncrZlV4R3g2Z1AwdWZC?=
 =?utf-8?B?KzhldUJmZkZpWGJRVndpbllRQjdFQmpUYmhUdEsvem5DdThycmRRUk9iNngz?=
 =?utf-8?B?M3pxVjhZZVgyUHFGd1ZFaG9ZVlVTdGpIVFNDd2g3NWRqNWhpcU4yWnpqZk9B?=
 =?utf-8?B?WElPcVBMNmN4Y2FnKzlvaGZLdUlsY3ZEd09xaE9nTWdjR3hjS2NJL3UvWWhR?=
 =?utf-8?B?QkttMmNQMjNyQW8xUVU4OXkxZGdPY0lOeWFTQU13RW1iS0F1MXA2M1VCeUxt?=
 =?utf-8?B?R0ZyTkF4QURDM05aZThlRWtTMm83Zy9ZcUhrQVFQdFVpaWtXZTRJUTR5T1Rz?=
 =?utf-8?B?ZXcxckxwcUF6QXpaaGNNQlVJc1VpU2NIbENUZlpNS0RFcUJ0ZU52UW1xRlVP?=
 =?utf-8?B?YUZEUW14cXowK0crUXp2a0o0OS8zYmhHbzVRTTV1RGY5bDZrTy9EYzlYN1pX?=
 =?utf-8?B?RHIyalQrNEhKVDQxL1ltNWVNenlkdVZmTzQwL0RWZ1lPeDFtWkFCZFlmQVNz?=
 =?utf-8?B?aDJOZmdGNE9kUmdoZ0dCcEZxZ2lpemd4WDJQMjlpTkpXUmNoOEFwY0Q1UHdQ?=
 =?utf-8?B?bHc0NEtGRVhpV04xT3d0K2hOdWR3aktzd1FrTFJzanZDR052TW9lc1NKbktX?=
 =?utf-8?B?WnF0WUZ2YXBTb0pVbGY4OFdkazV6VVZ1dEZ5aDlQSTdtOFpNY3BHZHRONVIv?=
 =?utf-8?B?YjBGd2VSd1NGT3dGbTR4dUJhL1krdGIySkczNlI5Zy9TMHR0UXc2Z0w0eFVU?=
 =?utf-8?B?S2g5cW9jUHJURW9mVlRLMFVZT2s1MVdMek5Ga1NobkRVZmJtODRyLzk0N3dX?=
 =?utf-8?B?VGtVc2JlQllDTEtRdEJmTy9jQWNKbVNNOEg3bWhLQUs3d1lQbjByelU5N1hR?=
 =?utf-8?B?ankzQzJTcTZ4L2N4NWJkTHhGNzVXTGJkbUg3eE9wV0V0MEJWYmQ2cTVVb1I2?=
 =?utf-8?B?TVJSZnRlbVc5NGVzS3BFc2pNQUFDTVFtRHZOTWYxWS8xOExKd3RtanRZUm80?=
 =?utf-8?B?QkRiM0txSXBIek9ZRDRBR3RqckhKSFFuQi94SlJUK2w0ZE1TNHljYTBvbEUv?=
 =?utf-8?B?SFViOHpzZ1ZYcjA5RkNsTFdKNGJhZkRNajk2Y0lWd1NIKzhqSmoza3c2MWZ1?=
 =?utf-8?B?TkdXZzRMZ2VoQUgzQzBCNWIrN1l5Yy9jcEZNZlBoYzRJcXZ2cmtvNEZCOXhB?=
 =?utf-8?B?TTRrUUluNUtvNVh2eXZOcW5uTWczQlZNMDR6UFpLWmhYajBvR3JIYThab3Qv?=
 =?utf-8?B?TE44UHFnYmVmZUFTOWlYVXdFRDNnUTM5WDJab0FqYmRCejEwclRneDllb09F?=
 =?utf-8?B?bFdHRjhNOWZtekl6U21rZTA3RFpGeWxkeElTNlppQU1ZZTBoTS83ZFJiUXlN?=
 =?utf-8?B?ZE83aGJrN0VmZ3VjQmptTDdrMFVwSXNMUVZnbGVwaVhnZmFJZk83RFJEd1hT?=
 =?utf-8?B?NjE5TkpiN2pLaU1Rd2QyYWw1a0ozSEZKWTkzNmg1NmNKajFiNVNzaEd5Tm0v?=
 =?utf-8?B?YWRmWVk1c3E1TzBoYU5zSERYUUJPWGx0RXBXa2NCUGNHVUJTVGlPV2poRFZC?=
 =?utf-8?B?eWgyQURrZUJqQ055a0Y4Z1RaV3VKUlJ2bURsVFRhUmU4ZEFKVHJUUXowcnFX?=
 =?utf-8?B?bzMzRWpuZ2E2Vm1LSmhFZW1oMitaN3QyVWJOTm8wNFFKdTlxOUZuWjgrbW9P?=
 =?utf-8?B?Nmc9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b472d2b-f5dc-480d-95b1-08db09cce48e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3356.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 12:06:21.9803
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NF+8bhRf+K0btKk5Mo+zrlkyD6fpesNGkPppBLNDezv4PCXutxJzeEBmcXYnwVAg3MBdBXbEYx0Vh/aS1eZthQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7369
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/8/2023 5:08 PM, Thierry Reding wrote:
> On Wed, Feb 08, 2023 at 04:46:45PM +0530, Manikanta Maddireddy wrote:
>> Enable PCIe wake event for the Tegra234 SoC.
>>
>> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
>> ---
>>
>> Changes in v14:
>> New patch in the series to support PCIe WAKE# in NVIDIA Jetson AGX Orin.
>>
>>   drivers/soc/tegra/pmc.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
>> index cf4cfbf9f7c5..139ee853c32b 100644
>> --- a/drivers/soc/tegra/pmc.c
>> +++ b/drivers/soc/tegra/pmc.c
>> @@ -4225,6 +4225,7 @@ static const char * const tegra234_reset_sources[] = {
>>   };
>>   
>>   static const struct tegra_wake_event tegra234_wake_events[] = {
>> +	TEGRA_WAKE_GPIO("pcie", 1, 0, TEGRA234_MAIN_GPIO(L, 2)),
> What about wake events for other PCIe controllers? Do we need/want to
> distinguish by name for those?
>
> Thierry
Only one wake gpio is defined for PCIe in Tegra234. There is no 
implementation
withinPCIe controller, so any wake capable gpio can be used for PCIe wake.
As of now wedon't have a platform where different wake pins connected to 
PCIe slot.
If any platform use new pins for PCIe wake then we can add to this list.


Manikanta