Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BD4DC05027 for ; Wed, 8 Feb 2023 12:07:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229519AbjBHMHD (ORCPT ); Wed, 8 Feb 2023 07:07:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231225AbjBHMG5 (ORCPT ); Wed, 8 Feb 2023 07:06:57 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C1C94A1FB; Wed, 8 Feb 2023 04:06:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E421561156; Wed, 8 Feb 2023 12:06:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E961FC4339B; Wed, 8 Feb 2023 12:06:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675858005; bh=6sb43CTJMs35Ia7rJ1LCIwaaOvhNS0NqU4vISF25NJs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ek6elGADG4qhqB3KFj6/+rVK7X4H+oB3ILzZ21eQMyndkNQyh0id+IzUez4PftmF5 vsUVXg4DXJrgc6Al9cfdtTkj+JrMZlTzg0M/Er4eBNxqL5gIErmu2oFEmwQ1WoUTDm 3tMVicrG92fAUlDYOlfRM0i1Zf5kGz4lp6wohsaA= Date: Wed, 8 Feb 2023 13:06:42 +0100 From: Greg Kroah-Hartman To: Paul Cercueil Cc: Sascha Hauer , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 1/2] usb: gadget: u_ether: Do not make UDC parent of the net device Message-ID: References: <20221104131031.850850-1-s.hauer@pengutronix.de> <20221104131031.850850-2-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 01, 2023 at 01:32:51PM +0000, Paul Cercueil wrote: > Hi Sascha, Greg, > > I have a breakage in 6.2-rc* that I eventually bisected to this commit, > on a Ingenic SoC (using the jz4740 musb driver) with ECM or RNDIS > configured through gadgetfs. > > When plugging the board to my PC, the USB network interface is > recognized, but 'ip link' sees it as 'NO-CARRIER'. With this commit > reverted on v6.2-rc5, everything works fine. Ick, that's not good. Can you send a revert for this? Sascha, any ideas? thanks, greg k-h