Message-ID: <1b24e9f5-539a-dd0f-6485-5dbf3757ef27@nvidia.com>
Date:   Wed, 8 Feb 2023 17:43:35 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [RFC,v14 4/5] arm64: tegra: Add PCIe port node with PCIe WAKE#
 for C1 controller
Content-Language: en-US
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     bhelgaas@google.com, petlozup@nvidia.com,
        rafael.j.wysocki@intel.com, lpieralisi@kernel.org, robh@kernel.org,
        jeffy.chen@rock-chips.com, krzysztof.kozlowski+dt@linaro.org,
        jonathanh@nvidia.com, dmitry.osipenko@collabora.com,
        viresh.kumar@linaro.org, gregkh@linuxfoundation.org,
        steven.price@arm.com, kw@linux.com, linux-pci@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
        vidyas@nvidia.com
References: <20230208111645.3863534-1-mmaddireddy@nvidia.com>
 <20230208111645.3863534-5-mmaddireddy@nvidia.com> <Y+OJaGY6mcxM0JOF@orome>
From:   Manikanta Maddireddy <mmaddireddy@nvidia.com>
In-Reply-To: <Y+OJaGY6mcxM0JOF@orome>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3N1WUVwMGNjcWcyZVdMUDhxblFxdzZsTUN4VnRGWkdEWEdWVm9weTA4eDND?=
 =?utf-8?B?UEdpcjJFbjZUOWZtKzBrak94QStWdVpOYlE0ajhiSUtrWjBJOHM2RG8wbWhJ?=
 =?utf-8?B?MitiVXJ3K0NVZVRyQXA5dmNtdjlBTDJxTFBVdTFpQVZTZmNZV3J1ckFUVWpT?=
 =?utf-8?B?SEtUWkxETUlHYklHTzdJT1ZuNWVsTlJMYi9YSnI1dE1HZ1Nkc29uRDZ3bkYx?=
 =?utf-8?B?NXpsRHlUd3diK2VDY0tHVEJPeDFOUjArOG43V1dNQlFDN2dSbzNrRy93bG9l?=
 =?utf-8?B?L2pJQVNsYzdhQktGZk1GQk42U2Fwclp0WjJmQ2NldjVWRVFtMHNlY05DT25p?=
 =?utf-8?B?QzFneVFwVEc2NVhydlE1NGdkaExmOVFlb1Izb3RPalFyRXVOUVNoMkY0Nm1h?=
 =?utf-8?B?VWdRcituUEVVakUxY2FKa0V6NUVFcUlDUVo3WCtTWWo2SkphS1F2dTdlVEVl?=
 =?utf-8?B?RHJVZ1BEeHRWUHR5MmUxajlCeU5iYXRGT2srV1R2alFvSTdITWJvYjg5SXNP?=
 =?utf-8?B?MFRFWXg0Y2VPOTNRV0NOaStycVh1allpaVhoOUZTZ3ZXTmEweXZ3MlhiVlNZ?=
 =?utf-8?B?T3NIdEhySktoSjkyUm5HUHBWdW9KZlBiL1M0aCtOWXkrRDEwekxQQXdqNVFm?=
 =?utf-8?B?QmYyM3lRNWFMeHNicHdpN2k5b1dOTmprRVd2T25QZElsd2pydlptcWJlU2gy?=
 =?utf-8?B?dFRMK2grUC9Lckt0MS9MSWRjL3FTaWRFSWpnbFdUeElvL0RpZ2dDeG54ODI0?=
 =?utf-8?B?a2NiV0NTWnFjbkRJdHJibkNnZnlycDFGZkRFOUF4MndEcytmaEFQYlVaclFo?=
 =?utf-8?B?RmVLWGZZczVpM2pyblZmNE84QWVZeWU2S3dHM3RJZDFwZnBwc3RXME5lNllR?=
 =?utf-8?B?RVJRZWJHTGV5TGN0UGVtYXJHZ0lvTVhWbkVXRGZaaTVmTWdUVGh2LzQ3M3Fl?=
 =?utf-8?B?MElpbnZUMHNReGJoWDNtZU5vYkovYWZBbUs5dU5saElHdFBKTWRDRG1MM2Fv?=
 =?utf-8?B?RDRPd2Ria3RyazdpQU9GZFNSSFd1NDNaSVg0a2czQlVwbXZqNS9kY0wxcjRl?=
 =?utf-8?B?MUVMcmpHeDZsUUN1cCtZSFc0SzcrcWNIeVZra1RzYXA0WDBBQUxyZU1Pd0Zr?=
 =?utf-8?B?dWZOM3hoTlBVZVF4a1llZHIyaUsyMUJuUTdWQUUrMlV4L3Z4dUhBS1ZsYTBZ?=
 =?utf-8?B?bEUzU0NlYVUzWFA2am5XQjE2TEUrNjVMS3dmZTkyYVN5TUQxOTMwbjVldWFO?=
 =?utf-8?B?WU1sK3pLbmNuZWo5VWxwaUl2VjJsSTBFeW9kZXlWU0dxN0Uyb3VMak4xL3FX?=
 =?utf-8?B?R214WkhZVVZRbzNSWU9Za1AyeDV4Z1FQMGRsVEFLSHhEWjlqUSt3bjQrbytL?=
 =?utf-8?B?L1BUcWpOUWhYV0hpTmgwb3AyU2doTzJ1NWtUcm1vUm5NVnlhdVI3SXlnZmds?=
 =?utf-8?B?cTVubjUySkFSYy9EVkI1bEsrSlk3QTI5Wkp5WEFZVlVTMG5mQXpSTnNZM1Vp?=
 =?utf-8?B?Z3Evd3hMMTQ1M3ZKZ05vd2ZnTjE0MlBVaVZtTUExVVR5QndGVlRDT1gvNVhn?=
 =?utf-8?B?WVlFR2tYaytMTHZnTWxFeklFVTF2KzNOZzlFYXAyVnZuTVU2ODY2K0QrWUFZ?=
 =?utf-8?B?SUsyV2hObGJ1dUJEQW5Bb3ZtVjM1TkJaUTUxaitMb080ZWREdHJ6bUZFaktL?=
 =?utf-8?B?eDZPcXVtQnpWQlFwWk5Hd1duekI5U29ocG9La0pIREhlUFR6anEzMFNvNkVW?=
 =?utf-8?B?TnYzNkIwVi81QWNOenpDQ3h0QjNTenVoTkFHZjZvZDA0d2dJZzZKaDkrcElY?=
 =?utf-8?B?UG9rVlh3a1ZkaVFxalhaMWpPT0g0cnBKOGd0eWdWZUNzN095d0xPL25UdmZL?=
 =?utf-8?B?SzBTTnVmV1Z6eS9DakRmdG5XUWg4a0lod0FkQlUzY2J4UGpjMnVENnlLNGdW?=
 =?utf-8?B?TGlHVVNwSlNuYktocTQrc0NtNGFRYS8zSXZkMDJOWjU2bGR3dzBXYXBEdVNS?=
 =?utf-8?B?TklYekluSUU5b1hSWDJ2N3VvQURwWlhOcTJFc0R2bllYZWpmcGZJU3cwaVB1?=
 =?utf-8?B?OXQrbkxLK0c4ZDdPZnZPZ21qNzl4Q1MvS3orRWhJSnQveTlidnowZVhJd0pK?=
 =?utf-8?B?NEFNOWFuNkREZDBnODN5NTE3bUVWSnU1cTF5VTlnam9ydzlMWXQvZWRQaHNm?=
 =?utf-8?B?alE9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d11609d4-5319-43db-0e94-08db09cdf0ad
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3356.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 12:13:51.7625
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +CRwJ4WvOeAxbEIzKg9NxNVrI5d8kM3dsk1iE+12Iki6x11Z7ySGSJ0ZViCXu5LiWEjdXFl3nYLc6qPZyHYMig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7298
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/8/2023 5:07 PM, Thierry Reding wrote:
> On Wed, Feb 08, 2023 at 04:46:44PM +0530, Manikanta Maddireddy wrote:
>> Add PCIe port node under the PCIe controller-1 device tree node to support
>> PCIe WAKE# interrupt for WiFi.
>>
>> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
>> ---
>>
>> Changes in v14:
>> New patch in the series to support PCIe WAKE# in NVIDIA Jetson AGX Orin.
>>
>>   .../dts/nvidia/tegra234-p3737-0000+p3701-0000.dts     | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
>> index 8a9747855d6b..9c89be263141 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
>> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
>> @@ -2147,6 +2147,17 @@ pcie@14100000 {
>>   
>>   			phys = <&p2u_hsio_3>;
>>   			phy-names = "p2u-0";
>> +
>> +			pci@0,0 {
>> +				reg = <0x0000 0 0 0 0>;
>> +				#address-cells = <3>;
>> +				#size-cells = <2>;
>> +				ranges;
>> +
>> +				interrupt-parent = <&gpio>;
>> +				interrupts = <TEGRA234_MAIN_GPIO(L, 2) IRQ_TYPE_LEVEL_LOW>;
>> +				interrupt-names = "wakeup";
>> +			};
> Don't we need to wire this to the PMC interrupt controller and the wake
> event corresponding to the L2 GPIO? Otherwise none of the wake logic in
> PMC will get invoked.
>
> Thierry
PCIe wake is gpio based not pmc, only wake support is provided by PMC 
controller.
I verified this patch and able to wake up Tegra from suspend.
Petlozu, correct me if my understanding is wrong.


Manikanta