Message-ID: <da5b6b73-3243-d492-4b82-77411e4676d9@nvidia.com>
Date:   Wed, 8 Feb 2023 17:49:09 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [RFC,v14 3/5] PCI / PM: Add support for the PCIe WAKE# signal for
 OF
Content-Language: en-US
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     bhelgaas@google.com, petlozup@nvidia.com,
        rafael.j.wysocki@intel.com, lpieralisi@kernel.org, robh@kernel.org,
        jeffy.chen@rock-chips.com, krzysztof.kozlowski+dt@linaro.org,
        jonathanh@nvidia.com, dmitry.osipenko@collabora.com,
        viresh.kumar@linaro.org, gregkh@linuxfoundation.org,
        steven.price@arm.com, kw@linux.com, linux-pci@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
        vidyas@nvidia.com
References: <20230208111645.3863534-1-mmaddireddy@nvidia.com>
 <20230208111645.3863534-4-mmaddireddy@nvidia.com> <Y+OMoKOfduwj2PYp@orome>
From:   Manikanta Maddireddy <mmaddireddy@nvidia.com>
In-Reply-To: <Y+OMoKOfduwj2PYp@orome>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3FoVzJ2cmdUZHZ0V2h0MnRmNnpqVzZsdkMwZVVjQ3R1dUhXQlZwbmIxUGZy?=
 =?utf-8?B?cGE4a1JFeFg5WW5ISWlsQ2xDNTh2M3JyYkNNckw3KzdqdTdlOVNOallFdTlN?=
 =?utf-8?B?VDRxTENhUk9ZbGtFMHBBYlMySTdyODNxNDhNdDBCblVQbXo3d3BYTnpvS2oy?=
 =?utf-8?B?ZGZUSVUvK21CSk5keDhuWDZpZVZ6M3dKbktzcXh1clM0QXY1amszbGJvS0VU?=
 =?utf-8?B?alJPUi9PNWV6QjJ2RmdjZmxFUmtId1lDTHJCVXF0ZXNTdkRwdU9kWWUrbW9h?=
 =?utf-8?B?d2t6d0lBN2V5UHNOeExKTnZZejdvcWNZZmVXczYzLy9hYjdXODJFY0hYTG5w?=
 =?utf-8?B?cVY1NDJMQ1lCdnIyOWlIekI1KzhiUEttbUpsQ1BGMTcvaTNac0dEc0UyaTZV?=
 =?utf-8?B?Q244M0RWM1dCYkF0djBEenk5RU5MbTRmMkw0eHNHcWhySWVmbEc5L0EwV2o3?=
 =?utf-8?B?V1pzUjVhczlRNkwrRDJxcHhtWlA3U1RWWGh5T29qY2pTenBXNW1NTWlKZUFX?=
 =?utf-8?B?ZVpwVHpiNzRhcU82aHNIWXNRV1Y1azVUL2tHOVVNSnI2T2ZDZFVuaDdtQ3F1?=
 =?utf-8?B?MXVDZkxvc2NnRGkydiswVTNXMUFhUHpLK0N5NU5Ra0hkMU8vem5MV2J0R3Bi?=
 =?utf-8?B?MUNqN1c1NWR6a0pSV1BjQU5PcGtzTnNhbG0zaGlLTHYxQ1JtV1FqLzdCUCtB?=
 =?utf-8?B?dDcwN1hnOFBuRUc1OEF4ZGxrTS80dkJLLzBjT0JhYW1mTzBtOEM4cHF6VktT?=
 =?utf-8?B?QXFHWDlxc1doUktJTFpoeU9VZ1RCQkZENW9NUWs5cUR3eFlPOTRYb09BUkd2?=
 =?utf-8?B?b01wblErcXV2SW5WQmFSblh5U1MwNnIyYlFXUHZ6Ym9sVUdtcUZtY2x4OER2?=
 =?utf-8?B?SFY5Q1V0UzVya3JnL0l0UitVYzdzMXJRZjNTaHd4Y0UzbElFVDNtK1lWcWJm?=
 =?utf-8?B?a0F0T1FzQ1NvanZZZW14dUFYZHYzWllacEFQUFRvbkxjTTNqeFdzVkRJWUpq?=
 =?utf-8?B?eXBEWEZKOUhFbm1wVkd6SjFSeDd2RVJVZU9TVlREMmEzVWNQZlo5Vk9vMXZE?=
 =?utf-8?B?ZUt4UHIyb280b09nQjdWZ0pjV254Qk9NWjlBcE9pZFlHd28rU1JiVWdCVmJv?=
 =?utf-8?B?Q3Z0VmVtQkRoeTB0Q1UwenNSTlNvclVqbEdKbWVNMG1hT0w3TW9XSlFrcVhy?=
 =?utf-8?B?dVVna0FuSnBDUnZYb2w2QklLRTh1b2hnMjh2eCtQbjJzZXkxcGd4UWM4YVB0?=
 =?utf-8?B?b3U1SW9RS1EvaHc5MnB1R2dNQjZnT2dIcjU1TXc4Z0N5czJoWmN4MldoNHIx?=
 =?utf-8?B?dnhmc0Z0ZjFmRWZLRUl4cFRwcnNNTTNYVU9jSVdnOE9qa0o0VU5Hdm1uQzIw?=
 =?utf-8?B?anlaT1lud2MwbElTVnJyRHRYUjhHNWxSRTNmVDY5bkVFNjRmU2FmQ05ROU4z?=
 =?utf-8?B?cFgwMDd4WmRBZnVOSFduRHhrSW5FK051YUswZlN5SHVzYnZQeERtT2xMU01U?=
 =?utf-8?B?ZGlTK1dWQTdlU3pXMXNCMkwybXRxWXV1Zkd1QzZwNTFuT2VFTlZqYVFsODVP?=
 =?utf-8?B?YjNOOHVlL3ZjenpoWE1hWUZXRFNPREFEU0lxOWJObWQzdllEc1hFZVU3cUp4?=
 =?utf-8?B?eHNLZ1FJZWpZL1JlamxBSmppZFozd0tBNEVBaDY0eEt2N3NjUm1lejI4cWlJ?=
 =?utf-8?B?ZGNZYlJJUGxBMTVKRjRqTFlaaHJYeW1Ub0x2RmpabzR1RFZUaVVreUVUOFRa?=
 =?utf-8?B?Wm1ES3RLY0pLTzZudDVyd005YUhBRXRkTVlqS3UyRU42TkVxajQ3UStwQ3VM?=
 =?utf-8?B?MGpVU29QbHQ2b2pkSmZlN1BxUC9XRjhKdnpxZ1pOcXBqSHBxTnNVWStOY0FZ?=
 =?utf-8?B?WElEbTZqbHBkV2k4MENPejRMSy8vWjFGMTZ5VnRISHRHSzNBUW00UGtYdzl0?=
 =?utf-8?B?MWRJZ0w4M05aNnhyODRENU1iSDAxdSsvY3AzdEMvUWVwRnlINkdCdjBLcTlm?=
 =?utf-8?B?NkRzOUtIRmJHdEM4TXpESTQyWW1vL0JFbWtOdWY0a1ViY1hCcFNkZkMvem9K?=
 =?utf-8?B?T2I0VHc5S1pjWFc4Tzc0Y2c3VWxGbzdzTENkWDZmaVZiQllZRlY0ekhrOUw0?=
 =?utf-8?B?R2x3dy9CYnZzdUNDRVdUNjFiYWxaTS9tRVliakhKN2dmdFRobWUwc2wzdHo3?=
 =?utf-8?B?anc9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14fd1227-b8b9-4029-fc49-08db09ceb79e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3356.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 12:19:25.5213
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VHGMd9chsZsKVv9JDscZGFVPj3J+EwvcaDzbI4jBFZxDGeskaIrZzJAAaRncbpB7UaWuMUoNMCV+4BuQAii2gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5764
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/8/2023 5:20 PM, Thierry Reding wrote:
> On Wed, Feb 08, 2023 at 04:46:43PM +0530, Manikanta Maddireddy wrote:
>> From: Jeffy Chen <jeffy.chen@rock-chips.com>
>>
>> Add of_pci_setup_wake_irq() to parse the PCIe WAKE# interrupt from the
>> device tree and set the wake irq. Add of_pci_teardown_wake_irq() to clear
>> the wake irq.
>>
>> Call of_pci_setup_wake_irq() in pci_device_probe() to setup PCIe WAKE#
>> interrupt during PCIe Endpoint enumeration.
>>
>> Enable or disable PCIe WAKE# interrupt in platform_pci_set_wakeup().
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
>> ---
>>
>> Changes in v14:
>> pci_platform_pm_ops structure is removed in latest kernel, so dropped
>> pci-of driver. Instead, enable wake in platform_pci_set_wakeup().
>>
>> Changes in v13:
>> Fix compiler error reported by kbuild test robot <fengguang.wu@intel.com>
>>
>> Changes in v12:
>> Enable the wake irq in noirq stage to avoid possible irq storm.
>>
>> Changes in v11:
>> Only support 1-per-device PCIe WAKE# pin as suggested.
>>
>> Changes in v10:
>> Use device_set_wakeup_capable() instead of device_set_wakeup_enable(),
>> since dedicated wakeirq will be lost in device_set_wakeup_enable(false).
>>
>> Changes in v9:
>> Fix check error in .cleanup().
>> Move dedicated wakeirq setup to setup() callback and use
>> device_set_wakeup_enable() to enable/disable.
>>
>> Changes in v8:
>> Add pci-of.c and use platform_pm_ops to handle the PCIe WAKE# signal.
>>
>> Changes in v7:
>> Move PCIE_WAKE handling into pci core.
>>
>> Changes in v6:
>> Fix device_init_wake error handling, and add some comments.
>>
>> Changes in v5:
>> Rebase.
>>
>> Changes in v3:
>> Fix error handling.
>>
>> Changes in v2:
>> Use dev_pm_set_dedicated_wake_irq.
>>
>>   drivers/pci/of.c         | 49 ++++++++++++++++++++++++++++++++++++++++
>>   drivers/pci/pci-driver.c | 10 ++++++++
>>   drivers/pci/pci.c        |  7 ++++++
>>   drivers/pci/pci.h        |  8 +++++++
>>   4 files changed, 74 insertions(+)
>>
>> diff --git a/drivers/pci/of.c b/drivers/pci/of.c
>> index ff897c40ed71..1c348e63f175 100644
>> --- a/drivers/pci/of.c
>> +++ b/drivers/pci/of.c
>> @@ -13,6 +13,7 @@
>>   #include <linux/of_irq.h>
>>   #include <linux/of_address.h>
>>   #include <linux/of_pci.h>
>> +#include <linux/pm_wakeirq.h>
>>   #include "pci.h"
>>   
>>   #ifdef CONFIG_PCI
>> @@ -705,3 +706,51 @@ u32 of_pci_get_slot_power_limit(struct device_node *node,
>>   	return slot_power_limit_mw;
>>   }
>>   EXPORT_SYMBOL_GPL(of_pci_get_slot_power_limit);
>> +
>> +int of_pci_setup_wake_irq(struct pci_dev *pdev)
>> +{
>> +	struct pci_dev *ppdev;
> Perhaps "parent" since that's what it is referring to? ppdev is a bit
> vague.
ppdev is already used in of_irq_parse_pci(), I think it mean parent pci_dev.
I see that parent is mostly used for pci_bus parent. Let me know if it 
is fine
to leave it as ppdev or need to rename it.
>
>> +	struct device_node *dn;
>> +	int ret, irq;
>> +
>> +	/* Get the pci_dev of our parent. Hopefully it's a port. */
>> +	ppdev = pdev->bus->self;
>> +	/* Nope, it's a host bridge. */
>> +	if (!ppdev)
>> +		return 0;
>> +
>> +	dn = pci_device_to_OF_node(ppdev);
>> +	if (!dn)
>> +		return 0;
>> +
>> +	irq = of_irq_get_byname(dn, "wakeup");
>> +	if (irq == -EPROBE_DEFER) {
>> +		return irq;
>> +	} else if (irq < 0) {
>> +		/* Ignore other errors, since a missing wakeup is non-fatal. */
>> +		dev_info(&pdev->dev, "cannot get wakeup interrupt: %d\n", irq);
> dev_dbg() maybe? As it is this would add an annoying info message for
> basically every PCI controller on every DT-based board out there.
>
> Thierry
Ack. I will wait for few days for other review this series before 
sending new patch set.

Manikanta