Message-ID: <fdc729fb-2d66-93e0-9544-1a8c8d231b4f@nvidia.com>
Date:   Wed, 8 Feb 2023 17:50:29 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [RFC,v14 2/5] of/irq: Adjust of_pci_irq parsing for multiple
 interrupts
Content-Language: en-US
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     bhelgaas@google.com, petlozup@nvidia.com,
        rafael.j.wysocki@intel.com, lpieralisi@kernel.org, robh@kernel.org,
        jeffy.chen@rock-chips.com, krzysztof.kozlowski+dt@linaro.org,
        jonathanh@nvidia.com, dmitry.osipenko@collabora.com,
        viresh.kumar@linaro.org, gregkh@linuxfoundation.org,
        steven.price@arm.com, kw@linux.com, linux-pci@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
        vidyas@nvidia.com
References: <20230208111645.3863534-1-mmaddireddy@nvidia.com>
 <20230208111645.3863534-3-mmaddireddy@nvidia.com> <Y+OLLMrHqMCrHxLB@orome>
From:   Manikanta Maddireddy <mmaddireddy@nvidia.com>
In-Reply-To: <Y+OLLMrHqMCrHxLB@orome>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qml5Z0MrOWNuQnhXTXJVSXJzTFVkUnM5TFI3L1duNzM0M0k4Tm5uRXE0SWRl?=
 =?utf-8?B?TmlFdlJqVzZla2NYQVBrdnR5c2E0SXRRTFlNTmFtTFZDN0JiZTFuOWJ0R0dD?=
 =?utf-8?B?T3BzaVdyRUlYamhkY1NhRnNJOS93K3VneU1kUWJkQnRQU0d2R2VRYmZOejdO?=
 =?utf-8?B?ZDZjQ2QvVGNjejlJNFA5QnVFeXBRL0pzVzBNWnI1MFZRd0R0TkI0SHhMSE0v?=
 =?utf-8?B?VTgxejRyQkw4YnNPQ1IyNEVFdE5pZlpHZnZZWkdIRzZ5M2NLMzRUcUFrZXJI?=
 =?utf-8?B?SDN4RTZ3bnVMN1RXQ3YrdGVDS3JJTHdySkRydnJJQzZQNzg1U1NPYXFrbjBa?=
 =?utf-8?B?WjcybHFOUFNEVi9CclRTbEhTNVM4S0lBZU9Zc0tHbG1PV21HNGZTOUszRm9W?=
 =?utf-8?B?eDZZZVRpSUxCQk5mKy9PSFBJUnNwSzBBV3lJdlNEV0sydk83bXh0VURXTmF0?=
 =?utf-8?B?Zml3OTZ3anlteVlIdys3cll2ZUhkRkZFTXFnK0MxZ0pqVHlUazlxejdKVUwv?=
 =?utf-8?B?K1lmQmw1dnRicklkWnhQVW5kblNOem5iWjdQTEg2RHFrRGRSeWhXWmVPUXlB?=
 =?utf-8?B?djNucEdGQkROUXNQczI0QkE5MUYxTitCL0VkTzZOM2NCZW16ZXFqbGhVNmYy?=
 =?utf-8?B?MU1pMXlCOXBCTjUvbTVhaDFoTjViR1FyTW9hbDhjQ2NyOXpxVGJ1bWZwQ2lj?=
 =?utf-8?B?UDNTZFF4WEVyaW1hcVlqTStFaXV3NUVhNUdvZzMzakFJcDlFQklDa2IwRktw?=
 =?utf-8?B?YkVNU2tzMWFLZitTUGpHbDFsTWNZK1pWWTJDcGU2MTd3Ykg0OVdjV0ZXdE03?=
 =?utf-8?B?eS85blgxZHhEODVOYTJjYjZsZXFMcHdSa3JCVGpFS1FmVks1L3ZUTzZaZEt2?=
 =?utf-8?B?SWZyWUF5aXVLMS9QaDhpd0Z3WUxWNEpFUDFVY1NtTlBkdzJNYW5lSnYzVnRR?=
 =?utf-8?B?N1VVVUk2eXpNV0Q5THhEbFcvQ052ZzZsSnQ5QnVFdk5SUVFORTF2aXB5TFVB?=
 =?utf-8?B?Z3c3eXQzVWNzZW1yenlXU21xZmYyRWkyKzQ4ZHlIU2JLaFhNNDBGUzIveUw2?=
 =?utf-8?B?ZERVWE5CcWdmU2ZqUTBXWHVCRzE1Q0YrYVVDN0lsR29ZNXNKYTh6OFBXcFdj?=
 =?utf-8?B?b28yTk8wU05KaVVSNUtzWkd3bGJPYkpManFFNXhjR2JaaWZXOVNFTWQ1Lysr?=
 =?utf-8?B?MTRRbHp3V1NvZkhlVnFBUFBCbWVkRkUzemZzOHdwK1BOalh0S0FhZGdGc2FB?=
 =?utf-8?B?dGNuTjZqSGt4ZjVuTG9vaHpaYW54aUZyZFBaUGRKUkNWUjQxSk5MRWNKQlVz?=
 =?utf-8?B?YVBkdXlCZkZLVGpzRVNwN1Z3aUY3TlR5RVhpV0R1b1l5SWcxZFhHS09WdzdI?=
 =?utf-8?B?VnN5Nm0vYWkrd3c4MlIwMHFSRkxVdUJrUFpmQldtUHhIUUdNN2UzUnBuejE4?=
 =?utf-8?B?ZzRwa29ZYUJLVCs1S3U4QVVoNDdpcEdoRktJclEzQW0zQ2NFb21mY3BxOTRZ?=
 =?utf-8?B?dEtCNllMNVZjY01vVHRHSU9SQm9oQm8zdStlemcxOFdQTUtUdGw4OXMzR2Ji?=
 =?utf-8?B?bSttamF2UjA1ZVFrdkdtZmIzbHRCZ1p6ZS96YnhvaWF6dE1uaEx0Y2FXVERk?=
 =?utf-8?B?ejRPZCtQT0N2cWlSN3puWnVXR3k0Uk53bXJpQTI3OFVFQzhhN0ZramtvbXBK?=
 =?utf-8?B?bjk4WWRmTytHaGMxN1ZQUUczaTR0cTFuQldId2swaGZqSkk3WUZwajhod1lo?=
 =?utf-8?B?UW9mejVwaENuc0J1ZTZXWlZwbnM1QkEzemJNblJCZ3k4WENRM242ZEl3dFFl?=
 =?utf-8?B?ZXEvVjJ0RWNiTVFDUHlERlFQTjhTeG9TczE2c1VYN3lPM2JTVHo3eVNTYnN3?=
 =?utf-8?B?ekdHQ3Fzb3pTOFdqd3Q3V1J0Mk9NVGY3N1hJbndINXFXdHR4QUova0V0TGxz?=
 =?utf-8?B?RjlzV1ExcE92ZGZMeWlvMUxralpZbjhFdWk2VStTMmplRnMzT0NkR29raS9S?=
 =?utf-8?B?Qml2ZWVhaTBWSnQ3Z0JFNjYvU09seXhDQzFGVnBKVk1wMjVZajdYRlZtWHNu?=
 =?utf-8?B?cnVXaEVDNEVIbDNCOUlacGcweUJXTDJtM05sUjdrUlh0OGM1RTNhQ1ZIN3px?=
 =?utf-8?B?UGVGWGRuTEFrVUZFTWNXRllPNHQ2YmhJaWFBTEVpTEZxaDdzTFBJMTk0YllL?=
 =?utf-8?B?WHc9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 520a0dda-f60c-446d-b4be-08db09cee7b3
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3356.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 12:20:46.2033
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /9/T0p3fkwCkyVcM8p0ZMhMV49RzurCYJBpxtT2hgVyzGzt3ZW1DN8ZYSCCaadKvXx01tAgQqx42ZvAEnh/p6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5764
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/8/2023 5:14 PM, Thierry Reding wrote:
> On Wed, Feb 08, 2023 at 04:46:42PM +0530, Manikanta Maddireddy wrote:
>> From: Jeffy Chen <jeffy.chen@rock-chips.com>
>>
>> Currently we are considering the first irq as the PCI interrupt pin,
>> but a PCI device may have multiple interrupts(e.g. PCIe WAKE# pin).
>>
>> Only parse the PCI interrupt pin when the irq is unnamed or named as
>> "pci".
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
>> ---
>>
>> Changes in v14:
>> Address Rob's comment on using of_property_match_string().
>>
>> Changes in v13: None
>> Changes in v12: None
>> Changes in v11:
>> Address Brian's comments.
>>
>> Changes in v10: None
>> Changes in v9: None
>> Changes in v8: None
>> Changes in v7: None
>> Changes in v6: None
>> Changes in v5: None
>> Changes in v3: None
>> Changes in v2: None
>>
>>   drivers/pci/of.c | 14 +++++++++++---
>>   1 file changed, 11 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/pci/of.c b/drivers/pci/of.c
>> index 196834ed44fe..ff897c40ed71 100644
>> --- a/drivers/pci/of.c
>> +++ b/drivers/pci/of.c
>> @@ -429,9 +429,17 @@ static int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args *
>>   	 */
>>   	dn = pci_device_to_OF_node(pdev);
>>   	if (dn) {
>> -		rc = of_irq_parse_one(dn, 0, out_irq);
>> -		if (!rc)
>> -			return rc;
>> +		int index = 0;
> No need to initialize to 0 here since you're assigning to it immediately
> below.
>
> Otherwise, looks good, so with that initialization dropped, this is:
>
> Reviewed-by: Thierry Reding <treding@nvidia.com>
Ack, I will take care of it next version.

Manikanta