From:   David Laight <David.Laight@ACULAB.COM>
To:     'Peter Zijlstra' <peterz@infradead.org>,
        "x86@kernel.org" <x86@kernel.org>, Borislav Petkov <bp@alien8.de>
CC:     Masami Hiramatsu <mhiramat@kernel.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Andrew Cooper <Andrew.Cooper3@citrix.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] x86/alternative: Support relocations in alternatives
Thread-Topic: [PATCH] x86/alternative: Support relocations in alternatives
Thread-Index: AQHZOjyzxl+xf7lExkaNEfzZDwBgqa7E+/6A
Date:   Wed, 8 Feb 2023 12:29:38 +0000
Message-ID: <693ce771113d49da92235a0f6d2e395f@AcuMS.aculab.com>
References: <Y+EXQlGSI9WUU8nn@hirez.programming.kicks-ass.net>
In-Reply-To: <Y+EXQlGSI9WUU8nn@hirez.programming.kicks-ass.net>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Peter Zijlstra
> Sent: 06 February 2023 15:06
...
> +#define apply_reloc_n(n_, p_, d_)				\
> +	do {							\
> +		s32 v = *(s##n_ *)(p_);				\

You've added '_' suffixes to the parameters.
But these only refer to the body of the #define
so are never a problem.

OTOH the local 'v' will cause confusion if one of the
actual parameters is 'v'.
Which is why it is common to prefix locals with '_'.
(Which doesn't help with recursive expansions.)

Since this is only actually expended in the one .c file
it is unlikely to cause a problem.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)