From:   "Winkler, Tomas" <tomas.winkler@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     "Usyskin, Alexander" <alexander.usyskin@intel.com>,
        "Lubart, Vitaly" <vitaly.lubart@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [char-misc-next v2 1/2] drm/i915/mtl: Define GSC Proxy component
 interface
Thread-Topic: [char-misc-next v2 1/2] drm/i915/mtl: Define GSC Proxy component
 interface
Thread-Index: AQHZOY1TxR734JuMiEKEBxuHd52pjK7E/ikAgAAB80A=
Date:   Wed, 8 Feb 2023 12:35:11 +0000
Message-ID: <MN2PR11MB4093B2B800D5B151DE2A0336E5D89@MN2PR11MB4093.namprd11.prod.outlook.com>
References: <20230205181132.191064-1-tomas.winkler@intel.com>
 <20230205181132.191064-2-tomas.winkler@intel.com>
 <Y+OVEGNnQXZSxNdG@kroah.com>
In-Reply-To: <Y+OVEGNnQXZSxNdG@kroah.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wRk3Xhc0tbifZ1paMqthEIddbjoZ77Tfstsiv6UYc5VQBPVbUJ41wTeFDrfo?=
 =?us-ascii?Q?XhQ7IbuY3fvf0Vo7Z4NslSQHaHpRfalqX0bq67VJPzBLtFPO/jXH3736L2dY?=
 =?us-ascii?Q?5DO2z+l53jetsheR7jMuV13CCvBA+ohwDxuKZ7GfzZNj91jZLNe0+tiaIKKE?=
 =?us-ascii?Q?iCn+kSP7PQa40YcMEcPC2/KQuzE/77DM5O6YouYaB1ck3SyZwNSPAB7zZww8?=
 =?us-ascii?Q?g/CmI06Z4wszuP9tk3gkjv9P/Ntke0hkpF4RZpqipY6BNU0MuyYk/ITEPBT1?=
 =?us-ascii?Q?jVpXfl2oxiNp80Uk20RrMEWHYgmZCi716OQYtx28JER0UFn5AKe5Nxvi0cZC?=
 =?us-ascii?Q?e1eUM5t+FIdT5VDK6prW/7WK9kMAK8Z6tWkMQ6f44w6njcf6yH79K9wCAtQ2?=
 =?us-ascii?Q?LEM0fjSVnqZOaGcCJpt3CvVIk7yYbpeicEZ0tgysCR9D0K7wp9izv9RU/uRK?=
 =?us-ascii?Q?PG4xvYdk3yxRsCd5fNArkfggEuYaT/r8g7On+Zb7w3mpFey9KGgQbOeK9dYw?=
 =?us-ascii?Q?rJuO3FlAr2X822Au1yPwCW1raNeSDdWTcaHwE7IZE0NbsVPe6ZXZ5/jV8zDg?=
 =?us-ascii?Q?S+xme724K6YvCefNWFo39P8Uw8jRpdB/CzjkUMKLtp9w/RLWvTLL4P4JQ8YK?=
 =?us-ascii?Q?zI+UzeBD0Xr1Hh7pbZTIm3DVibaU0L1/GfdA2hU9iUhnwd9kLzUS/s/iuCib?=
 =?us-ascii?Q?mfDoZ9F9XmWcLTezTKZWVh7dyx8g5QuIWvZJUFysx/MuwQ45i0+y7tJDzZs7?=
 =?us-ascii?Q?51hO1bb8sRvu8JyUdf0yD4C+SmunkefIIAnfnzoQg93AWA6MfaMBC8SiTXAM?=
 =?us-ascii?Q?uKOmhbqUbWl1JXvdq0DVAODQN3v9WCFyh1Zok4aRh2b7mePqv//ZAl8XZD/n?=
 =?us-ascii?Q?rAC1K3zU4+UPA/aK3B08W5eSOFrJiQNZyL5wuUerSAC0s2iKN/Vxv0BObo3Y?=
 =?us-ascii?Q?4catIE67nT4ypJB5iy+4O4lnQqU+DPDQ633qwKS+WCoHn39h2GHhUy+UvOxL?=
 =?us-ascii?Q?iOmDUuPQ8cXPKFcHuUV3ukYwDsZ01LedCmRR4wmL2n6N/2URITWQDWqq5hrm?=
 =?us-ascii?Q?NOEQQh/LfbI2kM7TVbcnhxGSxdcIHRdIHGvvgtKJk2W7K25L2Y/5X3NvpClf?=
 =?us-ascii?Q?UNEtmKf9Vughfdx8iSWRwA5eROp7j41aE0rqcNzgkMkPOYYGEB3tgjiegd3G?=
 =?us-ascii?Q?GkPxzjvtDgzkgfyq+qigOn0yoUcg1n3+zMBpxghxUJnSWcr73/2GwdHAXCrh?=
 =?us-ascii?Q?J16xXTBmfTdY0pz9q8IQklm6bjh1dcNF4+USbVr6eFoZZjxsTY9if7F6QIyu?=
 =?us-ascii?Q?C8/wX4qDl8HCK1n8ruWqzHv78UstoEDFHJ7ZrdWAmWfzVmb11MVtlKXAYAUa?=
 =?us-ascii?Q?rOe5F80XjbBslKB3uHIr3c++ig15Sc1oAOlpWclRxQMIjd+pRiA4xijwUUlf?=
 =?us-ascii?Q?eK3r8d2gSPhsbmttDcpBFE3/AQx2YzaCKTVIWmjIws1XqztZuvXC6gf6Vpl5?=
 =?us-ascii?Q?9qwf6wJkQ6/AFwFj4U5c4z6+86tIzS9SBrxGRgnHepQcMKVbg/jLkiChkYvb?=
 =?us-ascii?Q?7Veh/3X98z5vMFIRXlQiUVoG9118UwksZrhSAsCu1QfpTjX9P+l38IVNRDLZ?=
 =?us-ascii?Q?WA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4093.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a342ed3-1235-407f-e22b-08db09d0ebe5
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2023 12:35:11.8303
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ODT2M7UjMXJJKiMp2ek6BvP7nyQRw5hJ+wO1L0aS47a2cOWC4tZFXejF8cAFpNdpeY4REIMXj4bXm1h3fRPXQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8167
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sun, Feb 05, 2023 at 08:11:31PM +0200, Tomas Winkler wrote:
> > From: Alexander Usyskin <alexander.usyskin@intel.com>
> >
> > GSC Proxy component is used for communication between the Intel
> > graphics driver and MEI driver.
> >
> > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > ---
> > V2: This patch was missing in the first series.
> >
> >  MAINTAINERS                                |  1 +
> >  include/drm/i915_component.h               |  3 +-
> >  include/drm/i915_gsc_proxy_mei_interface.h | 36
> > ++++++++++++++++++++++
> >  3 files changed, 39 insertions(+), 1 deletion(-)  create mode 100644
> > include/drm/i915_gsc_proxy_mei_interface.h
>=20
>=20
> Why do you add .h files in include/drm/ yet only use them in drivers/mei/=
 ?
>=20
> Shouldn't they just live in the mei subdir?  Especially given that you al=
so want
> to maintain them through the mei subsystem as per this change:

Rigth, will drop, this part.=20

>=20
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS index
> > c81bbb771678..2c432b4d8506 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -10570,6 +10570,7 @@ S:	Supported
> >  F:	Documentation/driver-api/mei/*
> >  F:	drivers/misc/mei/
> >  F:	drivers/watchdog/mei_wdt.c
> > +F:	include/drm/i915_gsc_proxy_mei_interface.h
> >  F:	include/linux/mei_aux.h
> >  F:	include/linux/mei_cl_bus.h
> >  F:	include/uapi/linux/mei.h
>=20
> And I would need some i915 maintainer acks before I could take this in my
> tree.

Okay

>=20
> thanks,
>=20
> greg k-h