Date:   Wed, 8 Feb 2023 14:04:10 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
        razor@blackwall.org, roopa@nvidia.com, pabeni@redhat.com,
        bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] net: bridge: clean up one inconsistent indenting
Message-ID: <Y+OdyiQpz7lIBfh3@corigine.com>
References: <20230208005626.56847-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230208005626.56847-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8bL1kISOqAMEpPcZbd/ckGAY1AK77Wf0Q5wK5YKFrhRH6uXF4MIWaSfqBpBm?=
 =?us-ascii?Q?LST5QoPUXGtfaexHMzE5SnGyc9vYD65vTHLHdpn2nJltH3YpdktHPkjdnMO+?=
 =?us-ascii?Q?73qxiikDGpOwik9kzbQ0Keul9PpHD1ulS5nI2Q7SmzV1jE9qh3smS4GhiPPO?=
 =?us-ascii?Q?PpwnJcaUWrmfI46oNImcUN61HKF+e3TyCITgTkuoVyH7XfLON6Rcxh+xv81v?=
 =?us-ascii?Q?LEapPYgAp7pYhcM4zMNJ7NfGsE3rYjO2Iu9IXNesppsnfYTUHYwgIdOoBvQX?=
 =?us-ascii?Q?+4a69MMknhgRZnPkoYO7n6CrxQUe6fXmpzRacdAFKa0dgPNUdXInrfW4imsu?=
 =?us-ascii?Q?PAgBtNxs1owiMa/YaUg5r0KmxMRIEqQe2IBkbsAWpJXE9Vnfvt6Rp0XBT+gy?=
 =?us-ascii?Q?gqdxyzxuVIClF8vu8M/OiP+Vt6LftMGb/pb65XBf3/kJ1e2OzewW6PZSoyym?=
 =?us-ascii?Q?RAG7FakQA/NHdhXE/JMqaH8Lv46OsSRzut5NnSpbpJgKmY7Lxq6brqo2fx33?=
 =?us-ascii?Q?mJvKl/CKwFisb7hARED6kD9RDnw9fn82BSREPHJ+SMjRQnIsdxg9I032mBhw?=
 =?us-ascii?Q?FZ3Q8OIVB8Fet4Q0lUyyBrTFM7JLRZEUsERplwzH9Oo72fVVFPASVhV/tSM0?=
 =?us-ascii?Q?FaMh56eMfeZTlvDH/UuIfi/wUVn0R2RaQ57J6cIsIUmi/0Fgoh/In4FGX2ma?=
 =?us-ascii?Q?+VuaxX7/+tgldOQgn5/FSUSvGJGcEw0HJ+69i4xBF2nxZOL1dLI4tmB76wFD?=
 =?us-ascii?Q?i6BuMgdpme7p9PBK313RlghCRSdaB8WStxvIVXKBBIeB8fau72juOT4EEGwX?=
 =?us-ascii?Q?DcQ91F5+s5IIbKjB5jrxWiOi6jGXKLYWECq5ecshAgo/1XrXPc5fWydh7cRK?=
 =?us-ascii?Q?MxLq6dOgBgVeYEbaUDzzMN+9l5o/pejq+CRxEa2jgmiEDcirJ0kE71QRaKN4?=
 =?us-ascii?Q?MxfOqKcX3PQVvFu9ZZBOQ3ZfgUmKtaQ1VYZw5f72ftswtnO/gWcZEoY9T1lS?=
 =?us-ascii?Q?KnrxO2FSvgO27EjDGw6Nn996qWB9SXUG5PbBU+3GH+jt11yQLqdHXq3NtPCZ?=
 =?us-ascii?Q?KG1VgzfSo7nzA3p/bZ/Nr3ZLY1wUYMvnEnEaWpuQZtbk5nxhEsZEqMxVnpNQ?=
 =?us-ascii?Q?GqffT8Nl3BKToPqaIUsAAL//tT/rDbfguQBj8lxg25p29juRzeZwM6zWjHTC?=
 =?us-ascii?Q?b+8nOImanjmk9r1nGJC0ltOJZ1s2jFuEH02MB1cbQrKicWILOsxFwwFNIhbL?=
 =?us-ascii?Q?BFeVFwhNJEPj8LpjZ8xn5Notr8XI7g3ADoFZxcT1gwHbbwHM76NDNCfrny1c?=
 =?us-ascii?Q?8R/6Ucyq+v+iPUQXum0wMwjzMGO301Nj8rVtCt4qtIqT9IUeV079ujUH7x0t?=
 =?us-ascii?Q?5ZdTP3pBxDmMfR1AlEQV9jOE1DC61wwscme4Sa3NUBRQHZ6AbcINZeVS8ezd?=
 =?us-ascii?Q?1PDHid6f6vOZ36xlMcMndQ3VVLuX4rwO6h3xLUgtjSY00M9Dymg/dbqyUM+e?=
 =?us-ascii?Q?TW/y86q/G7Z9SlFRXl5B5NAASrdx3rSB2H5IIRT1O3RQ4Pf7JJkscDuUqHmG?=
 =?us-ascii?Q?bvQVTTwtu9tpirqkZV7/wcSTbsLjuu3vurR7VIDudnGC1+FxMFwxm8cuZD+H?=
 =?us-ascii?Q?K8uLcgQhylX5Ko1IB+ZacSsvkqmBbWAUqF3TblQau3QVtqDtuPXY9DMLG/Cu?=
 =?us-ascii?Q?9OVuhw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f1b531b-4a0d-4f67-9dfe-08db09d4fb4a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 13:04:15.9100
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4mLuzE/dprq6LKDgNXamXpOMw14UeBuZ6eHPaMq2gZBeYD+PHSwO69n2H08M5WC0EJbMxtEnErS799ZhDFf/fc9z8gC4b4gLR26Tp09f4NM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5699
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 08, 2023 at 08:56:26AM +0800, Yang Li wrote:
> ./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with following code on line 318
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

As you may need to respin this:

Assuming this is targeting net-next, which seems likely to me,
the subject should denote that. Something like this:

[PATCH net-next] net: bridge: clean up one inconsistent indenting

> ---
>  net/bridge/br_netlink_tunnel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bridge/br_netlink_tunnel.c b/net/bridge/br_netlink_tunnel.c
> index 17abf092f7ca..eff949bfdd83 100644
> --- a/net/bridge/br_netlink_tunnel.c
> +++ b/net/bridge/br_netlink_tunnel.c
> @@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct net_bridge *br,
>  
>  			if (curr_change)
>  				*changed = curr_change;
> -			 __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> +			__vlan_tunnel_handle_range(p, &v_start, &v_end, v,
>  						    curr_change);

I think you also need to adjust the line immediately above.

>  		}
>  		if (v_start && v_end)
> -- 
> 2.20.1.7.g153144c
>