From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Marek Szyprowski <m.szyprowski@samsung.com>,
        linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] merge_config.sh: do not report some differencess
 between input and output
Date:   Wed, 08 Feb 2023 14:21:37 +0100
In-Reply-To: <20230208130732.63172-1-l.stelmach@samsung.com>
        (=?utf-8?Q?=22=C5=81ukasz?= Stelmach"'s message of "Wed, 8 Feb 2023 14:07:31
        +0100")
Message-ID: <dleftjy1p8e1i6.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20230208130732.63172-1-l.stelmach@samsung.com>
        <CGME20230208132152eucas1p2247790aae3aa897db4a265f5bc7bf28c@eucas1p2.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2023-02-08 =C5=9Bro 14:07>, when =C5=81ukasz Stelmach wrote:
> If an input config file contains CONFIG_FOO=3Dn the output one
> will contain a line '# CONFIG_FOO is not set'. merge_config.sh
> should not report it as difference because the end result of
> CONFIG_FOO being disabled is achieved.
>
> Inexistence of CONFIG_FOO (because of unment dependencies) in case
> CONFIG_FOO=3Dn is requested, should also be ignored.
>
> Change-Id: I129f3a0b4205a76d8c42020f8adb72b1889d75fb

Do you want me to resend without this one?

> Signed-off-by: =C5=81ukasz Stelmach <l.stelmach@samsung.com>
> ---
> Changes in v2:
> - suppress reports reports if an option was "not set" in input files
>   but is missing from the filnal .config due to unmet dependecies.
> - apply the same logic to suppress some reports during the merging
>   phase
>
> BTW. Do you think adding "| sort -u" after "grep -w" to avoid reports
> about repeated entries may make sense or do you want such reports to
> be printed.
>
>  scripts/kconfig/merge_config.sh | 30 ++++++++++++++++++++----------
>  1 file changed, 20 insertions(+), 10 deletions(-)

[...]


=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAmPjoeEACgkQsK4enJil
gBCNCgf+MSFgL/8/4Gm0KU5JL3ai8lVoyXgxwdROcYJ3Hv8TOAHc9HkNDmKDDvoe
wuLAAWdnU9ULn6GbBd8wtJqbq4SFJ8KRIq/LaAi49DetFAe5RXPoxOEGzn0km/5M
pn+QMAjvCo9kLXrufAtp2hSnMIeMG7DXoO1+hIrckm5dJzA/L59MGPKH56LxZxPf
CeJzS6PFbrGpEZzTAAFJfwXOq2da9+uLQl4qvjr67muwH/bVGkwa5WZW7f1aMEb0
hLhdDMwwDPnztnbkewTrA+tr1iYZlyOwTaeWrY79G52fsztyodBKPO8UhO5Hr31A
mHV4JYS813yTWlErzVJQxaE0gVU3BA==
=Oqs9
-----END PGP SIGNATURE-----
--=-=-=--