Date:   Wed, 8 Feb 2023 14:44:53 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Nikolay Aleksandrov <razor@blackwall.org>
Cc:     Yang Li <yang.lee@linux.alibaba.com>, davem@davemloft.net,
        kuba@kernel.org, edumazet@google.com, roopa@nvidia.com,
        pabeni@redhat.com, bridge@lists.linux-foundation.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] net: bridge: clean up one inconsistent indenting
Message-ID: <Y+OnVfu/3ot3Rk7f@corigine.com>
References: <20230208005626.56847-1-yang.lee@linux.alibaba.com>
 <Y+OdyiQpz7lIBfh3@corigine.com>
 <1a71f6f8-09f6-9208-7368-6b2e3bb4af87@blackwall.org>
 <4e9705d5-c6f7-0b08-6e45-b19bae1d248d@blackwall.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4e9705d5-c6f7-0b08-6e45-b19bae1d248d@blackwall.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXBTeHYyRlBQZXlsU0hYT2Z4SG9MS0w0T2h1enJOQmYyRllRWkJYUlVXSEdj?=
 =?utf-8?B?WWJzbGxMVzJqOTA3NEdTdm1la3RtQzJGY0RHVWxSaGs1VFFzQm1hR3hUYUto?=
 =?utf-8?B?NlhyREtGcmFlaEtpMWcxMHhHR3pxODNUV3ljZUNqNERsc1FaV0ZyTDNKUy9U?=
 =?utf-8?B?VDQ2M005Y05CN21aM21HWGI3bElTMzRuT2lkandVaHZHc2Z3WTI5RVc3L1J0?=
 =?utf-8?B?RksvNXVkRGFEUS84VWhUSitwS3lVYUFpR3dwcWtzSGt4alB2aktBOERkN0c0?=
 =?utf-8?B?UzZVLzZ4K2JaTFJ0ZzFKVHNBSmw3ZXdFZzQ4ZGkyRk9nM1F1Q2Z5RFF4RXdJ?=
 =?utf-8?B?OGJBbWhXTkZKbmsrSmxOdytEOXFZT09JOEhiaTFQU1FKQUFJTStRbjFQUkd5?=
 =?utf-8?B?SFZTd0YrM1prTjRRQzlUWFo3L1ZpdUtheEdsYzluSzhPVW4yMWNCelVRTEth?=
 =?utf-8?B?eG0reW4wd3BBN3ZJTzJIbUxJMGU4UzRaVkE2cDRjcEp5N2lNZStLZWJGWnNZ?=
 =?utf-8?B?dVgxeUhUamVEbU90MHlmVUpNaE1TS2VCcFRiZ0owUkF6eEgra3JKemhSc1pr?=
 =?utf-8?B?QTJtdlpKTEsyMFdxRHNSSUNkL0loMVlKakpNUm1aVkZFNWhTT3V3ckIzRlNY?=
 =?utf-8?B?NjdhRmVuVndIa0cveTdYcnN5WnRXdkZrUFhQUG9HaDh1YVFSMHpBdkZSdlRk?=
 =?utf-8?B?ZytsdkRuSEkxNTdnYlJCZGFxd0h1YzRqQUZqMVFVQWJBbHRvakNRZVdzc0Vm?=
 =?utf-8?B?ZGwrNmtOUzI1aW50ZjVpSW9tdjdkSGhyV3gvMnFSV3pDZ1VWTU82OGFsV2h6?=
 =?utf-8?B?NGxicWo2VXgweVlqbW03azA0YUc3dzlzNGh2NWpGQTBEZUZ0WVV0d0VSZjdt?=
 =?utf-8?B?VFpZSE5vM1dKU2NSMG5pV2xXU2dYZjdQTk1aM0t1YjhxdGtEMjdobTBocTNz?=
 =?utf-8?B?TGtYNHJxVm9yK2x1THJYUjV5dFhrS3JLcWxOSXlzN0FzSFAvVHJnckNxaFlo?=
 =?utf-8?B?SldFb1FhTjJJN3hjVVBPV253WEdpV3c4Z1lMNkdCSDQzOWJZbHJJM3ZqbmQr?=
 =?utf-8?B?M0RzakxXdCtjK1BCZkVUZHlvamNlTzhzOERXNXh4cHB4MjNXRWhmOUFTUlph?=
 =?utf-8?B?U2ZpWlo0NHJaQXRXZzkzRjc2bEk2MlArcUwxZWlhQitjT3RUU2VlMEI0UGRG?=
 =?utf-8?B?MmNYdS8xUlBoU1BERk0vK3hYNkZNMFNudEZ2M0dqclhuRnhVQ2wwRVprTUtD?=
 =?utf-8?B?SHFWS0pZTVM4U1ZaU0FWMFJ3WTFKSEZMNmY0eEp3QjhQR25oVGVjTjNjdEhJ?=
 =?utf-8?B?K2hpclY1c0ZiTjdTLzdreWRNU2J4NStFZVowQ01wcWQyVUVGbkNDQlR5Z2ll?=
 =?utf-8?B?QjgxTmZGc0NZS2hmY0N6dEowdmdwaHRDT2d3SzNxZ1BjY3FkNjJPdGdLRXlS?=
 =?utf-8?B?Qit6ZFR3VEg0bDFiMXJUd29qZUJXNloxKzZLbDl2ZFc1N3hodXEwMFlRemN1?=
 =?utf-8?B?WFk0ZUsydWwyRk0wRlpWbDE5c2o4K0ljSCtkdXIvZ0cveCttaW5KdlQ0bEtR?=
 =?utf-8?B?L2h1WTIybjBycUJxdi9SNjRGOVl2aGhyYk1TOUtZMW9QR0p1bHBQMWhuZm1J?=
 =?utf-8?B?OExoU0xRQk9ldkdtVGJ6NXlmMXpCbFB1cW5EOTJtMml1a1NJcFpmOEplTlAw?=
 =?utf-8?B?UjlOZFcwYTQ0Rk80N01NSUFZWTFOMkEweHcvNXZDTFk4U0JDRVU3eEF3ejY3?=
 =?utf-8?B?TVY0aytOM01pWGtyTEE3R0JEaGRONTZhaFJtTUxYdUwrTEFjbTk1bGt2dEtW?=
 =?utf-8?B?NTlmWG1rNE9XdWFrQ1d6TkQzNC9COWtMdTc0M1dWc3B6clNuYTlWRnVDM3dp?=
 =?utf-8?B?eDlNR1dqTXQwbFU0cEdURFQ5NG1RWDQ0NVpLZTQzWkhweU9HVFFxaWJpSmVp?=
 =?utf-8?B?bzRqeEFSY0wvMmxiWTFKcFVCb0t3QlE5MXFGMlVpYUFGSkN1dFBWVjZaZVRC?=
 =?utf-8?B?eXZwZmdzeExNUlZuQ21YSllwallIRXhTcDB2N1RqTVRFWGt5Uk03V3BocXpo?=
 =?utf-8?B?Q3FaNjFPQVBmZm94ZDlDVjBhRWtnd2RvZHRkb21VMDdxY0Q0R2VoTlJFZlBl?=
 =?utf-8?B?R29yYkZiOFYzSXZGSzlKVlI4Q01Cb05GZHRuK1hIdHhQMnlMTTBYaGlxTnpi?=
 =?utf-8?B?Vm43QXpFazlkQW9DbmhTcmp6eFgzL1B1VG9EUmQvdDJERDRuakdjT2ZLbnJ2?=
 =?utf-8?B?amdRSVNXU1JFMzNzb21rcEVySUdBPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de81a952-84ed-491d-706f-08db09daacb9
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 13:45:00.9973
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l9JptbAYsd4nLTUjH0T2Ntr8ftvRELG6MXYdthb+LZ7jULwlSSOI5pCYTiD/dL0c2vzHughYLKA3WPBOGEXG8cwxMNZBQ7hgmeKeq8VRcWA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5315
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 08, 2023 at 02:31:39PM +0100, Nikolay Aleksandrov wrote:
> On 2/8/23 15:30, Nikolay Aleksandrov wrote:
> > On 2/8/23 15:04, Simon Horman wrote:
> > > On Wed, Feb 08, 2023 at 08:56:26AM +0800, Yang Li wrote:
> > > > ./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with
> > > > following code on line 318
> > > > 
> > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
> > > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > > 
> > > As you may need to respin this:
> > > 
> > > Assuming this is targeting net-next, which seems likely to me,
> > > the subject should denote that. Something like this:
> > > 
> > > [PATCH net-next] net: bridge: clean up one inconsistent indenting
> > > 
> > > > ---
> > > >   net/bridge/br_netlink_tunnel.c | 2 +-
> > > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/net/bridge/br_netlink_tunnel.c
> > > > b/net/bridge/br_netlink_tunnel.c
> > > > index 17abf092f7ca..eff949bfdd83 100644
> > > > --- a/net/bridge/br_netlink_tunnel.c
> > > > +++ b/net/bridge/br_netlink_tunnel.c
> > > > @@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct
> > > > net_bridge *br,
> > > >               if (curr_change)
> > > >                   *changed = curr_change;
> > > > -             __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> > > > +            __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> > > >                               curr_change);
> > > 
> > > I think you also need to adjust the line immediately above.
> > 
> > You meant below, right? :) i.e. "curr_change)", that seems to get
> > misaligned after the change and needs to be adjusted as well.
> > 
> 
> Oh I need coffee, I somehow was thinking about the line being changed
> instead of literally the line above your statement. :))

No problem. We are talking about the same line :)

> Anyway, ack.