Date:   Wed, 8 Feb 2023 16:04:27 +0200 (EET)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     linux-kselftest@vger.kernel.org
cc:     LKML <linux-kernel@vger.kernel.org>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH 3/4] selftests/resctrl: Change name from CBM_MASK_PATH
 to INFO_PATH
In-Reply-To: <20230208094026.22529-4-ilpo.jarvinen@linux.intel.com>
Message-ID: <2078baac-27ea-096-3a13-b88fe10aa78@linux.intel.com>
References: <20230208094026.22529-1-ilpo.jarvinen@linux.intel.com> <20230208094026.22529-4-ilpo.jarvinen@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1222304298-1675858401=:1843"
Content-ID: <fe477438-ca74-4ef3-b1f8-6dd8b61b1fec@linux.intel.com>
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1222304298-1675858401=:1843
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: 8BIT
Content-ID: <82134ad4-63e-60d-eaf4-11a6338ef031@linux.intel.com>

On Wed, 8 Feb 2023, Ilpo J?rvinen wrote:

> From: "Signed-off-by: Fenghua Yu" <fenghua.yu@intel.com>

I seem to have managed to do a little copy paste error there. I can 
resubmit the series if needed.

-- 
 i.

> CBM_MASK_PATH is actually the path to resctrl/info, so change the macro
> name to correctly indicate what it represents.
> 
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> ---
>  tools/testing/selftests/resctrl/resctrl.h   | 2 +-
>  tools/testing/selftests/resctrl/resctrlfs.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
> index f0ded31fb3c7..4f0976f12634 100644
> --- a/tools/testing/selftests/resctrl/resctrl.h
> +++ b/tools/testing/selftests/resctrl/resctrl.h
> @@ -28,7 +28,7 @@
>  #define MB			(1024 * 1024)
>  #define RESCTRL_PATH		"/sys/fs/resctrl"
>  #define PHYS_ID_PATH		"/sys/devices/system/cpu/cpu"
> -#define CBM_MASK_PATH		"/sys/fs/resctrl/info"
> +#define INFO_PATH		"/sys/fs/resctrl/info"
>  #define L3_PATH			"/sys/fs/resctrl/info/L3"
>  #define MB_PATH			"/sys/fs/resctrl/info/MB"
>  #define L3_MON_PATH		"/sys/fs/resctrl/info/L3_MON"
> diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c
> index 6f543e470ad4..cc6cf49e3129 100644
> --- a/tools/testing/selftests/resctrl/resctrlfs.c
> +++ b/tools/testing/selftests/resctrl/resctrlfs.c
> @@ -210,7 +210,7 @@ int get_cbm_mask(char *cache_type, char *cbm_mask)
>  	if (!cbm_mask)
>  		return -1;
>  
> -	sprintf(cbm_mask_path, "%s/%s/cbm_mask", CBM_MASK_PATH, cache_type);
> +	sprintf(cbm_mask_path, "%s/%s/cbm_mask", INFO_PATH, cache_type);
>  
>  	fp = fopen(cbm_mask_path, "r");
>  	if (!fp) {
> 
--8323329-1222304298-1675858401=:1843--