Date:   Wed, 8 Feb 2023 15:00:53 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     shahuang@redhat.com
Cc:     kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
        Shuah Khan <shuah@kernel.org>,
        Andrew Jones <andrew.jones@linux.dev>,
        Marc Zyngier <maz@kernel.org>,
        David Matlack <dmatlack@google.com>,
        Ricardo Koller <ricarkol@google.com>,
        Ben Gardon <bgardon@google.com>,
        Vipin Sharma <vipinsh@google.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: selftests: Remove duplicate macro definition
Message-ID: <Y+O5JW+Ro3i7iXV3@google.com>
References: <20230208071801.68620-1-shahuang@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230208071801.68620-1-shahuang@redhat.com>
Precedence: bulk

On Wed, Feb 08, 2023, shahuang@redhat.com wrote:
> From: Shaoqin Huang <shahuang@redhat.com>
> 
> The KVM_GUEST_PAGE_TABLE_MIN_PADDR macro has been defined in
> include/kvm_util_base.h. So remove the duplicate definition in
> lib/kvm_util.c.
> 
> Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
> ---
>  tools/testing/selftests/kvm/lib/kvm_util.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> index f25b3e9b5a07..3ea24a5f4c43 100644
> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> @@ -1942,9 +1942,6 @@ vm_paddr_t vm_phy_page_alloc(struct kvm_vm *vm, vm_paddr_t paddr_min,
>  	return vm_phy_pages_alloc(vm, 1, paddr_min, memslot);
>  }
>  
> -/* Arbitrary minimum physical address used for virtual translation tables. */
> -#define KVM_GUEST_PAGE_TABLE_MIN_PADDR 0x180000

Huh.  There wasn't even a merge conflict or anything, I just added it twice in
commit cce0c23dd944 ("KVM: selftests: Add wrapper to allocate page table page").

Anyways, applied to kvm-x86 selftests with a Fixes tag.  Thanks!

[1/1] KVM: selftests: Remove duplicate macro definition
      https://github.com/kvm-x86/linux/commit/695fa5a64cf5

--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes