Message-ID: <2b45b511-33d5-c6b0-ad4d-78e8c15392d0@linaro.org>
Date:   Wed, 8 Feb 2023 16:36:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v4 6/6] Driver: VMBus: Add device tree support
Content-Language: en-US
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     kernel test robot <lkp@intel.com>,
        Saurabh Sengar <ssengar@linux.microsoft.com>,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
        decui@microsoft.com, daniel.lezcano@linaro.org, tglx@linutronix.de,
        virtualization@lists.linux-foundation.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hyperv@vger.kernel.org, mikelley@microsoft.com,
        ssengar@microsoft.com, dphadke@linux.microsoft.com,
        llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
References: <1675756199-5917-7-git-send-email-ssengar@linux.microsoft.com>
 <202302081621.odizDzHG-lkp@intel.com>
 <39350ee9-c899-ba88-2e4e-103f93dcd722@linaro.org>
 <Y+O0FtUkLyvJLSrR@dev-arch.thelio-3990X>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <Y+O0FtUkLyvJLSrR@dev-arch.thelio-3990X>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/02/2023 15:39, Nathan Chancellor wrote:
> On Wed, Feb 08, 2023 at 11:25:57AM +0100, Krzysztof Kozlowski wrote:
>> On 08/02/2023 09:22, kernel test robot wrote:
>>> Hi Saurabh,
>>>
>>> Thank you for the patch! Perhaps something to improve:
>>>
>>> [auto build test WARNING on next-20230207]
>>> [cannot apply to robh/for-next tip/timers/core brgl/gpio/for-next wsa/i2c/for-next linus/master v6.2-rc7 v6.2-rc6 v6.2-rc5 v6.2-rc7]
>>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>>> And when submitting patch, we suggest to use '--base' as documented in
>>> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>>>
>>
>> All of your recent patches have build errors. Can you at least build
>> test them before sending? It's a unnecessary noise in our mailboxes to
>> get non-buildable patches, just to trigger compilation which you can
>> easily do by your own. GCC is a free software...
> 
> For what it's worth, GCC does not have a warning like this, it just
> accepts the incorrect location of the attribute, which has gotten others
> in trouble before:
> 
> https://lore.kernel.org/CAHk-=wgf+kHeSZbpkZumWcTXUD7ordqTMvPRNL6aQVG1DSBDnQ@mail.gmail.com/
> 
> So the patch probably did build clean with GCC but that is one of the
> reasons that there is no longer a compiler monopoly for the kernel ;)

OK then the patchset is reasonable/built enough.

Best regards,
Krzysztof