Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88C8CC05027 for ; Wed, 8 Feb 2023 15:42:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231510AbjBHPmn (ORCPT ); Wed, 8 Feb 2023 10:42:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230347AbjBHPml (ORCPT ); Wed, 8 Feb 2023 10:42:41 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBC6F1B313 for ; Wed, 8 Feb 2023 07:42:37 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id fi26so21017751edb.7 for ; Wed, 08 Feb 2023 07:42:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gBpdGA6mtrbnlLXhrldNvYUwXI0WI+DySVv9XI8e+Vk=; b=RyEecQn5YMAw7Ae8YRSta8sKtN6epFcC9vsjG+EygrSU60JiKWNCI5WadCowwvZKc+ f6Y9/prFa9Rfg6/JkjlrR1bn/3htTI3P+IjHKi9b9YMncsOQhDHY4NOAxHaxk/Wa3Hin HSBMJ0EThB4SXjbXitRrTfLruxCAbFpbZ/W8I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gBpdGA6mtrbnlLXhrldNvYUwXI0WI+DySVv9XI8e+Vk=; b=zLPbZAZPNAEY2AtFqtsLAU3SzhFg9AKE/xel6NIZ63/JU+ODWqYsbnSiPZd/cp9a2g ofph0+7tZfrWb/TK2AykQXTWhMls2LVC43N3ZI+lc72yEGaH99OqZw1kVpJGePcZdwSn TnknsvBwmViU4HT4VMk9oFQKDrEnv5UUXg30Oxb0gfHMWlfwV51Vo89srpPNFEb2fyrH Z9+U+Y/BxGGhj4ud19XQNXCq+3AQSFt7oyVhoQ5rA62iqogl5ZoaY+EvBfljhzaiU3Np dlQFuU9El6pjM4EdZrRVMvU/86WpvvPzM9NODSgCdBHFQgRybsBQJW5ap+DTu3P8tsm9 x+FQ== X-Gm-Message-State: AO0yUKUzK2GPtGVqJfPyiwwb1R9cokGB6U8/hNCZxRQSZDrbxE6sCLKC wZDz02RAhEgZvylIaoPPz9ccYAuitdl3OF5YSglGlg== X-Google-Smtp-Source: AK7set+XI3UwwolKkrkk3BfkfAuRtmrLdVlxbEWLjTTh/i8yr2lHDs4Yk5A7YXvCv+sTfj8JVASRfw== X-Received: by 2002:a50:ccc6:0:b0:4aa:c4bb:2372 with SMTP id b6-20020a50ccc6000000b004aac4bb2372mr8430746edj.32.1675870955942; Wed, 08 Feb 2023 07:42:35 -0800 (PST) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com. [209.85.218.53]) by smtp.gmail.com with ESMTPSA id es26-20020a056402381a00b00488117821ffsm8031006edb.31.2023.02.08.07.42.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 07:42:31 -0800 (PST) Received: by mail-ej1-f53.google.com with SMTP id hx15so52079324ejc.11 for ; Wed, 08 Feb 2023 07:42:30 -0800 (PST) X-Received: by 2002:a17:906:4e46:b0:87a:7098:ca09 with SMTP id g6-20020a1709064e4600b0087a7098ca09mr1655453ejw.78.1675870950517; Wed, 08 Feb 2023 07:42:30 -0800 (PST) MIME-Version: 1.0 References: <20230207072902.5528-1-jgross@suse.com> <20230207072902.5528-5-jgross@suse.com> <59a24334-35c7-8afa-f35d-d654dd2823ba@suse.com> In-Reply-To: <59a24334-35c7-8afa-f35d-d654dd2823ba@suse.com> From: Linus Torvalds Date: Wed, 8 Feb 2023 07:42:13 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/6] x86/mtrr: don't let mtrr_type_lookup() return MTRR_TYPE_INVALID To: Juergen Gross Cc: linux-kernel@vger.kernel.org, x86@kernel.org, lists@nerdbynature.de, mikelley@microsoft.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 7, 2023 at 10:20 PM Juergen Gross wrote: > > Are you sure? In the SDM I'm reading: > > * E (MTRRs enabled) flag, bit 11 =E2=80=94 MTRRs are enabled when set; al= l MTRRs are > disabled when clear, and the UC memory type is applied to all of physi= cal > memory. > > So UC it should be IMHO. Right you are. I clearly misread that section when I did my original patch. Linus