Date:   Wed, 8 Feb 2023 17:05:05 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Mikko Perttunen <cyndis@kapsi.fi>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Srikar Srimath Tirumala <srikars@nvidia.com>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        Timo Alho <talho@nvidia.com>, linux-pm@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] thermal: tegra-bpmp: Handle offline zones
Message-ID: <Y+PIMc8PepsIPXN7@orome>
References: <20230207135610.3100865-1-cyndis@kapsi.fi>
 <Y+N5+w8ePTVaZiIB@orome>
 <706b3e2d-7097-356b-b96e-dd917ce048ea@kapsi.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="3g8zk/YJd0AOEqHX"
Content-Disposition: inline
In-Reply-To: <706b3e2d-7097-356b-b96e-dd917ce048ea@kapsi.fi>
User-Agent: Mutt/2.2.9 (2022-11-12)
Precedence: bulk


--3g8zk/YJd0AOEqHX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 08, 2023 at 05:35:48PM +0200, Mikko Perttunen wrote:
> On 2/8/23 12:31, Thierry Reding wrote:
> > On Tue, Feb 07, 2023 at 03:56:08PM +0200, Mikko Perttunen wrote:
> > > From: Mikko Perttunen <mperttunen@nvidia.com>
> > >=20
> > > Thermal zones located in power domains may not be accessible when
> > > the domain is powergated. In this situation, reading the temperature
> > > will return -BPMP_EFAULT and the temperature is considered to be
> > > -256C for calculating trips.
> >=20
> > Where's that -256C being set? I only see THERMAL_TEMP_INVALID being set
> > as the default for a zone, but that's not -274C, not -256C. If that's
> > the temperature that you're referring to, it might be better to state
> > that we rely on the default temperature rather than any specific number.
> >=20
> > Thierry
>=20
> It is based on BPMP's internal behavior.

Okay, maybe clarify that part of the sentence then. Could be something
like:

	... will return -BPMP_EFAULT. When evaluating trips, BPMP will
	internally use -256C as the temperature for offline zones.

Thierry

--3g8zk/YJd0AOEqHX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmPjyDEACgkQ3SOs138+
s6H5JA//TdfEDY64BG0y7A7/GvZveH2DOXG064mmwvhMJtAZ7Vp0v5ldgbi1lWOE
TiKuNwOVj5QEqgmNo3cN/+E4rYSg74mB1pl4IPrcdUSPgaHo/uLOmi2VnJscUPac
MKcBGWDw+AWkCCvOPZYfeakK5xKdgfH0Rtami3EP2PvzSEnulGMERlLr27C5s/rT
yNgfbNf3WdHEUYY5wfhUq9SGd2VNphr+fCtSEyR1GoBvIJz/1KIBsSwbVFFLlvSq
ecPnR60yhlZs9cSgb0h0L4xfkj6d225YkZU9AghDKyiYmNpzpwMXpDJDekrDIaNp
yNOZYOBpU5niMfJ/p/EyebHN89DSEtrsewy3ecDEY8xbcNA5IyMcn6rjQyccvnv/
Y7Awd98eg5ZPXwqSQTtso3oJPPbPVwsmjgCEsvJ2g/1ZgKZfJZ4aI7zNuky0vDFR
X1wItyZ8TcM06DjBOuHl4XiAdb2h2oNIIuXe2fEcxGHmipvb/6lbrcXMZO9km5sH
PP0uI3GZ0LHYexYsrpcXXhOicCWY+ld1EWVX29iHZC8T4XojzMNba2sDI7bPCSA7
i53aIN7o6pd2zKuoxrVlSRQO76ORuuX/RiV6OxAVTUBplZRdO+nhXxnUox80Zqfb
Mmc9P7aQSj2x+LHuRGasYr3l5EmvMKX07uJMbTRCMmVQy5YhttY=
=9WHK
-----END PGP SIGNATURE-----

--3g8zk/YJd0AOEqHX--