Message-ID: <b95505ab-8206-2a00-e199-e3defecd9d72@suse.cz>
Date:   Wed, 8 Feb 2023 17:07:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] mm/page_alloc: reduce fallbacks to (MIGRATE_PCPTYPES - 1)
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>,
        Yajun Deng <yajun.deng@linux.dev>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Zi Yan <ziy@nvidia.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        David Hildenbrand <david@redhat.com>,
        Mike Rapoport <rppt@linux.ibm.com>,
        Oscar Salvador <osalvador@suse.de>
References: <20230203100132.1627787-1-yajun.deng@linux.dev>
 <20230203142324.e5c0652990676ac69a4e5eb1@linux-foundation.org>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <20230203142324.e5c0652990676ac69a4e5eb1@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/3/23 23:23, Andrew Morton wrote:
> On Fri,  3 Feb 2023 18:01:32 +0800 Yajun Deng <yajun.deng@linux.dev> wrote:
> 
>> The commit 1dd214b8f21c ("mm: page_alloc: avoid merging non-fallbackable
>> pageblocks with others") has removed MIGRATE_CMA and MIGRATE_ISOLATE from
>> fallbacks list. so there is no need to add an element at the end of every
>> type.
>> 
>> Reduce fallbacks to (MIGRATE_PCPTYPES - 1).


Acked-by: Vlastimil Babka <vbabka@suse.cz>

> Thanks.  `git log' suggests who should be cc'ed when fixing things...
> 
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -2603,10 +2603,10 @@ struct page *__rmqueue_smallest(struct zone *zone, unsigned int order,
>>   *
>>   * The other migratetypes do not have fallbacks.
>>   */
>> -static int fallbacks[MIGRATE_TYPES][3] = {
>> -	[MIGRATE_UNMOVABLE]   = { MIGRATE_RECLAIMABLE, MIGRATE_MOVABLE,   MIGRATE_TYPES },
>> -	[MIGRATE_MOVABLE]     = { MIGRATE_RECLAIMABLE, MIGRATE_UNMOVABLE, MIGRATE_TYPES },
>> -	[MIGRATE_RECLAIMABLE] = { MIGRATE_UNMOVABLE,   MIGRATE_MOVABLE,   MIGRATE_TYPES },
>> +static int fallbacks[MIGRATE_TYPES][MIGRATE_PCPTYPES - 1] = {

Why not also reduce the first index size from [MIGRATE_TYPES] to
[MIGRATE_PCPTYPES] ?

>> +	[MIGRATE_UNMOVABLE]   = { MIGRATE_RECLAIMABLE, MIGRATE_MOVABLE   },
>> +	[MIGRATE_MOVABLE]     = { MIGRATE_RECLAIMABLE, MIGRATE_UNMOVABLE },
>> +	[MIGRATE_RECLAIMABLE] = { MIGRATE_UNMOVABLE,   MIGRATE_MOVABLE   },
>>  };
>>  
>>  #ifdef CONFIG_CMA
>> @@ -2865,11 +2865,8 @@ int find_suitable_fallback(struct free_area *area, unsigned int order,
>>  		return -1;
>>  
>>  	*can_steal = false;
>> -	for (i = 0;; i++) {
>> +	for (i = 0; i < MIGRATE_PCPTYPES - 1 ; i++) {
>>  		fallback_mt = fallbacks[migratetype][i];
>> -		if (fallback_mt == MIGRATE_TYPES)
>> -			break;
>> -
>>  		if (free_area_empty(area, fallback_mt))
>>  			continue;
>>  
>> -- 
>> 2.25.1