Date:   Wed, 8 Feb 2023 17:41:59 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
CC:     <netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Alexei Starovoitov <ast@kernel.org>,
        "Daniel Borkmann" <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        <bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH net-next 00/11] NXP ENETC AF_XDP zero-copy sockets
Message-ID: <Y+PQ1+j0l/h/6dx+@boxer>
References: <20230206100837.451300-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230206100837.451300-1-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8AXwB3wNBzbPMKGeUdVY35LGWumbXPWN707cny/meBmmfOYVJMZIwozoAqW8?=
 =?us-ascii?Q?zXUIWEi/XVEzDwP5ntOr9V4nWxEdeLURm4Qhvpe6ArD7e7h/raLhbHxwtmJf?=
 =?us-ascii?Q?Ir7uvHpsWJUNOTe3fbz/mLvscoRZc7s/tkJRtjFHLK1LQw2HyPNiNmWVm0Zr?=
 =?us-ascii?Q?y0toJT6R9ZUL93RHyGLD2Vd/hWCqO2HxlX/8fcmrYYnAZleuHncVBkAYYZpc?=
 =?us-ascii?Q?O8TUsFID7wpbZIJPkck/i1WIxuR+Swu0NPoudPAzoVcaoMQ+VkZlNuqp83mx?=
 =?us-ascii?Q?HslOH6yB/WgwaQZ9SlSSW11dQxE4gtIULfJVq+ug0fJKWqe34dwMrqA/Cext?=
 =?us-ascii?Q?BePD1HHeIVF7+2VM2m2Khjw6J5s7s3ZnLd2MvgKHZ9wQDBDFaGn3Z/Xb9dF4?=
 =?us-ascii?Q?/wuHzwx2KWQbIKEKnWKEYBtlhKR/O8+fnTcnd1ZScGDvItvkHtXv4lH7jEKl?=
 =?us-ascii?Q?sm/iIJLokfvjYwVcnFzrkMmemGwVzIhUaSJwjhOZmNrgcSmUAmQopP0l4Bkl?=
 =?us-ascii?Q?B6yA/BTw+FBaQeW6IGVg7uIsHP6pkZ6bxlMoioZdBwqsHXcrXma1331VIk3y?=
 =?us-ascii?Q?5/UfQSSn2QVP2iy+RUR2fHrszpwvTaMXArHMZakM+KXKI5bp29ZO+E9YGukY?=
 =?us-ascii?Q?d+MFs36WHWqKMXPTNUp3RRuwzHfGhg3uLZMY5n/LUjpBsXX0OjWYgP56n3/W?=
 =?us-ascii?Q?1VL8JcGwnNdaimVztdiOClnd6cgzyOd19pATGUFHjfcsVkaT2lAyZcZN1kvb?=
 =?us-ascii?Q?kyGLnNUj9xorwrzWasicbVWdD/j7NUKcJdzCdPi8JL4dl3nDU3kmXIVfQofk?=
 =?us-ascii?Q?+qgDusbQndiOrbxXIBPCg4kWrR8/XxTnvERzkEMTknvO0I2FrS8eRVfMfJqe?=
 =?us-ascii?Q?ZSIu3kGpX0n27YrI3MkJ9oGXemsa1JQvaSylihC0aDFINB8DgFqI3/LECmVA?=
 =?us-ascii?Q?3sHntsxcymw8K4ZmsCM2BoMi1sgQTEI4NW6OzRCRGFlKzxuEYosmB9sDButP?=
 =?us-ascii?Q?GZZ/dE9kDL3tRNdHnp69wkEk0jsUJB7YEKOIrfFeddRdlz08al9a3PPeL8HQ?=
 =?us-ascii?Q?bv6ikNXc7KB0Zd9NopWwCHSAQA9S2qw+oc3V8P48HbvvkKbr2g2f6z3l3swV?=
 =?us-ascii?Q?lnhEQUDEJEBVnmDCd9dZR5raQJy3//YwSOotnq6+Rbq/cSNv9896SX5feCP3?=
 =?us-ascii?Q?5k1gt0ZqdWbVtMk/gv2X/nFGj3zs/CyhEEPuF57TvlufrSEzZtgg5O798Kr6?=
 =?us-ascii?Q?OarD6Umw8dwnz5Scx1x1n5Z5XFhb7pVq2fEw0k+YbYnbxT9XJVa4Ks2JSQT0?=
 =?us-ascii?Q?WRHxKLLiY+qxlrSkj1J1noI+HsxJDZwqfMUQGPOoGSYneZ5q2ZSl3rs9Vkf1?=
 =?us-ascii?Q?15iXikut5ndE3VQ/cRnrneR/m7hrCecGoDyiDCtd7pVGVs1N/gjI8eH5vj38?=
 =?us-ascii?Q?NWvwVhcHscC0UzYowTUzLLxBrG4X/kHvTyBaMD2SdEd+A4NUfWo9MT/+tvAy?=
 =?us-ascii?Q?zyNFJqjVemHi1J3QBo/kxm6ntPPXAW2CgyTvMK4yCN9vEtgITep9QUm706Qb?=
 =?us-ascii?Q?VVpYTN+kfBtUeYYSUAQO7Wmy20egP2QzANvWn9ejhITFg918U07VndaRXZL3?=
 =?us-ascii?Q?c/BCbM6ZQnu320Nw/N5vE5o=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a844ae6e-79a6-4416-a229-08db09f36a67
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 16:42:07.1498
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8O+l6ZvFanwv02YvhEgsrHQnq3+CGHyano7Oa7lqQylWVgC6Dx3Fi1cSHmWko0CQUT3BXt1+wLQbAkhaKpckh1vFJbeZdfL74Ye9hpueLbI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6737
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 06, 2023 at 12:08:26PM +0200, Vladimir Oltean wrote:
> This is RFC because I have a few things I'm not 100% certain about.
> I've tested this with the xdpsock test application, I don't have very
> detailed knowledge about the internals of AF_XDP sockets.
> 
> Patches where I'd appreciate if people took a look are 02/11, 05/11,
> 10/11 and 11/11.

All of that looks rather sane to me. Can you point out explicitly your
issues here? Is it around concurrent access to XDP Tx rings or something
more?

I commented on 10 and 11. For 2 it seems fine and 5 has always been
controversial.

> 
> Vladimir Oltean (11):
>   net: enetc: optimize struct enetc_rx_swbd layout
>   net: enetc: perform XDP RX queue registration at enetc_setup_bpf()
>     time
>   net: enetc: rename "cleaned_cnt" to "buffs_missing"
>   net: enetc: continue NAPI processing on frames with RX errors
>   net: enetc: add support for ethtool --show-channels
>   net: enetc: consolidate rx_swbd freeing
>   net: enetc: rename enetc_free_tx_frame() to enetc_free_tx_swbd()
>   net: enetc: increment rx_byte_cnt for XDP data path
>   net: enetc: move setting of ENETC_TXBD_FLAGS_F flag to
>     enetc_xdp_map_tx_buff()
>   net: enetc: add RX support for zero-copy XDP sockets
>   net: enetc: add TX support for zero-copy XDP sockets
> 
>  drivers/net/ethernet/freescale/enetc/enetc.c  | 676 +++++++++++++++---
>  drivers/net/ethernet/freescale/enetc/enetc.h  |   9 +-
>  .../ethernet/freescale/enetc/enetc_ethtool.c  |  10 +
>  .../net/ethernet/freescale/enetc/enetc_pf.c   |   1 +
>  4 files changed, 606 insertions(+), 90 deletions(-)
> 
> -- 
> 2.34.1
>