Date:   Wed, 8 Feb 2023 19:08:15 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next 11/11] net: enetc: add TX support for
 zero-copy XDP sockets
Message-ID: <20230208170815.nsq77mpkpf7aamhg@skbuf>
References: <20230206100837.451300-1-vladimir.oltean@nxp.com>
 <20230206100837.451300-12-vladimir.oltean@nxp.com>
 <Y+PPzz4AHRxZgs9r@boxer>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+PPzz4AHRxZgs9r@boxer>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FWKYLlaY1n23XDliVEiJSNSv9eLX6yZeZRW9RfM0MLwZdFQQRsL1D+6qFYQB?=
 =?us-ascii?Q?3UcbV/p3OxHCgzN+0Ms64oPhIkYJFeexMelWpLnfpCH/xHaSJlyZO8hxFnyL?=
 =?us-ascii?Q?53a3V4oOB42Ai2M8+2KoM+52mISiCeRzxRkBws4s0tgT1wnFy13Xq60CVwzK?=
 =?us-ascii?Q?0fyK7/KiQ8LwTaa6IJKacAMP3S4ItW+nDXakie7e5UxbA+QpdnXOPXS+Dr+v?=
 =?us-ascii?Q?ahdLP+XKLIxJG9lGVRpsny9CGJpDeBeHXtP0UvjvnZiXq5MeHdChVPy7ZVzf?=
 =?us-ascii?Q?xYyYhJHSauQVxvIvV5021BlDMSY7RUzFUHnAIH53ljvYt6u3oSNdC5sF2my6?=
 =?us-ascii?Q?HYN2PWFoagay7heZAaCWc2Wi6jkOw9q/rJ9/Z+Z4Wk6KGsnyzUh4eT+gP0BQ?=
 =?us-ascii?Q?dDCzAwuT/jJcDsjgprLqS9baFie8k/PCDCX5DVPMHWcyHhojP3UOBgnG1QwM?=
 =?us-ascii?Q?RnPRU6Sg5OUwHxoJMo4ttDHQjTZpO3tExicMR/CoFDHf4nCMvYkBKDghVYLa?=
 =?us-ascii?Q?ghCU81UplCHjKyWymRLbNlYVxSO1md6PLzAAEpqGUEEPpkSUqOB0N/V//oUK?=
 =?us-ascii?Q?tTOizZZeOhUcVOd4zYSC1NsrHyd3aRYFZHdru81ZJFMjGuQi9aoGlyF+d+Li?=
 =?us-ascii?Q?6Q3u1ilrGdvsG7k/+XMw8zZ04QmVyiH3kr6QUR3DLEJZ847SnjhM5CFCG2GA?=
 =?us-ascii?Q?iBi3sLoTDiYTPNP5NKDRBXktQ5fONmnNq9JUiWhUf1XsdmDWCbseYyPd1Y1h?=
 =?us-ascii?Q?4raoSc1gZ2IkY97whssKYIJYMb19E4OW/Hq4kF1eGlobF73OI75M1DclRlt3?=
 =?us-ascii?Q?WG8Dou5Y3DZayRLjLoZhjdUB4dzkfc2Eu0TJy+HWnRLDzJNZSYzHCxoHKRMR?=
 =?us-ascii?Q?+l6xM+nPDVG+xCti6uE4vjFX9bwxEIcJaww5oEAQL644+Qq6YXn2u0aMnuKw?=
 =?us-ascii?Q?fYXDR7KRZoWs8so7GhvGTFmVhKQIPjgR78IynSW4+Io2W4FHpzrVS5fnxPbL?=
 =?us-ascii?Q?jjpYWEadrOrpE8xBv0ZgQjThQkdXp6Idm2EM+Am02q0O7lsfY8gWrSIvM96Z?=
 =?us-ascii?Q?Sz32Jga+cJldsdBxT6ycoSYy9DYsVegc6VPy7AJjffGoVwxUb7Zov2TRg38k?=
 =?us-ascii?Q?j54Q900/5nbw3/wL8EkxJa0WUNN18g7uDb/DuHaJo8pwJxWAO80kYYV9rwq9?=
 =?us-ascii?Q?G7ceG9hMHSruKiUUUjA1SoRTq3ELUjyT/dNZZcS7ZZm+jBbnXV+5LKpbBwrh?=
 =?us-ascii?Q?xyEgCmgfIpwnn5BQ7gtOo1WSTq+ScWFRn2/20jWRTtM3yO1KjpnJVaPTKNO+?=
 =?us-ascii?Q?4CA37KRKX6Dm/25B1DvqW2GSXJROwX5pBmNjmf6qmaaPBCCJcDJx3Dx3sMj9?=
 =?us-ascii?Q?75vg8i6nPOHZ2F5qqFkvmY8zJWuLOX1XuQeUZidwvYOh5LipDm0a9n3+4vvi?=
 =?us-ascii?Q?f3YIw8aV9/3xp/CaQt62/lMynXcyIolyhRXkN+u+SEvXwmeDmVmnLE+einJa?=
 =?us-ascii?Q?uueubliZ446q3UPrGpdMpaTdNMNBcHbY8owSTGkxgIJWggnUSTk4ktIary+X?=
 =?us-ascii?Q?MORULMtTISOhzLFkyoEfQmdK3ttmW4d/sta+yMAfWTpgq9XXimhmFoXzXS+i?=
 =?us-ascii?Q?2g=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47edca94-5ae5-430d-b729-08db09f713e9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 17:08:20.1056
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dreyLdhTxd6qQV/mIZ9LSrUTdkjJc5lS+fVLZLwGGLFau0TtQCM4KjmVw/UFVzigKpziTaetLHRhU1Mb73tqMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7313
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Maciej,

On Wed, Feb 08, 2023 at 05:37:35PM +0100, Maciej Fijalkowski wrote:
> On Mon, Feb 06, 2023 at 12:08:37PM +0200, Vladimir Oltean wrote:
> 
> Hey Vladimir,
> 
> > Schedule NAPI by hand from enetc_xsk_wakeup(), and send frames from the
> > XSK TX queue from NAPI context. Add them to the completion queue from
> > the enetc_clean_tx_ring() procedure which is common for all kinds of
> > traffic.
> > 
> > We reuse one of the TX rings for XDP (XDP_TX/XDP_REDIRECT) for XSK as
> > well. They are already cropped from the TX rings that the network stack
> > can use when XDP is enabled (with or without AF_XDP).
> > 
> > As for XDP_REDIRECT calling enetc's ndo_xdp_xmit, I'm not sure if that
> > can run simultaneously with enetc_poll() (on different CPUs, but towards
> > the same TXQ). I guess it probably can, but idk what to do about it.
> > The problem is that enetc_xdp_xmit() sends to
> > priv->xdp_tx_ring[smp_processor_id()], while enetc_xsk_xmit() and XDP_TX
> > send to priv->xdp_tx_ring[NAPI instance]. So when the NAPI instance runs
> 
> Why not use cpu id on the latter then?

Hmm, because I want the sendto() syscall to trigger wakeup of the NAPI
that sends traffic to the proper queue_id, rather than to the queue_id
affine to the CPU that the sendto() syscall was made?