Date:   Wed, 8 Feb 2023 18:23:11 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     jassisinghbrar@gmail.com
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        error27@gmail.com, stern@rowland.harvard.edu,
        Jassi Brar <jaswinder.singh@linaro.org>
Subject: Re: [PATCH] usb: gadget: udc: max3420_udc: fix serialized access
Message-ID: <Y+PafyViJMb6OOAn@kroah.com>
References: <20230208163418.342210-1-jassisinghbrar@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230208163418.342210-1-jassisinghbrar@gmail.com>
Precedence: bulk

On Wed, Feb 08, 2023 at 10:34:18AM -0600, jassisinghbrar@gmail.com wrote:
> From: Jassi Brar <jaswinder.singh@linaro.org>
> 
>  The mutex 'spi_bus_mutex' should be used, instead of the spin-lock,
> while changing the state of the kernel-thread.

You forgot to say why this is the case.

> Also changing the
> usb-gadget state need not be protected by a spin-lock.

Why not?  Why isn't this a separate change?

>  This should fix the Smatch static checker warning
>     warn: sleeping in atomic context
> 
> Fixes: 48ba02b2e2b1 ("usb: gadget: add udc driver for max3420")
> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
> ---
>  drivers/usb/gadget/udc/max3420_udc.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

You forgot a "Reported-by:" line, right?

And odd indentation in your changelog text.


thanks,

greg k-h