Message-ID: <79d47a18-90dd-9fc2-aa0e-ca5627b7ca6d@intel.com>
Date:   Wed, 8 Feb 2023 11:28:26 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.4.2
Subject: Re: [PATCH] fpga: m10bmc-sec: Fix rsu_send_data() to return
 FW_UPLOAD_ERR_HW_ERROR
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        "Moritz Fischer" <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
        Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
        Lee Jones <lee@kernel.org>,
        Tianfei zhang <tianfei.zhang@intel.com>,
        <linux-fpga@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230208080846.10795-1-ilpo.jarvinen@linux.intel.com>
From:   Russ Weight <russell.h.weight@intel.com>
In-Reply-To: <20230208080846.10795-1-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTFlTXhqdEtUZ3FvRFV2WStjL2dsNmVzSnJBSFlMam9OL0V5K2txc1JQc2x4?=
 =?utf-8?B?M3AvdWVHU2tCSkRaSWtReDlGNWk1Q1ZGd0N4dkkxVDAxVlBUWkwzM3FLZHlo?=
 =?utf-8?B?WnJqSDNaSkFxRzZ3N09UWlRIWDliSStzb1Y4d3JOdnZhbW9KMHpKaFJKcDRY?=
 =?utf-8?B?WUEwV2NvQmt2WHFUNHVXT2hQdmxWbGE2YVVMUmhqb0VYSDlKcEFpZzcxeEsx?=
 =?utf-8?B?SjNPaEVObHRIS0QwZFE3aEdKVnBUalRQbHRxeXJ4dzF0MjdqMUtLMFpkU0dv?=
 =?utf-8?B?alRjbG5jQTlsVzUxREltU2VtTmdJb0VKcE4zTmwxVnUxYWRxamFIT3lNZjJl?=
 =?utf-8?B?T0xaZnhBUEJyVE4rT2pkQmxyc2MzKzRFY2F4TlpTT093TnUvUEo0WHcxNUZC?=
 =?utf-8?B?Q2o1VGtQKzc5NUk3RGUyU0l5cm0rd25ZY1dmOGNFc2dNYVVzTXU5c0lhajdm?=
 =?utf-8?B?akpmSlpTRXlSVVdSU2JXR0pwV1NtSFlnZ1hSUzV5YkpXSzBkS2d5eXl1Y1Jw?=
 =?utf-8?B?elpzTEdzbFprdzlSN21zaXJ1azBsRVhtTURHNWZPbWRHdWdMcFZ6Y2xJeUww?=
 =?utf-8?B?bTRlZlM5NjdCS0h2NG5pUWJmcHl4RmlxeUpmUXJyVTdSVkhMQ2FoZi9tY3pD?=
 =?utf-8?B?R0FXL3RPUFVTWi9jRlp6elJkR1FnQXhWRC9HalYyNXV4TWtVUk9JaGZ6TnNB?=
 =?utf-8?B?ODNXV3FVOFJzVGt2VEVLbmFrc25VK0dmYTR0S0UrZGhtQm5wZm4xR2s2ZjRu?=
 =?utf-8?B?YnBKMWFnZWNPV203dEkxK2hzY2NDNEpBZjluaFRSaUo5VER2aHkrclNyUU9t?=
 =?utf-8?B?VHhlTWFuSWpZSmtwUGxoN3M1Nm5DMTA5b1VQdm50YVY2b3Q2S1E2THlwdFJX?=
 =?utf-8?B?VG1IaEJvZVB2OGsrbTFXQ2RrMDNCYWR2RG1sRlJNUEsvMGNXb1BXSDdZcjY5?=
 =?utf-8?B?UlAxQm5hK0xQODdmeEZVQ0NtQTE4YWJudDhWcG5iMFZ0b081N3dsaEtSdzZ3?=
 =?utf-8?B?bkZBWHlJTkx1Q1hyUS9TSkkwbThVbW5ldmIzcW1SeVMzT2FSeWVhbFNSaWZU?=
 =?utf-8?B?WjBGNlBIRzBBYTROQTZEVVRZdVRSZmU0N3hyeVltMTlVeFZRcEE0WG4zN2ph?=
 =?utf-8?B?OUpQa0JyejI0cG94WTEzaG9mckI5YnphYVRHTW8xUG5jd1RxOEFrZGFORTBC?=
 =?utf-8?B?N2ZxcHdJcHQyalI1cThYdEhvWS9KOHNnVFZlV040bzZpYmltUDNWVU1KdHdW?=
 =?utf-8?B?RzJnNkZOSUJBalM3VmpQWUxuazA4cWRlSlpBM0FiN0dwNndkZS84enkyVFFC?=
 =?utf-8?B?anF0Q3l5a0FXSjJHMkFXNzFjVExYQkpkR3pDNVUvQUZIMC9PdE9ORDRFenhG?=
 =?utf-8?B?dEZydXhSa0dRMGlTc3lMM0MvKzhiTFRZVE5CamgwTEdtMXFyOElwcmg5dGhy?=
 =?utf-8?B?SURDVk5PQUtEdmNPOFlrVGZ3L2xSQWQxMVZ3RHJMb0pKT0JxMTMremR0d256?=
 =?utf-8?B?NFVWTmk0eEJ2VWxGNXowZ3ViRDJpRjY2Znl5NXI5aEhaZmxHM3l1aTArYVNR?=
 =?utf-8?B?RjJPQS9mNDEwT1JjTEpVK09oWUMreThtM0JmZTlSWTJOOElManI1OTRpSkxq?=
 =?utf-8?B?ZVIxMVJtVEhDaklwQzJpeUVDTWdLM3ovVXZBNmpEa1A2VVpIbEJudEVhMXZo?=
 =?utf-8?B?SjAzeHRQWGZvTVQvcVRodUZsdlAvaEVkZEIzZ0ovYlVzNEJTeVUwTW52cnly?=
 =?utf-8?B?SHhWS21kdkZpVFlzVnlqZnJLK2RjNnBLU1FCMmdGZVZ4U2xucmJKR0xMQkFP?=
 =?utf-8?B?eVhkWGhZak1XdXNVQk5DQVJpMWZUM1U1bWpBSEpVTXpBUlZlbG52YXNMb0V1?=
 =?utf-8?B?MExtYmxOWUd3S3FyVHNTM1FlMmpwYzIzSURBMjVXWWVUdEFRVjdNWGJrVEhP?=
 =?utf-8?B?elljQmY2SldlT05DZlFHalVFdFNvVFp6RUdxd3JhaGx0M0lhK2F3NGtldFN1?=
 =?utf-8?B?SFVvazBURXlCY1c4ZU9aVngvVnFIWC9BcnBIRS9tcmYyWTdYUi9xd2tzaWwv?=
 =?utf-8?B?a25JZ1I4Sk16VXZmazhZZnJ6d0FLWVJla3dOYTh0VElESjRkZW8wYzBZbWsy?=
 =?utf-8?B?RnNEVUsvMGttRXZtT2JOTDVmNzVHTGxXU25rdzVuSFE3QmwxQXdpYURCSGxW?=
 =?utf-8?B?L0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 241b7df4-0fd9-4b7d-ca03-08db0a0aa858
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1899.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 19:28:29.7617
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g+kCV8Dily7msVCfngItxThRxR7lHSMaj7L8ZjOPGNomgETMQYC6eu5Be/GnalZ2Jp1nyOeu5825AvlEYcKQ448Jg1Lai2E351j1/HkCUhU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5542
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/8/23 00:08, Ilpo Järvinen wrote:
> rsu_send_data() should return FW_UPLOAD_ERR_* error codes instead of
> normal -Exxxx codes. Convert <0 return from ->rsu_status() to
> FW_UPLOAD_ERR_HW_ERROR.
>
> Fixes: 001a734a55d0 ("fpga: m10bmc-sec: Make rsu status type specific")
Reviewed-by: Russ Weight <russell.h.weight@intel.com>

> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>
> ---
>  drivers/fpga/intel-m10-bmc-sec-update.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/intel-m10-bmc-sec-update.c b/drivers/fpga/intel-m10-bmc-sec-update.c
> index f0acedc80182..d7e2f9f461bc 100644
> --- a/drivers/fpga/intel-m10-bmc-sec-update.c
> +++ b/drivers/fpga/intel-m10-bmc-sec-update.c
> @@ -474,7 +474,7 @@ static enum fw_upload_err rsu_send_data(struct m10bmc_sec *sec)
>  
>  	ret = sec->ops->rsu_status(sec);
>  	if (ret < 0)
> -		return ret;
> +		return FW_UPLOAD_ERR_HW_ERROR;
>  	status = ret;
>  
>  	if (!rsu_status_ok(status)) {
>