From:   David Laight <David.Laight@ACULAB.COM>
To:     "'chris.chenfeiyang@gmail.com'" <chris.chenfeiyang@gmail.com>,
        "w@1wt.eu" <w@1wt.eu>, "paulmck@kernel.org" <paulmck@kernel.org>
CC:     Feiyang Chen <chenfeiyang@loongson.cn>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "chenhuacai@kernel.org" <chenhuacai@kernel.org>,
        "jiaxun.yang@flygoat.com" <jiaxun.yang@flygoat.com>,
        "loongarch@lists.linux.dev" <loongarch@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 2/5] tools/nolibc: Add statx() and make stat() rely on
 statx() when available
Thread-Topic: [PATCH v2 2/5] tools/nolibc: Add statx() and make stat() rely on
 statx() when available
Thread-Index: AQHZO6bWNfcYoy9T2k+HhbOMxyXnuK7FpFaw
Date:   Wed, 8 Feb 2023 22:39:18 +0000
Message-ID: <de9439e489684965989ac4e96b87de41@AcuMS.aculab.com>
References: <cover.1675851111.git.chenfeiyang@loongson.cn>
 <b9bbf73286238bb4657d855c9d50983aa17953e2.1675851111.git.chenfeiyang@loongson.cn>
In-Reply-To: <b9bbf73286238bb4657d855c9d50983aa17953e2.1675851111.git.chenfeiyang@loongson.cn>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: chris.chenfeiyang@gmail.com
> Sent: 08 February 2023 10:18
> 
> loongarch and riscv32 only have statx(). arc, hexagon, nios2 and
> openrisc have statx() and stat64() but not stat() or newstat().
> Add statx() and make stat() rely on statx() to make them happy.
> 
...
> +#ifdef __NR_statx
> +static __attribute__((unused))
> +int sys_stat(const char *path, struct stat *buf)
> +{
> +	struct statx stat;

If seems wrong that 'stat' has type 'struct statx'
and 'buf' type 'struct stat *'.

Maybe s/stat./statx./ and s/buf->/stat->/ ?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)