MIME-Version: 1.0
References: <a968c446bde75bf019580366854349bf94e6c961.1675897882.git.darren@os.amperecomputing.com>
 <CAMj1kXF2Bi_iyjzUK2zie_pt6Vnm4QwvarHicJoRzUiX7nU0Kw@mail.gmail.com> <Y+QztBs1uHnTRyyu@fedora>
In-Reply-To: <Y+QztBs1uHnTRyyu@fedora>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Thu, 9 Feb 2023 00:44:35 +0100
Message-ID: <CAMj1kXEZMGSMh7uEx5_7vQ=dWeq=4nERspkxKDGAkoBvYL4X0Q@mail.gmail.com>
Subject: Re: [PATCH] arm64: efi: Force the use of SetVirtualAddressMap() on
 Altra Max machines
To:     Darren Hart <darren@os.amperecomputing.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, stable@vger.kernel.org,
        linux-efi@vger.kernel.org,
        Alexandru Elisei <alexandru.elisei@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 9 Feb 2023 at 00:43, Darren Hart <darren@os.amperecomputing.com> wrote:
>
> On Thu, Feb 09, 2023 at 12:16:46AM +0100, Ard Biesheuvel wrote:
> > Hello Darren,
> >
> > On Thu, 9 Feb 2023 at 00:14, Darren Hart <darren@os.amperecomputing.com> wrote:
> > >
> > > Commit 550b33cfd445 ("arm64: efi: Force the use of SetVirtualAddressMap()
> > > on Altra machines") identifies the Altra family via the family field in
> > > the type#1 SMBIOS record. Altra Max machines are similarly affected but
> > > not detected with the strict strcmp test.
> > >
> > > Rather than risk greedy matching with strncmp, add a second test for
> > > Altra Max. Do not refactor to handle multiple tests as these should be
> > > the only two needed.
> > >
> >
> > Famous last words ...
>
> Indeed, I nearly included that myself...
>
> >
> > Unfortunately, I just had a report the other day that 'eMAG' and
> > 'Server' (!) are also being used.
> >
> > https://lore.kernel.org/all/20230131040355.3116-1-justin.he@arm.com/
> >
>
> OK, so in order to workaround this in the kernel, we need a better way to match.
> Unfortunately, this is specific to the oem platform, and the oem controls those
> strings.
>
> Thanks for the pointer, will go mull this over and see if I can come up with
> something better.
>
> In the meantime, would you consider matching on:
> Altra
> Altra Max
> eMAG
>
> to capture the bulk of the systems until we have a better solution?
>

Yeah that's fine.