To:     Bjorn Andersson <quic_bjorande@quicinc.com>
Cc:     Alim Akhtar <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        Bart Van Assche <bvanassche@acm.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Asutosh Das <quic_asutoshd@quicinc.com>,
        Bean Huo <beanhuo@micron.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Jinyoung Choi <j-young.choi@samsung.com>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <mani@kernel.org>
Subject: Re: [PATCH] scsi: ufs: core: Limit DMA alignment check
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1bkm3zpp8.fsf@ca-mkp.ca.oracle.com>
References: <20230201034917.1902330-1-quic_bjorande@quicinc.com>
Date:   Wed, 08 Feb 2023 18:45:49 -0500
In-Reply-To: <20230201034917.1902330-1-quic_bjorande@quicinc.com> (Bjorn
        Andersson's message of "Tue, 31 Jan 2023 19:49:17 -0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QRey84M+V7n83BktzWRpC5iT9bx8dvXwTE7aqQtKVwsOkRM6BIASh/VD2E5G?=
 =?us-ascii?Q?/Kwmc0EjShjPlo/WL6RK2jmfnf894q03qxyim6u0046vPGo1KsmZQBODl69n?=
 =?us-ascii?Q?hrCMi8ONYDwjW8SNawfu2NjxrDKjzv+B3R4AnVYu1O6ZGQ/PDM9QxQa0pfSG?=
 =?us-ascii?Q?GdsXUC5OU5Eyfj4MoPhDXhGpak5fAA0opnFrwvwk7xmFtPZdWRZYYHlfdAOS?=
 =?us-ascii?Q?IKSeXte0/JrCZ8tox1HHvNsH8JspcLtN0XL6SJwKsR56L1j0Ys2Dw8p31j4p?=
 =?us-ascii?Q?onwIX3FX8W4PxTbjLjq8FtSBO5GR6lwUU/xg/lNIA4TPOmtTkB7UBzICGbuD?=
 =?us-ascii?Q?Gn0JwryGtOyD4S2Y3SviPLq6VthXUG7Ed1hKQ+7r+TvshrbgS0qnh7b5o6h5?=
 =?us-ascii?Q?G/77LXohpjVSewlCBn/7p97fJM4jY990130jWmQvBMC4Qk51YiGcMDQ1ROtM?=
 =?us-ascii?Q?wtKx13JbUse9PMBa1z2w6vTzX3S1lPDSG9/xZiLHAldox8ldWx6cd1iI/jUg?=
 =?us-ascii?Q?yGviwjVtjyrqhJ2fZpGHeA8cVKODVrmJ/rb6EPLc7EbFy6qXJ99ZBNftoOV2?=
 =?us-ascii?Q?NtvvsP333eV2orZJhmYEOOdlxtzeUHInrCdyuFEwXW0bm5zZHtfpDyeonuRt?=
 =?us-ascii?Q?MFvLon+S7CrsV/qtpTRT8Hm2fzaejdLEKIuABRiJIzCbL2UxMnHNWcV2OW/8?=
 =?us-ascii?Q?CECuRmA7RY4+JH+wnjU+Zk/K/YjY8WLwEhjL2/nwDpPHYZEdR5OZahs/rLhl?=
 =?us-ascii?Q?m/6J0rEYus5gHr2lVuZ2hgERIeU25zUKu8/Yqn5hh4vurgC3epZR+5cf2XbM?=
 =?us-ascii?Q?PjvEYIPfXyvX3vAij5iqNcKFRtoFKQVWOLxYPK0vh6KNohgSLZEibjr2SWsK?=
 =?us-ascii?Q?CypeukajeK5Qf8nJEPRn3j/hpRGsqLN1Sje5L0DhYQyUKU8SIkoQgHqvOb/5?=
 =?us-ascii?Q?WYNhM0HBJPG4KvLWLMp2LUZMcDJFDvrXK3hkwTzpbFcjof8gWfYhZMCTmO+8?=
 =?us-ascii?Q?X2K/95GqVE/kePK1ME2ardGyvr213oAP0p4VL4iBwr1/qXHN9ZIkz2yBttSR?=
 =?us-ascii?Q?upV9FQibB4Df6RPwACvax+wGCqOF+JPOVrPTmv6R/pOceUHheoMm92h7CFKB?=
 =?us-ascii?Q?q+r0KPxwzbKkSjCRcvs80CgoBlpDzaR+Urbl6WVTHfucWX3OPL5e22L6aSFg?=
 =?us-ascii?Q?m1qy2FlVh7lDCy/5nD54qse9vMhdXNJng40sK/fuD8DsT1wiIxuzO1quau7z?=
 =?us-ascii?Q?Toml99KQyjY5dMFypBu1gBSMwmBMc4HzXpZDwhzWjW1ZtF5/49xKBxQywGO8?=
 =?us-ascii?Q?B5xTDAtk1exui6rmvvNzRrWLFA/YA6j+fAIOXESFX26YNZAQCRqewXcUJCqW?=
 =?us-ascii?Q?NFSSbx3po0T8wHIQcG0EEC+mMYdiCZHSOv4VnLgXfu+QF4CtxYnMFUaxS8pY?=
 =?us-ascii?Q?GnAajcED6k81dTuy7VnLZFcDBvu2rvCa1omu5w1DzmtXq1WtKQ0jJoDvJt8e?=
 =?us-ascii?Q?6W6xSbzUngn1JlYvUNo8Zx6+VN9YjGQ6CW33wibLC0LKSk/89cBSb1sZBgo6?=
 =?us-ascii?Q?xg1Kw+KYQEn6OaQxBLHXiu/9JA+S3Ta41JWHZiH3ErvbvzztCWE4KjsTTQGe?=
 =?us-ascii?Q?Aw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?C2Ys8tEMV589FSbh2avVzjXPnYNlqEGVTwZhEc7tT40Aq/wtOaMjr0MTuaDE?=
 =?us-ascii?Q?lIkPjBp9X49VF5PVZmg538yhUOKUC4VkVF+QUWdYds9f2mgKBro4wBR7HtnA?=
 =?us-ascii?Q?08hH7upJMm53AJZFXkFagrD3onBsWOL3pe/GrBfZmT+YLIJ5VIjazKTg1kGL?=
 =?us-ascii?Q?ZFOAMt8vGmk2LTMHTtJchfaZL9NMFO7GEELkWZxnfJpfNAAh7EorJgmxM36v?=
 =?us-ascii?Q?zjz+Sn7e3DRSEo2c7pbcy++w9Wd1UuUjVuWcu5uzU0g5h3OeUvx5tNWRKV4C?=
 =?us-ascii?Q?1hlNb+8z4jE0SoswDalJ+/2S+7929FvEKVBDqk+LmKpizrCjU3RaFtvAGbX9?=
 =?us-ascii?Q?zxTqAnm9Jw4RLJ3dVUDHrMB1L45bHNJQFiDCT0fhenc2Q1o6USaL5uHD748y?=
 =?us-ascii?Q?R9+ojkmq52lrJNwF3CdARaODY62KNtqV4hWa86sz8UBoWLj9AYYQRGqJqYOP?=
 =?us-ascii?Q?EBeNESjMj7+c1ebSoOIQpjf3YOGKtdFQ84KkUe/W+vgm1AUVn95e4y4pmcVt?=
 =?us-ascii?Q?o0NGELp08kA3vqNboJHVCZ4hCGzRZ2FQguYOmtsa6SWMeqdDjmf6OY2Pxp3F?=
 =?us-ascii?Q?CDPHiX9znvAklEfsKTRiK0SiO52hCclS8rSB++e+TUJWgFZ0EAbhLNTq0vQs?=
 =?us-ascii?Q?qX536390YieyqWWIRH47eB3jdOS/tKfTFiB42YC7y9yvAjERyAU3IiBX8EVJ?=
 =?us-ascii?Q?kzz/XVv26tUrt5+ayId6jU5jdn45K+qOa7j/6sjImfafca8KJRrEFShgly9d?=
 =?us-ascii?Q?CkeLH4M0MRzJTN4Wum3vjkO3dq1SCAiwP49k3N0Bd4CdpUZ25RTpKYvaW6AR?=
 =?us-ascii?Q?Js0t0/7ZU3ww2Djg+rH/DD07LiysQffmfzbzG+fvPGuh3tJFNykzLQZhNFhx?=
 =?us-ascii?Q?8Xc1c6tDErjtOqEZ4C8mCmb6vAs2c9/PnTXcbXbcthijtvMuHjYbpxb1exBD?=
 =?us-ascii?Q?8K4JOLRmfKys3CSSwziIAqHqoMXQihoioqiRMLvJWsVZy6ZEEs+L+YNbq5XS?=
 =?us-ascii?Q?g7gN?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1db020c6-f372-4b03-8d99-08db0a2e9d54
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 23:45:52.9425
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AgdqqjMAhWdYuX7aLSaRyaWzJy8pD6/2o6oERutLLvSs1o8GJTjrYF/uA/X32QxHoLMIJzZFm0KS2oD22855A9/l2lYEKD9OPv8CV0K/6uc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6219
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-02-08_10,2023-02-08_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=925
 malwarescore=0 adultscore=0 phishscore=0 suspectscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302080201
X-Proofpoint-ORIG-GUID: MBOTznLSoXLP9hlnn0I7ldp5SJ-WTy8M
X-Proofpoint-GUID: MBOTznLSoXLP9hlnn0I7ldp5SJ-WTy8M
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Bjorn,

> The three DMA memory regions allocated for the host memory space is
> documented to require alignment of 128, 1024 and 1024 respectively,
> but the returned address is checked for PAGE_SIZE alignment.

Applied to 6.3/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering