Date:   Thu, 9 Feb 2023 01:55:40 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     "A. Sverdlin" <alexander.sverdlin@siemens.com>
Cc:     Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        NXP Linux Team <linux-imx@nxp.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: fec: Defer probe if other FEC has deferred MDIO
Message-ID: <Y+REjDdjHkv4g45o@lunn.ch>
References: <20230208101821.871269-1-alexander.sverdlin@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230208101821.871269-1-alexander.sverdlin@siemens.com>
Precedence: bulk

> -	if ((fep->quirks & FEC_QUIRK_SINGLE_MDIO) && fep->dev_id > 0) {
> +	if (fep->quirks & FEC_QUIRK_SINGLE_MDIO) {
>  		/* fec1 uses fec0 mii_bus */
>  		if (mii_cnt && fec0_mii_bus) {
>  			fep->mii_bus = fec0_mii_bus;
>  			mii_cnt++;
>  			return 0;
>  		}
> -		return -ENOENT;

Could you not add an else clause here? return -EPROBE_DEFFER?

Basically, if fec0 has not probed, deffer the probing of fec1?

	   Andrew