MIME-Version: 1.0
References: <20221219055431.22596-1-ashimida.1990@gmail.com>
In-Reply-To: <20221219055431.22596-1-ashimida.1990@gmail.com>
From:   Hongtao Liu <crazylht@gmail.com>
Date:   Thu, 9 Feb 2023 09:48:10 +0800
Message-ID: <CAMZc-bzmACcpSePKxuuA=ug2+yik+Zo3-mfqr2OyZ-n_nT=OnQ@mail.gmail.com>
Subject: Re: [RFC/RFT 0/3] Add compiler support for Control Flow Integrity
To:     Dan Li <ashimida.1990@gmail.com>
Cc:     gcc-patches@gcc.gnu.org,
        Richard Sandiford <richard.sandiford@arm.com>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Michal Marek <michal.lkml@markovi.net>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Sami Tolvanen <samitolvanen@google.com>,
        Kees Cook <keescook@chromium.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Tom Rix <trix@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Josh Poimboeuf <jpoimboe@kernel.org>,
        Frederic Weisbecker <frederic@kernel.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Marco Elver <elver@google.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Song Liu <song@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Uros Bizjak <ubizjak@gmail.com>,
        Kumar Kartikeya Dwivedi <memxor@gmail.com>,
        Juergen Gross <jgross@suse.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Borislav Petkov <bp@suse.de>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Aaron Tomlin <atomlin@redhat.com>,
        Kalesh Singh <kaleshsingh@google.com>,
        Yuntao Wang <ytcoode@gmail.com>,
        Changbin Du <changbin.du@intel.com>,
        linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev,
        linux-hardening@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Dec 19, 2022 at 3:59 PM Dan Li via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> This series of patches is mainly used to support the control flow
> integrity protection of the linux kernel [1], which is similar to
> -fsanitize=kcfi in clang 16.0 [2,3].
>
> I hope that this feature will also support user-mode CFI in the
> future (at least for developers who can recompile the runtime),
> so I use -fsanitize=cfi as a compilation option here.
>
> Any suggestion please let me know :).
Do you have this series as a branch somewhere that we could also try for x86?

>
> Thanks, Dan.
>
> [1] https://lore.kernel.org/all/20220908215504.3686827-1-samitolvanen@google.com/
> [2] https://clang.llvm.org/docs/ControlFlowIntegrity.html
> [3] https://reviews.llvm.org/D119296
>
> Dan Li (3):
>   [PR102768] flag-types.h (enum sanitize_code): Extend sanitize_code to
>     64 bits to support more features
>   [PR102768] Support CFI: Add new pass for Control Flow Integrity
>   [PR102768] aarch64: Add support for Control Flow Integrity
>
> Signed-off-by: Dan Li <ashimida.1990@gmail.com>
>
> ---
>  gcc/Makefile.in                               |   1 +
>  gcc/asan.h                                    |   4 +-
>  gcc/c-family/c-attribs.cc                     |  10 +-
>  gcc/c-family/c-common.h                       |   2 +-
>  gcc/c/c-parser.cc                             |   4 +-
>  gcc/cgraphunit.cc                             |  34 +++
>  gcc/common.opt                                |   4 +-
>  gcc/config/aarch64/aarch64.cc                 | 106 ++++++++
>  gcc/cp/typeck.cc                              |   2 +-
>  gcc/doc/invoke.texi                           |  35 +++
>  gcc/doc/passes.texi                           |  10 +
>  gcc/doc/tm.texi                               |  27 +++
>  gcc/doc/tm.texi.in                            |   8 +
>  gcc/dwarf2asm.cc                              |   2 +-
>  gcc/flag-types.h                              |  67 ++---
>  gcc/opt-suggestions.cc                        |   2 +-
>  gcc/opts.cc                                   |  26 +-
>  gcc/opts.h                                    |   8 +-
>  gcc/output.h                                  |   3 +
>  gcc/passes.def                                |   1 +
>  gcc/target.def                                |  39 +++
>  .../aarch64/control_flow_integrity_1.c        |  14 ++
>  .../aarch64/control_flow_integrity_2.c        |  25 ++
>  .../aarch64/control_flow_integrity_3.c        |  23 ++
>  gcc/toplev.cc                                 |   4 +
>  gcc/tree-cfg.cc                               |   2 +-
>  gcc/tree-cfi.cc                               | 229 ++++++++++++++++++
>  gcc/tree-pass.h                               |   1 +
>  gcc/tree.cc                                   | 144 +++++++++++
>  gcc/tree.h                                    |   1 +
>  gcc/varasm.cc                                 |  29 +++
>  31 files changed, 803 insertions(+), 64 deletions(-)
>  create mode 100644 gcc/testsuite/gcc.target/aarch64/control_flow_integrity_1.c
>  create mode 100644 gcc/testsuite/gcc.target/aarch64/control_flow_integrity_2.c
>  create mode 100644 gcc/testsuite/gcc.target/aarch64/control_flow_integrity_3.c
>  create mode 100644 gcc/tree-cfi.cc
>
> --
> 2.17.1
>


--
BR,
Hongtao