MIME-Version: 1.0
References: <cover.1675851111.git.chenfeiyang@loongson.cn> <b9bbf73286238bb4657d855c9d50983aa17953e2.1675851111.git.chenfeiyang@loongson.cn>
 <de9439e489684965989ac4e96b87de41@AcuMS.aculab.com>
In-Reply-To: <de9439e489684965989ac4e96b87de41@AcuMS.aculab.com>
From:   Feiyang Chen <chris.chenfeiyang@gmail.com>
Date:   Thu, 9 Feb 2023 10:14:50 +0800
Message-ID: <CACWXhK=VXaMixrDTdo-ydgGw64vemu9kNUws5ef-91TFf-GPGg@mail.gmail.com>
Subject: Re: [PATCH v2 2/5] tools/nolibc: Add statx() and make stat() rely on
 statx() when available
To:     David Laight <David.Laight@aculab.com>
Cc:     "w@1wt.eu" <w@1wt.eu>, "paulmck@kernel.org" <paulmck@kernel.org>,
        Feiyang Chen <chenfeiyang@loongson.cn>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "chenhuacai@kernel.org" <chenhuacai@kernel.org>,
        "jiaxun.yang@flygoat.com" <jiaxun.yang@flygoat.com>,
        "loongarch@lists.linux.dev" <loongarch@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 9 Feb 2023 at 06:39, David Laight <David.Laight@aculab.com> wrote:
>
> From: chris.chenfeiyang@gmail.com
> > Sent: 08 February 2023 10:18
> >
> > loongarch and riscv32 only have statx(). arc, hexagon, nios2 and
> > openrisc have statx() and stat64() but not stat() or newstat().
> > Add statx() and make stat() rely on statx() to make them happy.
> >
> ...
> > +#ifdef __NR_statx
> > +static __attribute__((unused))
> > +int sys_stat(const char *path, struct stat *buf)
> > +{
> > +     struct statx stat;
>
> If seems wrong that 'stat' has type 'struct statx'
> and 'buf' type 'struct stat *'.
>
> Maybe s/stat./statx./ and s/buf->/stat->/ ?
>

Hi, David,

Yes, it looks better to use 'struct statx statx'. Thank you!
I'd like to keep 'buf' to be consistent with the stat() below.
int stat(const char *path, struct stat *buf);

Thanks,
Feiyang

>         David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>