Message-ID: <400c57ca-2804-a660-e543-42e15ac3b4a4@linux.alibaba.com>
Date:   Thu, 9 Feb 2023 10:30:45 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH v2 1/2] erofs: update print symbols for various flags in
 trace
Content-Language: en-US
To:     Gao Xiang <hsiangkao@linux.alibaba.com>, xiang@kernel.org,
        chao@kernel.org, linux-erofs@lists.ozlabs.org, huyue2@coolpad.com
Cc:     linux-kernel@vger.kernel.org
References: <20230208112915.6543-1-jefflexu@linux.alibaba.com>
 <416afeb8-4385-6d8a-4b35-2c75ffaa36cc@linux.alibaba.com>
From:   Jingbo Xu <jefflexu@linux.alibaba.com>
In-Reply-To: <416afeb8-4385-6d8a-4b35-2c75ffaa36cc@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2/9/23 10:29 AM, Gao Xiang wrote:
> 
> 
> On 2023/2/8 19:29, Jingbo Xu wrote:
>> As new flags introduced, the corresponding print symbols for trace are
>> not added accordingly.  Add these missing print symbols for these flags.
>>
>> Also remove the print symbol for EROFS_GET_BLOCKS_RAW as it is going to
>> be removed soon.
>>
>> Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
>> ---
>> v2: remove print symbol for EROFS_GET_BLOCKS_RAW
>> ---
>>   include/trace/events/erofs.h | 13 +++++++++----
>>   1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/trace/events/erofs.h b/include/trace/events/erofs.h
>> index e095d36db939..cf4a0d28b178 100644
>> --- a/include/trace/events/erofs.h
>> +++ b/include/trace/events/erofs.h
>> @@ -19,12 +19,17 @@ struct erofs_map_blocks;
>>           { 1,        "DIR" })
>>     #define show_map_flags(flags) __print_flags(flags, "|",    \
>> -    { EROFS_GET_BLOCKS_RAW,    "RAW" })
> 
> Should we remove this in the next patch?
> Otherwise it looks good to me.
> 

Okay I will update this in the next version.

-- 
Thanks,
Jingbo