From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Nicolin Chen <nicolinc@nvidia.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "will@kernel.org" <will@kernel.org>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "shuah@kernel.org" <shuah@kernel.org>
CC:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Subject: RE: [PATCH v2 03/10] iommufd: Create access in
 vfio_iommufd_emulated_bind()
Thread-Topic: [PATCH v2 03/10] iommufd: Create access in
 vfio_iommufd_emulated_bind()
Thread-Index: AQHZOzoM5El+JaA+Aka5+yDNWUDRda7F7ZHw
Date:   Thu, 9 Feb 2023 02:56:39 +0000
Message-ID: <BN9PR11MB527662B3BCB562D4E0969C878CD99@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <cover.1675802050.git.nicolinc@nvidia.com>
 <6083ba9a3c1d92baf1f324d4748333d80d3de830.1675802050.git.nicolinc@nvidia.com>
In-Reply-To: <6083ba9a3c1d92baf1f324d4748333d80d3de830.1675802050.git.nicolinc@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kj/yGaldp6J3RsTih09MmQk+avPGJhjTtzJ/4J09ivncysLJjPdJLO3HY/Xc?=
 =?us-ascii?Q?1XDIN43hBrZf2Xxu1F1I8xpiCzbGuVTWdhEy4peWZbiyA5PJyugsB5oIan3j?=
 =?us-ascii?Q?BggU1lL5snhNodAp9T3BNvMv8Jy6XaLEKENdCYKnkGmFA9EIqE9WgcRuU00f?=
 =?us-ascii?Q?yvnHRi3mmzOdDtW9AqhBvBfXZ0191LO2hct9xVCuc2O6PcChW8g7cbeLh7l+?=
 =?us-ascii?Q?93G64NNaUeNSFjV9FNTaDSCaMsWQ2T5tfiHfy48zJaz1kA1oZvA0F2TGIYGq?=
 =?us-ascii?Q?q29QY1DLKnpig3tfHkSyXeLrXnwaPnjEJSowCcdgUOEri+pz15p9yQGRhok9?=
 =?us-ascii?Q?Yc2kNT8Nn/nNLq97968G5N0mYRw3U8eLWfgo3UkVsUuuEOHceNwNseFsCcPF?=
 =?us-ascii?Q?VleTVHh/L+s9oAlMc7EspkQaXuCbH0XUQbo5pKkX0JHkOlZtJp7fyCaZ01zm?=
 =?us-ascii?Q?uCiCeYpJFODxmk7+HYNHqhArfPm1KRu1sRaepj9/BQPeFKsKznmgKHT6Qa5q?=
 =?us-ascii?Q?nHJlIAz9gF6elK+gRbaKtgmIMm6UPM2Lrc5Sm8FTtxcULYdLnPmVwAsLkWaG?=
 =?us-ascii?Q?lT0+fVsqtd1129h20lou2InKkypfZGZgEDkzowgFuKoXzGZ6IBTnomMdwlUB?=
 =?us-ascii?Q?EGIP98rn2iWZO6NsDgGUl4nG5qndP3+GRq9pgrq8eVDVQ/8MoE+qiIHhT+bP?=
 =?us-ascii?Q?phGR9lRH5RXEZ6oXij4+Rg61PndHMKlpiDPlJ1Te9Kx5e9DS3UyJISo5o+Et?=
 =?us-ascii?Q?Mdo7ZX+2jQNWJzHEgF6mM8lwWeX8GlJyBosNGQ8ErvpVXJZ39LpMbS0R/9yX?=
 =?us-ascii?Q?yxniz4qOxo+BxnbdRqnYDVoWJq7uM0jlehso2AJbg67tvieQTnCHDL98Hs6g?=
 =?us-ascii?Q?HIEcawV+M906YI66gttfAEzktuw96xrIIZZZ+FG3u1GF0TAcCCYE7tvbZoUa?=
 =?us-ascii?Q?40+KLaGVKnIJkq+xq+3kSR70DS/36HFGQCRooDZWtucTfUg03343Fz9jC5+y?=
 =?us-ascii?Q?17UTvAJE1L7BcuCj1Xrgf81fq+LItoJJvu52WyziGcs71R+fCDRRqZ1GtJri?=
 =?us-ascii?Q?5e7uSEeqzAIJOjWIBnuqv81a5rdstfy155nBBgHe6GazyQw/A/WjALLsmKCy?=
 =?us-ascii?Q?GxpbGhVAqjLmORGanR1ovIaPGt4SwL9smytc18VwFm3/EHA3pHm10Xg8/EuI?=
 =?us-ascii?Q?cBHdywmPm4SvSMBfzDIG8OJrU0R46Rb5Vyjf4niMZYfkA0NOCEUngPzYteln?=
 =?us-ascii?Q?Vbibk9OeKcwnI51Xh1bJVtWWB5lpz/hHosPrBWGS8olTfxJCgVwOcItAAvYV?=
 =?us-ascii?Q?mXUU5GorxsMxD60znkb1co1hmBahEBD60fBdnRLCBMdWLg0f8e7koang71Fp?=
 =?us-ascii?Q?ESTCPOQjl9lPGzMthmoo2l2wU59nIaarI9t4IU5Vs0od1jMHQuGSH8Yo3KHY?=
 =?us-ascii?Q?sj8tKgODWyZARTglvHYSgjj4bDMD65HUkHEXfo9EDTNJxnk6QEaQRuMdpIy4?=
 =?us-ascii?Q?p2RtxNNGEjlHBKkoHIC/XsuEBmuKhMHWsI06lkOmO0DniUVmxxfAQ3cBRE+S?=
 =?us-ascii?Q?JN+dro13paKKSt7djLzBANbMbQYVp+lwZCcCH9rt?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: caab7c7a-0027-4e18-2c16-08db0a4943e5
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2023 02:56:39.0571
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WZN11YOTeFjen3x1deDFtoqL6WxDTc3Gbn8DFSpyNy0c1f1z970/WQmyRoAUOSb5svr/NxgZXteSVHD2+p4sUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5544
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Wednesday, February 8, 2023 5:18 AM
>
> @@ -141,10 +141,19 @@ static const struct iommufd_access_ops
> vfio_user_ops =3D {
>  int vfio_iommufd_emulated_bind(struct vfio_device *vdev,
>  			       struct iommufd_ctx *ictx, u32 *out_device_id)
>  {
> +	struct iommufd_access *user;
> +
>  	lockdep_assert_held(&vdev->dev_set->lock);
>=20
> -	vdev->iommufd_ictx =3D ictx;
>  	iommufd_ctx_get(ictx);
> +	user =3D iommufd_access_create(vdev->iommufd_ictx, &vfio_user_ops,
> vdev);
> +	if (IS_ERR(user)) {
> +		iommufd_ctx_put(vdev->iommufd_ictx);
> +		return PTR_ERR(user);
> +	}
> +	iommufd_access_set_ioas(user, 0);

this is not required since ioas has been NULL after creation.

otherwise,

Reviewed-by: Kevin Tian <kevin.tian@intel.com>