Message-ID: <1d9b8ee8-c3f2-99bc-cd4e-8c2dd0f04b2b@quicinc.com>
Date:   Thu, 9 Feb 2023 11:02:36 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH] coresight: core: Add sysfs node to reset all sources and
 sinks
Content-Language: en-US
To:     Suzuki K Poulose <suzuki.poulose@arm.com>,
        Mike Leach <mike.leach@linaro.org>
CC:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        <coresight@lists.linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        Tingwei Zhang <quic_tingweiz@quicinc.com>,
        Yuanfang Zhang <quic_yuanfang@quicinc.com>,
        Tao Zhang <quic_taozha@quicinc.com>,
        Hao Zhang <quic_hazha@quicinc.com>
References: <20230208111630.20132-1-quic_jinlmao@quicinc.com>
 <CAJ9a7ViBS9K6cKsOi3btw1b5cM9VTSb-q8s6W3WUAgeW3-T2Sg@mail.gmail.com>
 <CAJ9a7ViA5BsbLjRWMsttmpmcPh1yUXK8J79k-pqYybVZkMQHXQ@mail.gmail.com>
 <bb6c9df9-af9b-873e-85bd-a29d00bb39d7@arm.com>
From:   Jinlong Mao <quic_jinlmao@quicinc.com>
In-Reply-To: <bb6c9df9-af9b-873e-85bd-a29d00bb39d7@arm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2/9/2023 12:36 AM, Suzuki K Poulose wrote:
> On 08/02/2023 16:20, Mike Leach wrote:
>> Quick correction - you need to look for enable_source  / enable_sink
>> files and disable those that are currently '1'
>>
>> Mike
>>
>> On Wed, 8 Feb 2023 at 16:16, Mike Leach <mike.leach@linaro.org> wrote:
>>>
>>> Hi
>>>
>>> As this is a sysfs only update - would it not be easier to simply use
>>> a shell script to iterate through coresight/devices/ looking for
>>> disable_source / disable_sink files and setting those accordingly?
>>>
>>> See tools/perf/tests/shell/test_arm_coresight.sh for an example of a
>>> script that does similar iteration to test coresight in perf
>>>
>
> +1
>
> Suzuki

Hi Mike & Suzuki,

Sometimes user just want to have some quick test from PC with adb commands.
It is very easy to reset all sources and sinks' status by command below.
echo 1 > /sys/bus/coresight/reset_source_sink

Preparing the script for test is not easy for users who are not familiar 
with the coresight framework.

Thanks
Jinlong Mao

>
>