From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Nicolin Chen <nicolinc@nvidia.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "will@kernel.org" <will@kernel.org>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "shuah@kernel.org" <shuah@kernel.org>
CC:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Subject: RE: [PATCH v2 07/10] iommufd/device: Make hwpt_list list_add/del
 symmetric
Thread-Topic: [PATCH v2 07/10] iommufd/device: Make hwpt_list list_add/del
 symmetric
Thread-Index: AQHZOzoSQMv1v33l6Eyp7LBz8BGoIq7F9D6A
Date:   Thu, 9 Feb 2023 03:23:47 +0000
Message-ID: <BN9PR11MB5276F36D2F07209AC7155BAB8CD99@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <cover.1675802050.git.nicolinc@nvidia.com>
 <9d0d4f935c4972771f5aed4b4837d8ae35814e06.1675802050.git.nicolinc@nvidia.com>
In-Reply-To: <9d0d4f935c4972771f5aed4b4837d8ae35814e06.1675802050.git.nicolinc@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?znmL5q96jJFMH2pobBcFi/+l1Trr0Ove1poFQnwYZ8oE6l5e/l58n3Az0aGB?=
 =?us-ascii?Q?BHmtA5WyjKoxNrK84fePLnJwDLnHCCmJ0cJGxv9C/gGYMWUY6c5JYGbRhrHH?=
 =?us-ascii?Q?hjavtSc2wIxG7+CukrnsstCi00zmZ9xjAZzOgr5cHwaA5B9eHBuXWixPqiU/?=
 =?us-ascii?Q?amrnYFRWZxFjZW8k0E23nv3V43biikU39Y+0VdLjszsUr1eqkKXqleFbfVOJ?=
 =?us-ascii?Q?U+pk1rtw9yFJi8dcF1+FQTxIofdDDt3tePT/+9Koi6Ks13R4jDP8YRWYoF5R?=
 =?us-ascii?Q?RJwkD9LFi/csP+mwgNgrzwxM8kUnNaRk7CiTeB1MkMBe0lr1lAwPHzth38GC?=
 =?us-ascii?Q?33EcWtWcDv09s+WuCiqalU20mM4m+XVtfgg+FZNy7WVDHDZ+TNDdLmSIHC0k?=
 =?us-ascii?Q?UaZvICg8EM3X4d6Vi6VwPWeGlLdByfzEwJ5o0xDJW4XC6Az+dxIJseQP9tYq?=
 =?us-ascii?Q?o3n2R4njJHsdC2jXyhWhAQmeuR9KU6McjHJQpJoXNxMG8IYU5RrjPuUQl1R+?=
 =?us-ascii?Q?WWNIDe+tRB2CB0zB3rdfRAEr98mcTMeZx9NjgtdDLPkq6JZMlomLoqnwHoQC?=
 =?us-ascii?Q?cb3EiHCrcnegFAJuJcFWY+8ZxjrDkY8hpsexovG5AaIsSzXMk8Jjh5OVUy8p?=
 =?us-ascii?Q?yEzL4sp5znL+m9P6pOjLhAbe0sgC4XmU+ZpHJ5oytgwkgZq98Y5MrGLtU6v1?=
 =?us-ascii?Q?dGDGOYeDMLUNUcDCOLRJJkijclXbl/6hM9bJBiO8P255ikV5tLM1I9rgVTxD?=
 =?us-ascii?Q?ld4muy8a7x8v3SVtnVFMaYB7HpvdsMDRb2OVXrzdkCG/51ecXeGvEeVTmf0K?=
 =?us-ascii?Q?z4CtSbPs/WPx6lB0Q3pB6LR3bsKZEPMYN9s+7K8FtXGLRIU0xgIqJfcCljDn?=
 =?us-ascii?Q?5z/k/Lu22jDCfXcFC8EoPFPb2q/Fj06N91rlax5MoezfJO88e74njdX1MOuw?=
 =?us-ascii?Q?5OPk86bWlTtHFlgxmZsnfWzbXtHkt78+7d/+caHctP3AW+9uWfsFnHNUYm/Z?=
 =?us-ascii?Q?GJGXQfEAy2IHW+rLHGAvEmFVJeNWF3JXyJ3XMo4Duqw4wZBHYLg2x6E5x1Di?=
 =?us-ascii?Q?y5Be8/QygMqsLEhYSSMMPptIQYPvphwJ6D6zApOw2UeYLZZGBwwVsOtmupuw?=
 =?us-ascii?Q?mFBnc45EFe0xnDfU0C/KrIpR4m3xtSh8+Oi2N1L08UZQDVJu3bPiVJ/+A5qJ?=
 =?us-ascii?Q?1mrLt0+HBhQpziL9kpAQZaBbPvBxit21TbmifBT+IOcgA8O7fbsBAYIoxVpa?=
 =?us-ascii?Q?Xs/elvsdvr3M4pkr6LJWp16eQJLa62HQ36NdWqn6NEz/fy4pGkZ97kMhprbG?=
 =?us-ascii?Q?zTComaOlonfeXxDD1q+YtFZHRgZ12Aup4w4+IdxbmfNiexmHHfolv+0tHr32?=
 =?us-ascii?Q?El/JRNfb3nDKEy4kvHz7whKlYiBiSdfUbw3E+bKLYw5KK4Oa9AuaWyUslpNY?=
 =?us-ascii?Q?pfRHarNYuNBaiNxPp5aDsRriM8xbtDrLW1dwprwbXjSR+BBi4KBSaYvIlFWQ?=
 =?us-ascii?Q?IEOF0Kkz+iIjttWz0f1UhGFBIXe540ztjsiI6pXENqMCPDoj5C5ws9h9SwFE?=
 =?us-ascii?Q?71Qeqn+UreF9LfZk/ASd8pdr0ZJM5gXXbR4w7ISX?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 632ef2b6-2c77-4804-5831-08db0a4d0e65
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2023 03:23:47.2714
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fYsdyjO5lG0yFoRdoZ6yevCImEfEBOrpp6maozMwlb1hQyI/IiVuBOyVwWlWwAef6VqxVJeJb9cYZrFkHhKjFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6306
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Wednesday, February 8, 2023 5:18 AM
>=20
> Because list_del() is together with iopt_table_remove_domain(), it makes
> sense to have list_add_tail() together with iopt_table_add_domain().
>=20
> Also place the mutex outside the iommufd_device_do_attach() call, similar
> to what's in the iommufd_device_auto_get_domain() function.
>=20
> Co-developed-by: Yi Liu <yi.l.liu@intel.com>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>

shouldn't this be a separate bug fix and backported? double adding a
list item would certainly clobber the list...