MIME-Version: 1.0
References: <cover.1675907639.git.chenfeiyang@loongson.cn> <Y+RqCcaS6pJ+W9+N@1wt.eu>
In-Reply-To: <Y+RqCcaS6pJ+W9+N@1wt.eu>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Thu, 9 Feb 2023 11:38:02 +0800
Message-ID: <CAAhV-H4-m3AaS4-w-+yyUwBMt8Fm30SkS7ZnfSL5zA1OzJsLTA@mail.gmail.com>
Subject: Re: [PATCH v3 0/5] Add LoongArch support to nolibc
To:     Willy Tarreau <w@1wt.eu>
Cc:     chris.chenfeiyang@gmail.com, paulmck@kernel.org,
        Feiyang Chen <chenfeiyang@loongson.cn>, arnd@arndb.de,
        jiaxun.yang@flygoat.com, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Acked-by: Huacai Chen <chenhuacai@loongson.cn>

On Thu, Feb 9, 2023 at 11:35 AM Willy Tarreau <w@1wt.eu> wrote:
>
> Hi Feiyang,
>
> On Thu, Feb 09, 2023 at 11:24:11AM +0800, chris.chenfeiyang@gmail.com wrote:
> > From: Feiyang Chen <chenfeiyang@loongson.cn>
> >
> > Add statx() and make stat() rely on statx() if necessary.
> > Add support for LoongArch (32 and 64 bit) to nolibc.
> > It was tested on LoongArch64 only.
> >
> > The latest QEMU support full-system emulation of a LoongArch64
> > machine, but for the moment we need to specify the firmware manually.
> > https://github.com/loongson/Firmware/tree/main/LoongArchVirtMachine
> >
> > QEMU_ARGS_loongarch  = -M virt -bios edk2-loongarch64-code.fd ...
> >
> > v2:
> > - Mention that statx() will also benefit other architectures.
> > - Make stat() rely on statx() when available.
> > - Put the whitespace changes into one commit.
> >
> > v3:
> > - Add #if defined(__NR_statx) guard.
> > - Keep the check for statx() from the first version.
> > - Mention that we may use statx() everywhere in the future.
> > - struct statx stat -> struct statx statx.
>
> I'm personally fine with this one. I'll give it a try with all supported
> archs to make sure we don't have any unexpected side effect, and unless
> anyone has any other comment, we'll queue this series.
>
> Thank you!
> Willy