From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Nicolin Chen <nicolinc@nvidia.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "will@kernel.org" <will@kernel.org>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "shuah@kernel.org" <shuah@kernel.org>
CC:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Subject: RE: [PATCH v2 10/10] vfio: Do not allow !ops->dma_unmap in
 vfio_pin/unpin_pages()
Thread-Topic: [PATCH v2 10/10] vfio: Do not allow !ops->dma_unmap in
 vfio_pin/unpin_pages()
Thread-Index: AQHZOzoS0Bls524n7k+sAm+muGsnhq7GAZjQ
Date:   Thu, 9 Feb 2023 04:10:04 +0000
Message-ID: <BN9PR11MB527687E27FC35CD842E4EA7B8CD99@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <cover.1675802050.git.nicolinc@nvidia.com>
 <59e5eeac675172ab1cb07236a3eb3e166553fe71.1675802050.git.nicolinc@nvidia.com>
In-Reply-To: <59e5eeac675172ab1cb07236a3eb3e166553fe71.1675802050.git.nicolinc@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IKvLyJEDX0zOgJeXkOJ/tNow6uBwStyrfM9m0acaJTIBY1+9DuXWpzMqMKMx?=
 =?us-ascii?Q?TRDjVekaJUgPYe35NhSRQAxjzqXXcQ53yPzSb9YcRDUvE9ZAd/8rIOmsmSOT?=
 =?us-ascii?Q?3HBs/eD3j4ke+yaZ8bih+lNfr/KJIeiRh6aVzo3j1hC7tpLb3hA7oQ1kvbCe?=
 =?us-ascii?Q?mbZLn+uOOJ06DeXh1b5pZrhYu3m6DfDiq3oud8heRWc6EJM3ifLwq/F1ufWx?=
 =?us-ascii?Q?VtAhxDZWo4Odz+n3eKz6ClZPaU9kurrVMU4f/YzDsjTTxtSMbIIj4SSU1i9y?=
 =?us-ascii?Q?N7vbG756DlHVOnieuys4Q3MU91V0fWB9ow795DKhz0H1im21RuaxEt3dLarx?=
 =?us-ascii?Q?fAs0ZILJZFexE80SUzR0WYTW9+ZHu17dtMToIg7spzAG7dFKjQXm7xmerdtu?=
 =?us-ascii?Q?qoB8tJjbjufEfr1SksyE/4J4iKKaOw2F0aQpiIa0AJV9giGJZ3c1XQoQzZE+?=
 =?us-ascii?Q?sJN+9XdZG9bcSJtEPT73NspON/K/VlT15Q3hcqxSTdjfZEMderDI4PdcHCwc?=
 =?us-ascii?Q?yspRZ/6aRf0JNrgyUNU5fR0mZ/pZjzjaVBNkor0PxLMH5JjqMNH/1E3vLeT/?=
 =?us-ascii?Q?gawOfLd3JpRO0CGdsu4Q6oxEV3aBKeXREfYkNjXwUyBBifAR+fe3gCZAkdQf?=
 =?us-ascii?Q?VP+TsS8hHAPYAatBb7YpDCJqRkp8Ma/NvQY7lojCKlqcxmVZZyJhBslJkUWp?=
 =?us-ascii?Q?KHk1JC1OxKMgHxAnd/pXQgnqsPCqiZmCkxKiqj+4FiLTFSZdDyAgGCCZ3XS5?=
 =?us-ascii?Q?JEZxyYN4hdjSeahVh73EN/o6hxO9uCdKo/oeN0jmTwRv1LZjqqDF8LNTLUJ+?=
 =?us-ascii?Q?EdQUK25CrByKNfn4tlqIdcdX7aSbaKHCIcbYXTEUBAG1ETuOK7feE8PFzcX+?=
 =?us-ascii?Q?r2gnc0zzyPtjwccVvMDgD6iXX5enBLuRu4V/9DyTEzGmx9KMLE2TtPejBaaD?=
 =?us-ascii?Q?5SObEBON46p5WF31NVcwY9/BS6ihtlQOHX69f9y0Blq95eDVHLLM362IXpWZ?=
 =?us-ascii?Q?MF19bJVoUrx+DxKmqQBqqg7GN5PGQh5akpJYEV5iUuXPvXWWmr2u9AhBZ2Y+?=
 =?us-ascii?Q?lSGHu+/zEyZhzKNOjEO0/D+Qa8kBlSto8zfvQn/sri8ddJb/qxS84EMIe9cd?=
 =?us-ascii?Q?7imCNqoCxfUo3UaGjrf8TrqxhJ0IioFreQvdjdNkCJjfo0Tu4AALnRc1kYV8?=
 =?us-ascii?Q?F++zVl/gjPmryemvwlfrVafLrFknM6lDJ3146sUTovAtBCeJUn2l54Y2+WTm?=
 =?us-ascii?Q?SPuJdSq1H3DgEWSyviTJX0DYdxdzq3pEv6pWOq19e0fDZuwnY2tz0Pr/v/RN?=
 =?us-ascii?Q?eJDURg3ESuBnzZJ7/cGhqrfPqZWvi+zn+HYu4r6RJ4afETTq+gQdlRECZpZ0?=
 =?us-ascii?Q?9VT+oYze680/nk+EQrv8pKkWYZT+oKFJr0u/+QrnyDzg02U+IifOL1Rwajkh?=
 =?us-ascii?Q?EMHu9/WpcG7oNH0tY7vGqtSuRraquZOQIDktVc5JGcIe3qw6P6WMCR4f5N7u?=
 =?us-ascii?Q?PdKoS2x+sZCC+oTxKlts/dyOLlrmBjF0gLrzQ53pt7KBsa1MOsmEqqzInolm?=
 =?us-ascii?Q?VIuVt3DKDsoyM2KtlyXt8Sw9EVNkmrgN0f8IIR5E?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: daa858cd-1d33-41ef-ba96-08db0a53857f
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2023 04:10:04.1037
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: M5ceS0/DqV69id1MVLrxyIkgbD0/B6jo8evV9L16dknPCXP3cXhBEWlQ1Y/tH0jWIYvjjSDMKN6N7c9U3ucD3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6995
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Wednesday, February 8, 2023 5:18 AM
>=20
> A driver that doesn't implement ops->dma_unmap shouldn't be allowed to
> do
> vfio_pin/unpin_pages(), though it can use vfio_dma_rw() to access an iova
> range. Deny !ops->dma_unmap cases in vfio_pin/unpin_pages().
>=20
> Suggested-by: Kevin Tian <kevin.tian@intel.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  drivers/vfio/vfio_main.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c
> index 8559c3dfb335..c7f3251ad6e5 100644
> --- a/drivers/vfio/vfio_main.c
> +++ b/drivers/vfio/vfio_main.c
> @@ -1543,6 +1543,8 @@ int vfio_pin_pages(struct vfio_device *device,
> dma_addr_t iova,
>=20
>  		if (iova > ULONG_MAX)
>  			return -EINVAL;
> +		if (!device->ops->dma_unmap)
> +			return -EINVAL;
>  		/*
>  		 * VFIO ignores the sub page offset, npages is from the start
> of
>  		 * a PAGE_SIZE chunk of IOVA. The caller is expected to
> recover
> @@ -1580,6 +1582,8 @@ void vfio_unpin_pages(struct vfio_device *device,
> dma_addr_t iova, int npage)
>  	if (device->iommufd_access) {
>  		if (WARN_ON(iova > ULONG_MAX))
>  			return;
> +		if (!device->ops->dma_unmap)
> +			return;

IMHO this restriction applies to both iommufd and legacy container.