From:   Brian Cain <bcain@quicinc.com>
To:     Yang Li <yang.lee@linux.alibaba.com>
CC:     "linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: RE: [PATCH -next] hexagon: Fix warning comparing pointer to 0
Thread-Topic: [PATCH -next] hexagon: Fix warning comparing pointer to 0
Thread-Index: AQHZO1pBBQyAbx+bdEmFoZLArzIKPK7GEcuw
Date:   Thu, 9 Feb 2023 05:07:08 +0000
Message-ID: <SN6PR02MB4205B282F3C5BD2C9B3B07A4B8D99@SN6PR02MB4205.namprd02.prod.outlook.com>
References: <20230208011105.80219-1-yang.lee@linux.alibaba.com>
In-Reply-To: <20230208011105.80219-1-yang.lee@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EuwZxGk7rR3H+B8vf5hTjqPFRdKjdNSa7ASx2HBeCSEB3QX0UXPtGUi523b9?=
 =?us-ascii?Q?1F+fYukEJzKNxMTsM7L2j/0WbVAeHhOiy2ffF72KR8atkiSZQs4KTqszN3dO?=
 =?us-ascii?Q?5zA29MqqxwQhfyp87ry2CzLdY0fUafa98UNyck2NJnKuDbXrAzXxx4cpt7kk?=
 =?us-ascii?Q?JsYjFsyhPN1XISvZwjDrQuoUQpVM23pLz/LniW8ZZra9LkrQrxdpGaMu4yze?=
 =?us-ascii?Q?grl3ic6bGiWHEjoEPB1o6otwuHu9aryhtEmW1qKarPsvpfxyNJCXSlWUNL1e?=
 =?us-ascii?Q?ySAZN9REzq65zvT+papKLJb2K44WovOusCrRgV/wCE31DohwCcX9wmxG8GKx?=
 =?us-ascii?Q?a4bvZK32pf5TjK8emaY8wFFqPT/d5WOqMi0+1jc8QXQ6ZhUK5oCdxcS2Imr/?=
 =?us-ascii?Q?H+YxkY3u5318K0dK9HHLT2W6IQCn+9DfMnV21UZhmZbicRr13E+ZpZR0F1Wc?=
 =?us-ascii?Q?7RovLLjqtbag5Y21Yu9E0Sngincd9ZBpzOpCgA5I2qQUCBotcQTOjy6kiP6J?=
 =?us-ascii?Q?jbov/BOTM6gbL+F8v0FYzDt3+lnozVX5opjhpB2lAEzJ6TFnw9jChNXCuPG/?=
 =?us-ascii?Q?vAWDcQAA+uUYpVPGl0lznCeb2ZlWJF+zEnK9hhaKT9sFtAzQh+T0qBLgY0gD?=
 =?us-ascii?Q?Sn2FZ2ESnxwJ7vIE9J9xwaNhxQg0Xk0DMcvJDNyTtUm2ei+leOV0RTlzPoJY?=
 =?us-ascii?Q?uC0sfLE33tT9z5f6wpRvOM2ehp3fAy/vS/gul25zCGFUHXnGo2f6RWqp947z?=
 =?us-ascii?Q?m3oVB9HIn82weDMj7g4aDTWLizrh7ijLbkaftVBMrYDEXBSjElanU3qh0RJ9?=
 =?us-ascii?Q?qAJo3cSsVJLcxd1V+sDHYPmnABJ5+dXpQ18MiN528ZF9kNlRuC1pJOXFeHaV?=
 =?us-ascii?Q?DqkwhViihA2ixHpWBl/omkwDya5ftyo/DNvBVQo/HMg3zTMNNv8L/ecDU2XL?=
 =?us-ascii?Q?1+QA/6lTYhSW9QSapS+7IOTXoe3RzeVIpdhwToDrYedBkX9ST0I90Ag9bQ1/?=
 =?us-ascii?Q?MP5v1QhLjVyEkmU/2Hxt6SUSRxVch6ruEjXRmkPOk7Wkx1n+ifxgNbU8hAs1?=
 =?us-ascii?Q?vEOJk+U4yRRt4Lf17KMmF4gxo+V3F3vSCgJeDV4BpY+CgZNSG7r+qcxRTI/k?=
 =?us-ascii?Q?ZjeVR0DzNN0VPAgQqMRkQ6zWqdR3Q432wAykqeHYy/tpfHDxh3IZqW4bDfhD?=
 =?us-ascii?Q?2mFZXqrN8zpiEvBEnFr/H2OQ1xB/ettxkhQqBMHfl1Dn3gggMo/dKl4vpZZx?=
 =?us-ascii?Q?7/txuufQyHnCSTgZtlZtfdmTcmFIptKZsdVbV2/YqrdR3yDKnjV5jfq0iUGk?=
 =?us-ascii?Q?j1AfbwLPEqmZaGsBcJmJJpenUCzTLFAjdKTVeJvdN/DyAAc4wu0X8WgoNgCE?=
 =?us-ascii?Q?Nm/XnMloCgPIzCPvNN3kbNRnH/rHEGSrKRiuJGbZNxz4sdEGcH0OGfRBEi+a?=
 =?us-ascii?Q?b/o+4DV00fJ84FC5XgFZi3+G33xjqlUpbvWHex7hCIaiYKtCgVyJmtRwFIAL?=
 =?us-ascii?Q?nC98y81wPUBxvumwlK/RSwWzVdtSS30Osj5ipSWLtBwAiMM0Qmzq3E+TZSPU?=
 =?us-ascii?Q?Xvwd6RC2+nDLwzg3McFYqfKgt8QdHlyMESKtD1u/?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: oy8+ssIWP7sn6tVSj+A3bh7ajJ2bPGRc++BstBgzDl3VSFXanrOZtSmSVdG1jk6D4CTlMwVPCvnsi7xoZVSHiveVcD9snohIC0pnGkF1kWLYiqiOi6oE+jG0KFTnvpoX1xa9zcbO/N8wVpsRkYy0SeBlWOIsJvrhjWWWOoz8HDez1Yygt5c2AbMgpzqUao+tP++pND/niYUlxo2SpiBo2s0dxeDO27OG1apVhZIVRoZI0Uo6H+ziz4aXPNLlEqSQpo+xVWBl7p5vGZIHUW22mSGzRssvj95SNZd/AYSESvk94PwUwcmtC8cuCiJbGMpAhCjl4ctiqOR5ZZ4nvUJeu6o1uT6WO83tlJIbLLhk7hKEH38S8KdQDLdryUwIzjMSULZ9syn513P7bFrtMpOD/5wRiVYbbvSQ4bac/h6TTwzDV6abnTL/w18ghvD7kECIqJ7TMcoAKW2tSZMj8O9H8UHwhNQKmVJUQtO4qrmzqyiKNxdi6YgBKFcGnc116i2qSxKjO5CQzqhwpmYfRiNnDCM3mXaSli1F6giawxUIPecJFv5nAaA5HpNsVX6t4DQp1Nbr/Epp2rC5bCsPAVbnf74G57KA9Ubez9IKamHqmOXNm1vF9cpReoVNjJPyl+76nrdriycj/MMGD2sBle8KnfYPgmZT0KkP85b/cTGS3O6+7G9Q/p5OW/HKP7rkk2vJn2czgoVItsNoGbmGIlxDOUGHA1nmA2TYPqv6cNdda/WrOMYw7UyDeRz/LTfRK1JLYEyd9jYbHhX5Hwrx4dPBKZkoF+AFDfTwS5q8sPoswixDIp0L/wwjUAcuDYfkhwVEa+AHRCywBvUDxi0jH3lV9g==
X-OriginatorOrg: quicinc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4205.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12bd6485-5f9c-4fdf-9b82-08db0a5b7edc
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2023 05:07:08.9277
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 98e9ba89-e1a1-4e38-9007-8bdabc25de1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lnTWd8ZM2oTkD+IH1D6F+2OPbruU6+r3FYOBRaohADzO7Uwcb2USsjlnNSYswNzbSyq126szcCwNoAzVdqZePQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB7622
X-Proofpoint-ORIG-GUID: 7o3xmFpgiDLt9vDbEYmJ6djnHCOe70Aj
X-Proofpoint-GUID: 7o3xmFpgiDLt9vDbEYmJ6djnHCOe70Aj
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-02-09_02,2023-02-08_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 adultscore=0 impostorscore=0 mlxscore=0 phishscore=0 clxscore=1011
 mlxlogscore=437 suspectscore=0 malwarescore=0 bulkscore=0
 priorityscore=1501 spamscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2212070000 definitions=main-2302090046
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Yang Li <yang.lee@linux.alibaba.com>
...
> ./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0
>=20
> Avoid pointer type value compared with 0 to make code clear.
>=20
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D3978
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  arch/hexagon/kernel/traps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c
> index 6447763ce5a9..fdbbf78b4ce0 100644
> --- a/arch/hexagon/kernel/traps.c
> +++ b/arch/hexagon/kernel/traps.c
> @@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task,
> unsigned long *fp,
>                 }
>=20
>                 /* Attempt to continue past exception. */
> -               if (0 =3D=3D newfp) {
> +               if (!newfp) {
>                         struct pt_regs *regs =3D (struct pt_regs *) (((vo=
id *)fp)
>                                                 + 8);
>=20
> --
> 2.20.1.7.g153144c

Acked-by: Brian Cain <bcain@quicinc.com>