Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\))
Subject: Re: [PATCH v4 2/2] Bluetooth: btrtl: add support for the RTL8723CS
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <CABBYNZKnt5=dar6Rmav=Tv3QH1ghSUV2osZPnp7OQLcANp_1Tw@mail.gmail.com>
Date:   Thu, 9 Feb 2023 08:02:06 +0100
Cc:     Bastian Germann <bage@debian.org>,
        Vasily Khoruzhick <anarsoul@gmail.com>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        BlueZ <linux-bluetooth@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org
Content-Transfer-Encoding: 7bit
Message-Id: <0B0EFD39-825F-4635-A7F3-CA96BCFED9A2@holtmann.org>
References: <20230208155220.1640-1-bage@debian.org>
 <20230208155220.1640-3-bage@debian.org>
 <CABBYNZKnt5=dar6Rmav=Tv3QH1ghSUV2osZPnp7OQLcANp_1Tw@mail.gmail.com>
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Precedence: bulk

Hi Luiz,

>> The Realtek RTL8723CS is a SDIO WiFi chip. It also contains a Bluetooth
>> module which is connected via UART to the host.
>> 
>> It shares lmp subversion with 8703B, so Realtek's userspace
>> initialization tool (rtk_hciattach) differentiates varieties of RTL8723CS
>> (CG, VF, XX) with RTL8703B using vendor's command to read the chip type.
> 
> Don't remember anything called rtk_hciattach, besides if that is based
> on hciattach that is already deprecated in favor of btattach.

and btattach is also deprecated. Write a proper serdev based driver.

The hci_ldisc line discipline crap needs to be removed.

Regards

Marcel