Date:   Thu, 9 Feb 2023 08:14:37 +0100
From:   Henrik Grimler <henrik@grimler.se>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        replicant@osuosl.org, phone-devel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht,
        Martin =?iso-8859-1?Q?J=FCcker?= <martin.juecker@gmail.com>
Subject: Re: [RFT PATCH 1/3] ARM: dts: exynos: add "gpios" suffix to
 wlf,ldo1ena on Midas
Message-ID: <Y+SdXZpJbm+7+SPp@L14.lan>
References: <20230208172634.404452-1-krzysztof.kozlowski@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230208172634.404452-1-krzysztof.kozlowski@linaro.org>
Precedence: bulk

On Wed, Feb 08, 2023 at 06:26:32PM +0100, Krzysztof Kozlowski wrote:
> The GPIOs properties should end with "gpios" suffix and Linux gpiolib
> already handles both names, so switch to preferred one.
> 
> While touching the lines, replace open-coded GPIO_ACTIVE_HIGH flag.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Tested-by: Henrik Grimler <henrik@grimler.se>

Audio still works fine on i9300, and there are no new warnings/errors
in dmesg.

Best regards,
Henrik Grimler

> ---
>  arch/arm/boot/dts/exynos4412-midas.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
> index d5074fa57142..525f945c4b91 100644
> --- a/arch/arm/boot/dts/exynos4412-midas.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
> @@ -653,8 +653,8 @@ wm1811: audio-codec@1a {
>  		CPVDD-supply = <&vbatt_reg>;
>  		SPKVDD1-supply = <&vbatt_reg>;
>  		SPKVDD2-supply = <&vbatt_reg>;
> -		wlf,ldo1ena = <&gpj0 4 0>;
> -		wlf,ldo2ena = <&gpj0 4 0>;
> +		wlf,ldo1ena-gpios = <&gpj0 4 GPIO_ACTIVE_HIGH>;
> +		wlf,ldo2ena-gpios = <&gpj0 4 GPIO_ACTIVE_HIGH>;
>  	};
>  };
>  
> -- 
> 2.34.1
>